Whamcloud - gitweb
debugfs: fix shadow and sign-compare -Wall warnings
authorTheodore Ts'o <tytso@mit.edu>
Tue, 17 Aug 2021 22:00:55 +0000 (18:00 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 19 Aug 2021 03:01:44 +0000 (23:01 -0400)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
debugfs/logdump.c

index 74b8935..5416f9e 100644 (file)
@@ -67,7 +67,7 @@ static void dump_metadata_block(FILE *, struct journal_source *,
                                int, tid_t);
 
 static void dump_fc_block(FILE *out_file, char *buf, int blocksize,
-                         int transaction, int *fc_done, int dump_old);
+                         tid_t transaction, int *fc_done);
 
 static void do_hexdump (FILE *, char *, int);
 
@@ -522,8 +522,7 @@ fc:
                if (retval)
                        return;
 
-               dump_fc_block(out_file, buf, blocksize, transaction, &fc_done,
-                       dump_old);
+               dump_fc_block(out_file, buf, blocksize, transaction, &fc_done);
                if (!dump_old && fc_done)
                        break;
                blocknr++;
@@ -549,7 +548,7 @@ static inline size_t journal_super_tag_bytes(journal_superblock_t *jsb)
 }
 
 static void dump_fc_block(FILE *out_file, char *buf, int blocksize,
-       int transaction, int *fc_done, int dump_old)
+                         tid_t transaction, int *fc_done)
 {
        struct ext4_fc_tl       tl;
        struct ext4_fc_head     *head;
@@ -706,7 +705,7 @@ static void dump_revoke_block(FILE *out_file, char *buf,
                              int blocksize EXT2FS_ATTR((unused)),
                              tid_t transaction)
 {
-       int                     offset, max;
+       unsigned int            offset, max;
        jbd2_journal_revoke_header_t *header;
        unsigned long long      rblock;
        int                     tag_size = sizeof(__u32);