Whamcloud - gitweb
e2fsck: free bh on csum verify error in do_one_pass
authorEric Sandeen <sandeen@redhat.com>
Tue, 22 Jul 2014 16:40:30 +0000 (12:40 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 22 Jul 2014 16:40:30 +0000 (12:40 -0400)
Coverity (re-)spotted this; it was triaged as a false positive,
but it seems pretty clear that the bh (which was just checked)
isn't currently freed before the function exits.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
e2fsck/recovery.c

index 54579c2..66d02b2 100644 (file)
@@ -523,6 +523,7 @@ static int do_one_pass(journal_t *journal,
                            !jbd2_descr_block_csum_verify(journal,
                                                          bh->b_data)) {
                                err = -EIO;
+                               brelse(bh);
                                goto failed;
                        }