Whamcloud - gitweb
LU-7198 clio: remove mtime check in vvp_io_fault_start() 62/19162/4
authorBobi Jam <bobijam.xu@intel.com>
Sat, 26 Mar 2016 14:36:34 +0000 (22:36 +0800)
committerOleg Drokin <oleg.drokin@intel.com>
Mon, 25 Apr 2016 04:16:31 +0000 (04:16 +0000)
In fault IO initialization, inode's mtime is saved, and after
getting locks, when the IO is about to start, vvp_io_fault_start()
checks the mtime's intactness.

It's a false alarm, since the timestamp from MDS could be stale,
we maintain mtime mainly on OST objects, and if the check in
vvp_io_fault_start() happens before mtime on OST objects are merged,
it will get wrong timestamp from the inode, even the timestamp it
fetched in vvp_io_fault_init() could be wrong in the first place.

This patch remove the mtime check in vvp_io_fault_start().

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: Iff0a7f3ae789b443927fe2f3487829f357a93a4a
Reviewed-on: http://review.whamcloud.com/19162
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>

index daf75ac..a076e5a 100644 (file)
@@ -1217,12 +1217,6 @@ static int vvp_io_fault_start(const struct lu_env *env,
        pgoff_t                  last_index;
        pgoff_t                  last_index;
-       if (fio->ft_executable &&
-           LTIME_S(inode->i_mtime) != vio->u.fault.ft_mtime)
-               CWARN("binary "DFID
-                     " changed while waiting for the page fault lock\n",
-                     PFID(lu_object_fid(&obj->co_lu)));
         /* offset of the last byte on the page */
         /* offset of the last byte on the page */