From: Bobi Jam Date: Sat, 26 Mar 2016 14:36:34 +0000 (+0800) Subject: LU-7198 clio: remove mtime check in vvp_io_fault_start() X-Git-Tag: 2.8.53~42 X-Git-Url: https://git.whamcloud.com/?p=fs%2Flustre-release.git;a=commitdiff_plain;h=d62f58c32074bc54055801ed0f919bfd5c277f6d;ds=sidebyside LU-7198 clio: remove mtime check in vvp_io_fault_start() In fault IO initialization, inode's mtime is saved, and after getting locks, when the IO is about to start, vvp_io_fault_start() checks the mtime's intactness. It's a false alarm, since the timestamp from MDS could be stale, we maintain mtime mainly on OST objects, and if the check in vvp_io_fault_start() happens before mtime on OST objects are merged, it will get wrong timestamp from the inode, even the timestamp it fetched in vvp_io_fault_init() could be wrong in the first place. This patch remove the mtime check in vvp_io_fault_start(). Signed-off-by: Bobi Jam Change-Id: Iff0a7f3ae789b443927fe2f3487829f357a93a4a Reviewed-on: http://review.whamcloud.com/19162 Tested-by: Jenkins Reviewed-by: Andreas Dilger Tested-by: Maloo Reviewed-by: Jinshan Xiong --- diff --git a/lustre/llite/vvp_io.c b/lustre/llite/vvp_io.c index daf75ac..a076e5a 100644 --- a/lustre/llite/vvp_io.c +++ b/lustre/llite/vvp_io.c @@ -1217,12 +1217,6 @@ static int vvp_io_fault_start(const struct lu_env *env, pgoff_t last_index; ENTRY; - if (fio->ft_executable && - LTIME_S(inode->i_mtime) != vio->u.fault.ft_mtime) - CWARN("binary "DFID - " changed while waiting for the page fault lock\n", - PFID(lu_object_fid(&obj->co_lu))); - down_read(&lli->lli_trunc_sem); /* offset of the last byte on the page */