Whamcloud - gitweb
tools/e2fsprogs.git
15 years agoDocument the extent and huge file flags in the chattr.1.in man page
Andreas Dilger [Mon, 25 Aug 2008 00:24:23 +0000 (20:24 -0400)]
Document the extent and huge file flags in the chattr.1.in man page

Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck_write_bitmaps() optimization
Andreas Dilger [Sun, 24 Aug 2008 02:56:07 +0000 (20:56 -0600)]
e2fsck_write_bitmaps() optimization

This patch changes the e2fsck_write_bitmaps() function to write out the
block and inode bitmaps together, instead of writing them in two passes.

Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agodebian: Add uuid-runtime.lintian-overrides
Theodore Ts'o [Sun, 24 Aug 2008 05:20:49 +0000 (01:20 -0400)]
debian: Add uuid-runtime.lintian-overrides

I want to make sure the uuidd daemon is shutdown before removing
the package.  Since the uuidd daemon is provided by the uuid-runtime
package, and I *know* exactly where it is, and I ***don't*** want the
script to be confused by some other pathname being used by the local
administrator, I specify an explicit pathname.  In addition, given the
explicit test to make sure /usr/sbin/uuidd exists, it seems non-sensical
to remove the prepended path.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: add libuuid1.lintian-overrides
Theodore Ts'o [Sun, 24 Aug 2008 05:18:55 +0000 (01:18 -0400)]
debian: add libuuid1.lintian-overrides

The libuuid1.postinst script doesn't really call adduser; it just
checks the adduser config file, if it exists.  The lintain maintainers
agree this is a spurious warning, and it will be fixed eventually.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Remove e2fsck-static.lintian-overrides
Theodore Ts'o [Sun, 24 Aug 2008 05:17:55 +0000 (01:17 -0400)]
debian: Remove e2fsck-static.lintian-overrides

This override is no longer necessary since lintian excludes foo.static
binaries from the static binary test.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix mke2fs man page to escape all minus signs
Theodore Ts'o [Sun, 24 Aug 2008 05:04:43 +0000 (01:04 -0400)]
Fix mke2fs man page to escape all minus signs

Option specifiers must be escaped so the are printed as minus signs
(U+002D) instead of hyphens (U+2010).  Hence "mke2fs -t ext4" must be
expressed as "mke2fs \-t ext4" instead.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Add debian/watch file
Theodore Ts'o [Sun, 24 Aug 2008 04:45:15 +0000 (00:45 -0400)]
debian: Add debian/watch file

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebugfs: Print the progname instead of argv[0] in error message
Manish Katiyar [Sat, 23 Aug 2008 16:58:05 +0000 (22:28 +0530)]
debugfs: Print the progname instead of argv[0] in error message

Trivial fix to print the progname instead of argv[0] in error message.

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agodebugfs: Close the file handle and return in case of errors
Manish Katiyar [Sat, 23 Aug 2008 16:11:25 +0000 (21:41 +0530)]
debugfs: Close the file handle and return in case of errors

Close the filehandle and return in case if we are unable to expand the
directory during write.

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agolibblkid: Strengthen the JFS probe routine
Theodore Ts'o [Sun, 24 Aug 2008 02:27:22 +0000 (22:27 -0400)]
libblkid: Strengthen the JFS probe routine

Check to make sure a JFS filesystem is really correct by checking the
relationship between the following fields in the JFS superblock:
s_bsize, s_l2bsize, s_pbsize, s_l2pbsize, and s_l2bfactor.  Thanks to
Lesh Bogdanow for this suggestion.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Fix false detection of DFSee created filesystems.
Theodore Ts'o [Sun, 24 Aug 2008 02:11:01 +0000 (22:11 -0400)]
libblkid: Fix false detection of DFSee created filesystems.

OS/2 and DFSee creates a pseudo FAT-12/16 header in the first 512
bytes of a filesystem which looks enough like a FAT-12/16 to fool
blkid.  Part of this is because we don't require ms_magic or vs_magic
to be the strings "FAT12 ", "FAT16 ", or "FAT32 ", since some FAT
filesystem formatters don't set ms_magic or vs_magic.  To address
this, we explicitly test for "JFS     " and "HPFS    " in ms_magic,
and if they are found, we assume the filesystem is definitely not
a FAT filesystem.

Addresses-Launchpad-Bug: #255255

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoInterim update of the debian/changelog and the release notes
Theodore Ts'o [Sat, 23 Aug 2008 15:43:08 +0000 (11:43 -0400)]
Interim update of the debian/changelog and the release notes

This is in preparation for an e2fsprogs 1.41.1 release.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Fix memory leak in ext2fs_initialize().
Manish Katiyar [Sat, 23 Aug 2008 11:41:07 +0000 (17:11 +0530)]
libext2fs: Fix memory leak in ext2fs_initialize().

Below patch ensures that cleanup is done properly in ext2fs_initialize
from all return paths in case of errors.

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2ed: Remove masix support
Manish Katiyar [Sat, 23 Aug 2008 11:51:27 +0000 (07:51 -0400)]
ext2ed: Remove masix support

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agomke2fs: Issue a warning if the mke2fs.conf file wasn't updated
Theodore Ts'o [Sat, 23 Aug 2008 01:57:29 +0000 (21:57 -0400)]
mke2fs: Issue a warning if the mke2fs.conf file wasn't updated

Many people are forgetting to update their mke2fs.conf file, and this
means that filesystems aren't getting created with the proper features
enabled.  So detect this case and issue a warning.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Portability fix: Use WORDS_BIGENDIAN instead of __LITTLE_ENDIAN
Theodore Ts'o [Fri, 22 Aug 2008 23:19:18 +0000 (19:19 -0400)]
e2fsck: Portability fix: Use WORDS_BIGENDIAN instead of __LITTLE_ENDIAN

__LITTLE_ENDIAN is set by the glibc headers, and isn't portable.  We
should be using WORDS_BIGENDIAN, which is set by autoconf.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Enhance support for MacOS's hfs, hfsplus, and hfsx filesystems
Theodore Ts'o [Fri, 22 Aug 2008 20:45:44 +0000 (16:45 -0400)]
libblkid: Enhance support for MacOS's hfs, hfsplus, and hfsx filesystems

Add detection for hfsx filesystems.  Add label and uuid detetion for
hfs, hfsplus, and hfsx.

Addresses-Sourceforge-Feature-Requests: #2060292

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Fix potential crash if blkid cache is out of date when probing
Theodore Ts'o [Fri, 22 Aug 2008 16:43:14 +0000 (12:43 -0400)]
libblkid: Fix potential crash if blkid cache is out of date when probing

Fix bug added in 57926c8c5566f0ef5b77db326d58aa0643cf6270

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoconfigure.in: Respect LDFLAGS environment variable if passed into configure
Theodore Ts'o [Fri, 22 Aug 2008 16:26:07 +0000 (12:26 -0400)]
configure.in: Respect LDFLAGS environment variable if passed into configure

If the --with-ldopts option is not passed on the command line, respect
the LDFLAGS environment variable instead of forcing LDFLAGS to be
unset.  "configure --help" documents LDFLAGS as part of the standard
configure script calling convention.

Addresses-Sourceforge-Feature-Request: #1937287

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibuuid: Windows portability fixes
Theodore Ts'o [Fri, 22 Aug 2008 16:15:56 +0000 (12:15 -0400)]
libuuid: Windows portability fixes

Make the uuid library (more) portable for Windows.

Addresses-Sourceforge-Feature-Request: #1937287

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoconfigure.in: use AC_MSG_{RESULT,WARN,ERROR} instead of echo
Theodore Ts'o [Fri, 22 Aug 2008 14:52:42 +0000 (10:52 -0400)]
configure.in: use AC_MSG_{RESULT,WARN,ERROR} instead of echo

This gives us standard behavior when using flags such as --quiet, and
gives us standard warning output when showing warnings and errors.

Addresses-Sourceforge-Patches: #2058794

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Replace use of sprintf with strcpy/strcat to help SILO
Theodore Ts'o [Fri, 22 Aug 2008 14:37:18 +0000 (10:37 -0400)]
libext2fs: Replace use of sprintf with strcpy/strcat to help SILO

Some bootloaders, like SILO, don't provide sprintf in their limited
bootloader environment.  Since the uses in rw_bitmaps.c is only doing
sprintf("foo %s"), it's easy to replace that usage with strcpy/strcat.

Addresses-Sourceforge-Bug: #2049120

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoresize2fs: Make sure we close out the progress bar in pass #4
Theodore Ts'o [Fri, 22 Aug 2008 13:26:26 +0000 (09:26 -0400)]
resize2fs: Make sure we close out the progress bar in pass #4

This fixes a cosemtic issue where we don't complete the progress bar
and issue a newline before printing the final resize successful
message.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: Add Indonesian translation from the Translation Project
Theodore Ts'o [Fri, 22 Aug 2008 07:26:26 +0000 (03:26 -0400)]
po: Add Indonesian translation from the Translation Project

15 years agopo: update de.po (from translationproject.org)
Philipp Thomas [Fri, 22 Aug 2008 07:22:50 +0000 (03:22 -0400)]
po: update de.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoresize2fs: supply block allocator for extents function
Theodore Ts'o [Fri, 22 Aug 2008 07:07:53 +0000 (03:07 -0400)]
resize2fs: supply block allocator for extents function

In the rare case where new blocks are needed while mutating an extent
tree, supply a specialized block allocator so that extent_node_split()
allocates valid blocks for the interior nodes of the extent tree.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoresize2fs: Fix support for filesystems with the uninit_bg feature
Theodore Ts'o [Fri, 22 Aug 2008 07:03:42 +0000 (03:03 -0400)]
resize2fs: Fix support for filesystems with the uninit_bg feature

If the filesystem has the uninit_bg feature, then parts of the block
and inode bitmap may not be initialized.  Teach resize2fs how to deal
with these case appropriately.  (Most of these fixes were fortunately
not necessary for the common case where the resize_inode is present to
reserve space, and where the filesystem is being expanded instead of
being shrunk.)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Add support for uninit_bg feature to allocation functions
Theodore Ts'o [Fri, 22 Aug 2008 06:52:12 +0000 (02:52 -0400)]
libext2fs: Add support for uninit_bg feature to allocation functions

If the allocation functions need to allocate out of a block group
where the inode and/or block bitmaps have not yet been initialized,
initialize them so ext2fs_new_block() and ext2fs_new_inode() work
correctly.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2fs_block_iterate2(): Support changing interior nodes of an extent tree
Theodore Ts'o [Fri, 22 Aug 2008 06:50:02 +0000 (02:50 -0400)]
ext2fs_block_iterate2(): Support changing interior nodes of an extent tree

Resize2fs needs to be able to relocate the interior nodes of an extent
tree.  Add support for this feature via ext2fs_extent_replace().

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2fs_extent_set_bmap(): Avoid creating extra extents for resize2fs
Theodore Ts'o [Fri, 22 Aug 2008 06:46:16 +0000 (02:46 -0400)]
ext2fs_extent_set_bmap(): Avoid creating extra extents for resize2fs

When resize2fs moves blocks belonging to an inode, it will call
ext2fs_extent_set_bmap() for logical blocks 0, 1, 2, 3, ...

Optimize for this calling pattern so we don't end up creating a
separate extent for each block.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2fs_extent_set_bmap(): fix bug when replacing a single block extent
Theodore Ts'o [Fri, 22 Aug 2008 06:39:46 +0000 (02:39 -0400)]
ext2fs_extent_set_bmap(): fix bug when replacing a single block extent

When replacing a single block extent, make sure we set or clear the
uninitialized extent flag as requested by the caller.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix ext2fs_extent_set_bmap() when setting a block before the first extent
Theodore Ts'o [Fri, 22 Aug 2008 06:32:28 +0000 (02:32 -0400)]
Fix ext2fs_extent_set_bmap() when setting a block before the first extent

When setting a logical block which is before the first extent in the
extent tree, make sure the new extent goes in front, at the very
beginning of the extent tree.  This fixes a bug where previously the
new extent would be inserted out of order in this case.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Fix reading bitmaps from e2image files
Theodore Ts'o [Thu, 21 Aug 2008 21:56:44 +0000 (17:56 -0400)]
libext2fs: Fix reading bitmaps from e2image files

Fix a signed vs. unsigned bug that was accidentally introduced in
commit f1f115a7, which was introduced in e2fsprogs 1.41.0

Addresses-Debian-Bug: #495830

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoresize2fs: Fix double bumping of directory in-use counts
Theodore Ts'o [Mon, 18 Aug 2008 03:20:16 +0000 (23:20 -0400)]
resize2fs: Fix double bumping of directory in-use counts

When moving directories into new block groups (which would only happen
when shrinking a filesystem), resize2fs would increase the directory
in-use count by 2 times the necessary value, due to a change in
ext2fs_inode_alloc_stats() made in e2fsprogs 1.26.  This is largely
harmless, but it does result in a filesystem corruption for e2fsck to
fix.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: fix spurious complaints about i_size caused by preallocated blocks
Theodore Ts'o [Mon, 18 Aug 2008 03:14:30 +0000 (23:14 -0400)]
e2fsck: fix spurious complaints about i_size caused by preallocated blocks

For inodes with blocks preallocated with FALLOC_FL_KEEP_SIZE, e2fsck
complained about i_size being too small.  Fix this.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Fix max size calculation for extent files
Theodore Ts'o [Sun, 17 Aug 2008 13:41:38 +0000 (09:41 -0400)]
e2fsck: Fix max size calculation for extent files

A misunderstanding C's precedence rules and the meaning of
s_log_block_size meant that we were capping the maximum size of
extent-based files at 8GB instead of the 64TB that it should be for
filesystems with 4k block sizes.

Addresses-Kernel-Bugzilla: #11341

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update nl.po (from translationproject.org)
Benno Schulenberg [Sat, 16 Aug 2008 16:26:28 +0000 (12:26 -0400)]
po: update nl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agolibext2fs : Fix memory leaks in ext2fs_extent_open()
Manish Katiyar [Fri, 15 Aug 2008 20:56:43 +0000 (02:26 +0530)]
libext2fs : Fix memory leaks in ext2fs_extent_open()

Memory allocated for the ext2_extent_handle is not getting freed from
all the return paths in case of error. Below patch fixes it.

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoFix a typo in lib/e2p/Makefile.in
Li Zefan [Wed, 6 Aug 2008 09:09:11 +0000 (17:09 +0800)]
Fix a typo in lib/e2p/Makefile.in

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agolibext2fs: Initialize unset inode timestamps when writing a new inode
Theodore Ts'o [Thu, 14 Aug 2008 18:30:05 +0000 (14:30 -0400)]
libext2fs: Initialize unset inode timestamps when writing a new inode

As Li Zefan <lizf@cn.fujitsu.com> reported, the creation timestamp was
not getting set on the lost+found inode.  This patch makes sure all of
the timestamps are appropriately set.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: On the man page, replace empty references with an existing one.
Benno Schulenberg [Thu, 31 Jul 2008 20:49:19 +0000 (22:49 +0200)]
libblkid: On the man page, replace empty references with an existing one.

And update the FSF's address.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoblkid: On the man page, show option arguments in the descriptions.
Benno Schulenberg [Thu, 31 Jul 2008 20:25:36 +0000 (22:25 +0200)]
blkid: On the man page, show option arguments in the descriptions.

Also rephrase two sentences and add a comma or two.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agomke2fs: Fix several typos in the man page.
Benno Schulenberg [Wed, 30 Jul 2008 22:06:36 +0000 (00:06 +0200)]
mke2fs: Fix several typos in the man page.

Also add the missing argument of the -M option, replace the mistaken
[libdefaults] section header with [defaults], and slightly rephrase
two or three sentences.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoe2fsck: Fix ind/dind/tind statistics and add extent depth statistics
Theodore Ts'o [Thu, 14 Aug 2008 13:48:07 +0000 (09:48 -0400)]
e2fsck: Fix ind/dind/tind statistics and add extent depth statistics

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Fix signed/unsigned error in fragcheck report for indirect blocks
Theodore Ts'o [Wed, 13 Aug 2008 02:11:02 +0000 (22:11 -0400)]
e2fsck: Fix signed/unsigned error in fragcheck report for indirect blocks

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Fix check to see if an extent-based file is fragmented
Theodore Ts'o [Mon, 11 Aug 2008 02:43:24 +0000 (22:43 -0400)]
e2fsck: Fix check to see if an extent-based file is fragmented

Also added support for "e2fsck -E fragcheck" which issues a
comprehensive report of discontiguous file extents.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoblkid: Fix probing logic so we find renamed devices
Theodore Ts'o [Sun, 10 Aug 2008 02:37:58 +0000 (22:37 -0400)]
blkid: Fix probing logic so we find renamed devices

This fixes a bug where if there is an entry in the /etc/blkid.tab file
for a particular device (major, minor) number but the filename does
not exist, blkid wouldn't try to find the correct filename.

Addresses-Debian-Bug: #493216

15 years agodebugfs: Fix htree command so it works with extent-based directories
Theodore Ts'o [Fri, 8 Aug 2008 15:56:07 +0000 (11:56 -0400)]
debugfs: Fix htree command so it works with extent-based directories

Also add support to dump out the minor hash value in addition to the
major hash.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agotune2fs: Improve the error messages for tune2fs -I
Theodore Ts'o [Sun, 27 Jul 2008 20:00:48 +0000 (16:00 -0400)]
tune2fs: Improve the error messages for tune2fs -I

If the current inode size is less than or equal to the requested inode
size, either explain that shrinking the inode size is not supported,
or that the inode is already the requested size.  Also, open the
filesystem provisionally first to do the inode size check and don't
setup up the undo log until we know that we're actually going to
perform the inode resizing operation.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agomke2fs/tune2fs: Fix max journal size in message to be consistent/correct
Theodore Ts'o [Fri, 25 Jul 2008 16:41:32 +0000 (12:41 -0400)]
mke2fs/tune2fs: Fix max journal size in message to be consistent/correct

Addresses-Debian-Bug: #491620

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update sv.po (from translationproject.org)
Göran Uddeborg [Thu, 24 Jul 2008 15:59:22 +0000 (11:59 -0400)]
po: update sv.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update nl.po (from translationproject.org)
Benno Schulenberg [Thu, 24 Jul 2008 15:59:22 +0000 (11:59 -0400)]
po: update nl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update cs.po (from translationproject.org)
Petr Pisar [Thu, 24 Jul 2008 15:59:21 +0000 (11:59 -0400)]
po: update cs.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopartinfo: Fix usage message
Theodore Ts'o [Wed, 23 Jul 2008 20:50:04 +0000 (16:50 -0400)]
partinfo: Fix usage message

Thanks to Göran Uddeborg for pointing this out.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsprogs: Fix tst_extents output on bigendian machine.
Aneesh Kumar K.V [Fri, 18 Jul 2008 12:05:40 +0000 (17:35 +0530)]
e2fsprogs: Fix tst_extents output on bigendian machine.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agotune2fs: Delete a stray word from a comment.
Benno Schulenberg [Thu, 17 Jul 2008 21:58:35 +0000 (23:58 +0200)]
tune2fs: Delete a stray word from a comment.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopartinfo: Print clearer error messages.
Benno Schulenberg [Thu, 17 Jul 2008 21:46:49 +0000 (23:46 +0200)]
partinfo: Print clearer error messages.

Also use complete sentences, instead of separate words filled
into a phrase.  And gettextize the main output message.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agobadblocks: Insert a missing "\n" in the usage string.
Benno Schulenberg [Thu, 17 Jul 2008 21:32:02 +0000 (23:32 +0200)]
badblocks: Insert a missing "\n" in the usage string.

Take the opportunity to wrap the string to be more readable,
and sort the options somewhat alphabetically.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoe2undo, tune2fs: Report the correct name for the undo program.
Benno Schulenberg [Thu, 17 Jul 2008 21:24:09 +0000 (23:24 +0200)]
e2undo, tune2fs: Report the correct name for the undo program.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agomke2fs: Fix enforcement of no features for revision 0 filesystems
Theodore Ts'o [Sat, 19 Jul 2008 01:08:56 +0000 (21:08 -0400)]
mke2fs: Fix enforcement of no features for revision 0 filesystems

Fix typo; instead of checking for s_feature_incompat twice, add check
for s_feature_ro_compat.

Thanks to Benno Schulenberg for noticing this problem.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix cross compilation issues in e2fsck/gen_crc32table
Theodore Ts'o [Sat, 19 Jul 2008 01:05:30 +0000 (21:05 -0400)]
Fix cross compilation issues in e2fsck/gen_crc32table

The Makefile should use BUILD_CFLAGS instead of ALL_CFLAGS since it
will be built for the host, not the target.

Addresses-Sourceforge-Bug: #2019287

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update de.po (from translationproject.org)
Philipp Thomas [Thu, 17 Jul 2008 15:47:00 +0000 (11:47 -0400)]
po: update de.po (from translationproject.org)

Addresses-Debian-Bugs: #313697, #401092

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoFix inode table allocation with flexbg
Frederic Bohe [Thu, 17 Jul 2008 11:34:41 +0000 (13:34 +0200)]
Fix inode table allocation with flexbg

Disordered inode tables may appear when inode_blocks_per_group is lesser
or equal to the number of groups in a flex group.

This bug can be reproduced with:
mkfs.ext4 -t ext4dev -G512 70G

In that case, you can see with dump2fs that inode tables for groups 510
and 511 are placed just after group 51's inode table instead of being
placed after group 509's inode table.

Signed-off-by: Frederic Bohe <frederic.bohe@bull.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update vi.po (from translationproject.org)
Clytie Siddall [Thu, 17 Jul 2008 15:08:59 +0000 (11:08 -0400)]
po: update vi.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update cs.po (from translationproject.org)
Petr Pisar [Thu, 17 Jul 2008 15:08:58 +0000 (11:08 -0400)]
po: update cs.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoFix missing space typo's in partinfo and resize2fs
Theodore Ts'o [Thu, 17 Jul 2008 14:50:26 +0000 (10:50 -0400)]
Fix missing space typo's in partinfo and resize2fs

These were caused by multi-line strings missing a space at the line
break.  Thanks to translator Phillipp Thomas for noticing these typo's.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update fr.po (from translationproject.org)
Theodore Ts'o [Thu, 17 Jul 2008 13:04:05 +0000 (09:04 -0400)]
po: update fr.po (from translationproject.org)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update pl.po (from translationproject.org)
Theodore Ts'o [Thu, 17 Jul 2008 13:03:50 +0000 (09:03 -0400)]
po: update pl.po (from translationproject.org)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update nl.po (from translationproject.org)
Theodore Ts'o [Thu, 17 Jul 2008 13:03:30 +0000 (09:03 -0400)]
po: update nl.po (from translationproject.org)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoAdd more intelligent handling of the mke2fs.conf installation process
Theodore Ts'o [Wed, 16 Jul 2008 17:39:32 +0000 (13:39 -0400)]
Add more intelligent handling of the mke2fs.conf installation process

For people who are compiling mke2fs for their own use outside of a
package manager, we need to make sure the system /etc/mke2fs.conf is
sufficiently up-to-date that it won't cause problems, but at the same
time we don't want to blow away any user-specific customizations.

So if /etc/mk2fs.conf exists, but does not mention ext4dev, we will
move it aside to /etc/mke2fs.conf.e2fsprogs-old and then install the
new mke2fs.conf.  If the /etc/mke2fs.conf file exists but does mention
ext4dev, we install the new mke2fs.conf file as
/etc/mke2fs.conf.e2fsprogs-new.  In both cases we print a warning
mesage to the user so they can manually update /etc/mke2fs.conf with
any changes if they so desire.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs : Fix typo in function names in libext2fs.texinfo
Manish Katiyar [Tue, 15 Jul 2008 19:08:40 +0000 (00:38 +0530)]
libext2fs : Fix typo in function names in libext2fs.texinfo

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agodebian: wrap copyright files to avoid "line too long" lintian warnings
Theodore Ts'o [Tue, 15 Jul 2008 16:38:55 +0000 (12:38 -0400)]
debian: wrap copyright files to avoid "line too long" lintian warnings

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Fix minor typo in uuid-runtime's package description
Theodore Ts'o [Tue, 15 Jul 2008 16:06:06 +0000 (12:06 -0400)]
debian: Fix minor typo in uuid-runtime's package description

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Update changelog for 1.40.0-3 release
Theodore Ts'o [Tue, 15 Jul 2008 15:40:45 +0000 (11:40 -0400)]
debian: Update changelog for 1.40.0-3 release

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Fix FTBFS problem on mips
Theodore Ts'o [Tue, 15 Jul 2008 15:38:33 +0000 (11:38 -0400)]
debian: Fix FTBFS problem on mips

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2fs_read_inode: Check the validity of the inode number earlier
Manish Katiyar [Tue, 15 Jul 2008 15:10:19 +0000 (11:10 -0400)]
ext2fs_read_inode: Check the validity of the inode number earlier

It looks like the right place to check for ino=0 in
ext2fs_read_inode_full() is before creating the inode cache, otherwise
since we set icache[i].ino = 0 in create_icache(), it will match the
loop below and thus we return a wrong value.

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoAdd an tune2fs.static target in misc/Makefile.in
Theodore Ts'o [Tue, 15 Jul 2008 04:03:16 +0000 (00:03 -0400)]
Add an tune2fs.static target in misc/Makefile.in

This is added as a convenience for distro's that need a static tune2fs
for whatever reason.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoDisable %.sh -> % GNU make rule in the top-level Makefile
Theodore Ts'o [Tue, 15 Jul 2008 02:38:01 +0000 (22:38 -0400)]
Disable %.sh -> % GNU make rule in the top-level Makefile

It's not needed for e2fsprogs, but one niche distribution likes to use
configure.sh files which can cause GNU make to inappropriately fire an
implicit rule to overwrite the configure file resulting in a fork bomb
leading to the OOM crash.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoblkid: Fix portability issue if TIOCGSIZE and TIOCGWINSZ are present
Theodore Ts'o [Mon, 14 Jul 2008 21:49:38 +0000 (17:49 -0400)]
blkid: Fix portability issue if TIOCGSIZE and TIOCGWINSZ are present

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoDon't assume that /bin/true is always in /bin
Theodore Ts'o [Mon, 14 Jul 2008 21:47:52 +0000 (17:47 -0400)]
Don't assume that /bin/true is always in /bin

... because it isn't on MacOS X

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Update section and priority of -dbg packages to match override file
Theodore Ts'o [Mon, 14 Jul 2008 00:51:33 +0000 (20:51 -0400)]
debian: Update section and priority of -dbg packages to match override file

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoAdd debian changelog for 1.41.0-2 release
Theodore Ts'o [Sun, 13 Jul 2008 23:20:02 +0000 (19:20 -0400)]
Add debian changelog for 1.41.0-2 release

15 years agolibblkid: Make sure we never reference a null dev->bid_type
Theodore Ts'o [Sun, 13 Jul 2008 23:10:10 +0000 (19:10 -0400)]
libblkid: Make sure we never reference a null dev->bid_type

There were a few places where we don't check to make sure
dev->bid_type is non-NULL before dereferencing the pointer, mostly in
debug code.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Don't check the group checksum when !GDT_CSUM
Theodore Ts'o [Sun, 13 Jul 2008 23:03:59 +0000 (19:03 -0400)]
libext2fs: Don't check the group checksum when !GDT_CSUM

ext2fs_group_desc_csum_verify() is always checking the bg_checksum (to
make sure it is zero) even when the GDT_CSUM feature is not present.
This is normally OK, but apparently there are filesystems in the wild
where this field has not be initialized to zero.

Addresses-Debian-Bug: #490637

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agobadblocks: If nanosleep() does not exist, try using usleep() instead
Theodore Ts'o [Sun, 13 Jul 2008 20:17:57 +0000 (16:17 -0400)]
badblocks: If nanosleep() does not exist, try using usleep() instead

For portability on systems that don't have nanosleep().

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2undo: Don't use __FUNCTION__ for portability reasons
Theodore Ts'o [Sun, 13 Jul 2008 19:44:32 +0000 (15:44 -0400)]
e2undo: Don't use __FUNCTION__ for portability reasons

Solaris C99 apparently doesn't support it.  We should report the
program name, not the internal function name, when printing an error
in any case.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Set LD_LIBRARY_PATH before running "make check" programs
Theodore Ts'o [Sun, 13 Jul 2008 19:41:35 +0000 (15:41 -0400)]
e2fsck: Set LD_LIBRARY_PATH before running "make check" programs

This is needed so that "make check" works in the e2fsck library even
if the shared libraries are not yet installed, and so that we run
those programs against the version of the libraries built in the build
tree.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFlush stdio buffers before calling setbuf()
Theodore Ts'o [Sun, 13 Jul 2008 19:40:15 +0000 (15:40 -0400)]
Flush stdio buffers before calling setbuf()

On Solaris setbuf() will discard any pending output to the stream, so
make we call fflush() before calling setbuf().

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoDefine _XOPEN_SOURCE to 600 consistently for Solaris C99 support
Theodore Ts'o [Sun, 13 Jul 2008 19:32:37 +0000 (15:32 -0400)]
Define _XOPEN_SOURCE to 600 consistently for Solaris C99 support

Solaris's header files are very picky about which C compiler can be
used for SUSv3 conformance.  Use of C99 is not compatible with SUSv2
(_XOPEN_SOURCE=500), and C89 is not compatible with SUSv3
(_XOPEN_SOURCE=600).  Since we need some SUSv3 functions, consistently
use SUSv3 so that e2fsprogs will build on Solaris using c99.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoRemove gcc-specific varargs macro in extent.c
Theodore Ts'o [Sun, 13 Jul 2008 18:19:14 +0000 (14:19 -0400)]
Remove gcc-specific varargs macro in extent.c

Use "#ifdef DEBUG // printf... // #endif" instead of dbg_printf().

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoRemove vararg macro which causes portability problems from ext3_extent.h
Theodore Ts'o [Sun, 13 Jul 2008 18:00:53 +0000 (14:00 -0400)]
Remove vararg macro which causes portability problems from ext3_extent.h

Also remove other unneeded kernel-only cruft for ext3_extent.h.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUse K&R style comments instead of C99 comments for portability
Theodore Ts'o [Sun, 13 Jul 2008 16:27:33 +0000 (12:27 -0400)]
Use K&R style comments instead of C99 comments for portability

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoOnly use __builtin_expect if __GNUC__ > 3
Theodore Ts'o [Sun, 13 Jul 2008 12:05:54 +0000 (08:05 -0400)]
Only use __builtin_expect if __GNUC__ > 3

Gcc only supports __builtin_expect for gcc versions 2.96 and up.
Since it's tricky to check for gcc 2.95 vs 2.96 (and either are only
used on really ancient systems anyway), we only use this optimization
on 3.x and newer versions of gcc.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Change kmem_cache_t to lkmem_cache_t for Solaris
Theodore Ts'o [Sun, 13 Jul 2008 12:04:36 +0000 (08:04 -0400)]
e2fsck: Change kmem_cache_t to lkmem_cache_t for Solaris

Solaris polutes the C namespace with kmem_cache_t when
you include in/netinet.h is included, so rename kmem_cache_t
to lkmem_cache_t.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix Solaris shell script portability issues
Theodore Ts'o [Sun, 13 Jul 2008 12:03:20 +0000 (08:03 -0400)]
Fix Solaris shell script portability issues

Solaris ships with a pathetically ancient shell in /bin/sh,
so fix various shell scripts to accomodate.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoblkid: Add new option -L which pretty-prints the device list
Theodore Ts'o [Sun, 13 Jul 2008 02:06:30 +0000 (22:06 -0400)]
blkid: Add new option -L which pretty-prints the device list

Also accessed via -o list, this new output format is much more
user-friendly and lists whether or not a particular device is mounted.

Addresses-Debian-Bug #490527

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Add stricter/earlier tests for blocksize in ext2fs_open()
Manish Katiyar [Fri, 11 Jul 2008 21:45:07 +0000 (17:45 -0400)]
libext2fs: Add stricter/earlier tests for blocksize in ext2fs_open()

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: fix potential memory leak in ext2fs_initialize()
Manish Katiyar [Fri, 11 Jul 2008 18:42:57 +0000 (14:42 -0400)]
libext2fs: fix potential memory leak in ext2fs_initialize()

If we fail doing ext2fs_allocate_block_bitmap() or
ext2fs_allocate_inode_bitmap() we directly goto cleanup and don't free
the memory allocated to buf.

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate release notes, changelog, etc., for e2fsprogs 1.41 release v1.41.0
Theodore Ts'o [Thu, 10 Jul 2008 21:24:22 +0000 (17:24 -0400)]
Update release notes, changelog, etc., for e2fsprogs 1.41 release

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate dependencies in the Makefile for lib/ext2fs
Theodore Ts'o [Thu, 10 Jul 2008 21:17:55 +0000 (17:17 -0400)]
Update dependencies in the Makefile for lib/ext2fs

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>