Whamcloud - gitweb
tools/e2fsprogs.git
15 years agoUpdate release notes, changelog, etc., for e2fsprogs 1.41.3 release v1.41.3
Theodore Ts'o [Sat, 11 Oct 2008 22:40:13 +0000 (18:40 -0400)]
Update release notes, changelog, etc., for e2fsprogs 1.41.3 release

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate e2fsprogs translation template file
Theodore Ts'o [Mon, 13 Oct 2008 03:17:54 +0000 (23:17 -0400)]
Update e2fsprogs translation template file

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Offer to clear the test_fs flag if ext4 is available
Theodore Ts'o [Mon, 13 Oct 2008 03:09:26 +0000 (23:09 -0400)]
e2fsck: Offer to clear the test_fs flag if ext4 is available

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Print the correct inode number for uninit-bg related problem reports
Theodore Ts'o [Sat, 11 Oct 2008 15:22:15 +0000 (11:22 -0400)]
e2fsck: Print the correct inode number for uninit-bg related problem reports

Fix the reporting for problem codes PR_2_INOREF_BG_INO_UNINIT and
PR_2_INOREF_IN_UNUSED.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Fix file descriptor leak when checking for a module
Theodore Ts'o [Sat, 11 Oct 2008 15:07:23 +0000 (11:07 -0400)]
libblkid: Fix file descriptor leak when checking for a module

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: exit from preenhalt if IO errors were encountered
Eric Sandeen [Fri, 10 Oct 2008 22:14:08 +0000 (17:14 -0500)]
e2fsck: exit from preenhalt if IO errors were encountered

If a block device is read-only, e2fsck -p gets into an infinite loop
trying to preenhalt, closing and flushing the fs, which tries to flush
the cache, which gets a write error and calls preenhalt which tries to
close and flush the fs ... ad infinitum.

Per Ted's suggestion just flag the ctx as "exiting" and short-circuit
the infinite loop.

Tested by running e2fsck -p on a block device set read-only by BLKROSET.

Thanks to Vlado Potisk for reporting this.

Addresses-Red-Hat-Bugzilla: #465679

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoresize2fs: check for bogus new_size
Eric Sandeen [Fri, 10 Oct 2008 22:38:15 +0000 (17:38 -0500)]
resize2fs: check for bogus new_size

If we don't check for new_size == 0, bogus values send resize2fs into
a tailspin:

resize2fs 1.41.0 (10-Jul-2008)
Illegal block number passed to ext2fs_test_block_bitmap #1 for block bitmap for
/tmp/tmp.lntZtMFvz8/fake-disk
...the same message repeated zillion times...

Probably should see where that loop is, but at any rate we should
error-check parse_num_blocks.

Thanks to Petr Muller for reporting this.

Addresses-Red-Hat-Bugzilla: #465984

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agounix_io: check for read-only devices when opening R/W
Eric Sandeen [Fri, 10 Oct 2008 22:17:43 +0000 (17:17 -0500)]
unix_io: check for read-only devices when opening R/W

When we open a device on linux, test whether it is writable
right away, rather than trying to proceed and clean up when
writes start failing.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agodebugfs: Fix ncheck when printing pathnames for multiple hardlinks in a directory
Theodore Ts'o [Fri, 10 Oct 2008 18:53:09 +0000 (14:53 -0400)]
debugfs: Fix ncheck when printing pathnames for multiple hardlinks in a directory

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix parallel build problem with util/subst
Theodore Ts'o [Fri, 10 Oct 2008 18:00:46 +0000 (14:00 -0400)]
Fix parallel build problem with util/subst

Make sure util/subst is built before trying to build lib/et

Addresses-Sourceforge-Bug: #2143281

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsprogs: fix blkid detection of ext4dev as ext4
Eric Sandeen [Wed, 8 Oct 2008 18:34:09 +0000 (13:34 -0500)]
e2fsprogs: fix blkid detection of ext4dev as ext4

If only ext4 is available (as a module or in /proc/filesystems)
blkid wasn't properly testing for it, because the time checks
were backwards and always failed.  This caused old ext4dev
filesystems to fail to mount as ext4.  With this patch it works
fine.

Also, don't try to check for modules on a non-Linux system.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoUpdate Makefile depend information for crc16.o
Theodore Ts'o [Thu, 2 Oct 2008 12:59:09 +0000 (08:59 -0400)]
Update Makefile depend information for crc16.o

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate release notes, changelog, etc., for e2fsprogs 1.41.2 release v1.41.2
Theodore Ts'o [Thu, 2 Oct 2008 03:16:06 +0000 (23:16 -0400)]
Update release notes, changelog, etc., for e2fsprogs 1.41.2 release

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibcom_err: Add missing type declarations to clean up -Wall warnings
Theodore Ts'o [Thu, 2 Oct 2008 12:51:27 +0000 (08:51 -0400)]
libcom_err: Add missing type declarations to clean up -Wall warnings

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agomke2fs.8: Add an explanation of how the -t and -O options interact
Theodore Ts'o [Thu, 2 Oct 2008 12:45:02 +0000 (08:45 -0400)]
mke2fs.8: Add an explanation of how the -t and -O options interact

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update sv.po (from translationproject.org)
Göran Uddeborg [Thu, 2 Oct 2008 01:52:02 +0000 (21:52 -0400)]
po: update sv.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agolibcom_err: Fix file descriptor leak after an exec
Theodore Ts'o [Thu, 2 Oct 2008 00:45:26 +0000 (20:45 -0400)]
libcom_err: Fix file descriptor leak after an exec

Some applications repeatedly re-exec themselves, and if they use the
com_err library, they can leak a file descriptor for each re-exec.
Fix this by setting the close-on-exec flag on the debug file
descriptor.  In addition, if the COMERR_DEBUG environment variable
isn't set, don't open the file handle at all.

Addresses-Red-Hat-Bugzilla: #464689

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix spelling mistake in e2fsck man page
Theodore Ts'o [Thu, 2 Oct 2008 00:27:41 +0000 (20:27 -0400)]
Fix spelling mistake in e2fsck man page

Addresses-Launchpad-Bug: #275272

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agobadblocks: Fix progress output for "badblocks -sw /dev/XXX"
Theodore Ts'o [Thu, 2 Oct 2008 00:00:54 +0000 (20:00 -0400)]
badblocks: Fix progress output for "badblocks -sw /dev/XXX"

Always initialize the starting time so that badblocks -sw works.
Thanks Jelle de Jong (jelledejong at powercraft.nl) for reporting this
bug.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebugfs: Make the usage messsage of logdump consistent with man page
Manish Katiyar [Wed, 1 Oct 2008 23:55:10 +0000 (19:55 -0400)]
debugfs: Make the usage messsage of logdump consistent with man page

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoresize2fs: Fix potential memory corruption in ext2fs_progress_init()
Manish Katiyar [Wed, 1 Oct 2008 23:42:57 +0000 (19:42 -0400)]
resize2fs: Fix potential memory corruption in ext2fs_progress_init()

Check the return value of ext2fs_get_mem, since prog isn't initialized
so checking may miss a failed memory allocation.

Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebugfs: Fix ncheck to print all pathnames for the inodes
Theodore Ts'o [Wed, 1 Oct 2008 23:14:06 +0000 (19:14 -0400)]
debugfs: Fix ncheck to print all pathnames for the inodes

The ncheck command in debugfs had a bug where some inodes would not
have their pathnames printed if other inodes had more than one hard
link.  Fix this bug and simplify the code by printing all of the
pathnames for the requested inodes.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibcom_err: Use sem_post/sem_init to prevent race conditions
Theodore Ts'o [Fri, 12 Sep 2008 14:15:26 +0000 (10:15 -0400)]
libcom_err: Use sem_post/sem_init to prevent race conditions

SuSE has been carrying a patch for a long time to prevent a largely
theoretical race condition if a multi-threaded application adds and
removes error tables in multiple threads.  Unfortunately SuSE's
approach breaks compatibility by forcing applications to link and
compile with the -pthread option; using pthread mutexes has
historically been problematic.

This commit fixes things in a more portable way by using
sem_post/sem_wait instead, which is an older interface that doesn't
require the pthreads library.  Linux happens to implement
sem_post/sem_init using futexes, and -lrt ends up pulling in
-lpthread, but the advantage of using POSIX semaphores is that
applications don't have to be built using -pthread, unlike the use of
pthread mutexes.

The add_error_table() and remove_error_table() interfaces are the
preferred interfaces and locking protection have been added to only
these interfaces.  I have not added locking protection to the
generated initialize_xxx_error_table and initialize_xxx_error_table_r
interfaces, to avoid adding symbol dependencies that would cause a
library to fail to work when linking against older com_err libraries
that do not export et_list_lock() and et_list_unlock().  Threaded
applications shouldn't be using these interfaces in any case.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Use dietlibc when possible for building e2fsck.static
Theodore Ts'o [Fri, 12 Sep 2008 13:26:45 +0000 (09:26 -0400)]
debian: Use dietlibc when possible for building e2fsck.static

This fixes a regression introduced in commit 4f2e8f19 where we
inadvertently disabled the use of dietlibc on all architectures,
instead of just on those architectures which didn't support dietlibc.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix compiling under diet libc
Theodore Ts'o [Fri, 12 Sep 2008 13:10:39 +0000 (09:10 -0400)]
Fix compiling under diet libc

Some recent changes had caused diet libc support to bitrot.  Fix up
missing header files and other portability fixups needed for dietlibc.
(Many of these changes also improve general portability.)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebugfs: Add the ability to specify the hash seed to the "hash" command
Theodore Ts'o [Wed, 10 Sep 2008 15:30:46 +0000 (11:30 -0400)]
debugfs: Add the ability to specify the hash seed to the "hash" command

Also add the ability to specify the hash algorithm by name instead of
by number.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Fix e2fsck automatic blocksize detetion
Theodore Ts'o [Tue, 9 Sep 2008 19:02:24 +0000 (15:02 -0400)]
e2fsck: Fix e2fsck automatic blocksize detetion

This fixes a regression that was introduced in commit dcc91e10 (it
showed up first in e2fsprogs 1.40.7).  Since we weren't freeing the
filesystem handle, ext2fs_open2() was returning EBUSY, and so this
caused a failure in the code that would automatically determine the
filesystem block size when only the superblock number was specified by
the user.

This was discussed in http://ubuntuforums.org/showthread.php?t=789323,
and Matthias Bannach pointed this out to me, for which I am very
grateful.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update vi.po (from translationproject.org)
Clytie Siddall [Mon, 8 Sep 2008 02:55:25 +0000 (22:55 -0400)]
po: update vi.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update nl.po (from translationproject.org)
Benno Schulenberg [Mon, 8 Sep 2008 02:55:25 +0000 (22:55 -0400)]
po: update nl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update id.po (from translationproject.org)
Arif E. Nugroho [Mon, 8 Sep 2008 02:55:25 +0000 (22:55 -0400)]
po: update id.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update de.po (from translationproject.org)
Philipp Thomas [Mon, 8 Sep 2008 02:55:25 +0000 (22:55 -0400)]
po: update de.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update cs.po (from translationproject.org)
Petr Pisar [Mon, 8 Sep 2008 02:55:24 +0000 (22:55 -0400)]
po: update cs.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoUnbreak build if directory renamed from e2fsprogs.
Matthias Andree [Fri, 5 Sep 2008 08:25:28 +0000 (10:25 +0200)]
Unbreak build if directory renamed from e2fsprogs.

gen-tarball currently assumes that the top-level directory is called
e2fsprogs, which breaks building the tarball if it's named differently.
Since we have already computed the basename, let's use it.

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoPrint size of resulting .tar.gz file.
Matthias Andree [Fri, 5 Sep 2008 07:51:29 +0000 (09:51 +0200)]
Print size of resulting .tar.gz file.

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agolibext2fs.texinfo: Add documentation for the file I/O functions
Theodore Ts'o [Sun, 7 Sep 2008 22:11:46 +0000 (18:11 -0400)]
libext2fs.texinfo: Add documentation for the file I/O functions

Addresses-Debian-Bug: #484877

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix various spelling mistakes in various man pages
Theodore Ts'o [Sun, 7 Sep 2008 18:08:40 +0000 (14:08 -0400)]
Fix various spelling mistakes in various man pages

Thanks to A. Costa for pointing these out.

Addresses-Debian-Bug: #498100
Addresses-Debian-Bug: #498101
Addresses-Debian-Bug: #498102
Addresses-Debian-Bug: #498103

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoInstall with relative symlinks if $(root_libdir) == $(libdir)
Theodore Ts'o [Sun, 7 Sep 2008 07:17:22 +0000 (03:17 -0400)]
Install with relative symlinks if $(root_libdir) == $(libdir)

When installing the ELF link library, avoid using absolute pathnames
if $(root_libdir) and $(libdir) are the same.

Addresses-Sourceforge-Bug: #1782913

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoe2fsck: Don't print the PO header when printing problems with PROMPT_NULL
Theodore Ts'o [Sun, 7 Sep 2008 05:35:15 +0000 (01:35 -0400)]
e2fsck: Don't print the PO header when printing problems with PROMPT_NULL

A few e2fsck problem messages supply their own prompt, and set a
prompt value of PROMPT_NULL.  We have to check for this case, and not
pass the null string to _(), since that will result in the translation
header getting printed, like this:

Run journal anywayProject-Id-Version: e2fsprogs
Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>
POT-Creation-Date: 2008-02-28 21:45-0500
PO-Revision-Date: 2006-05-23 11:12+0000
Last-Translator: Somebody32 <som32@mail.ru>
Language-Team: Russian <ru@li.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 &&
n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;
X-Launchpad-Export-Date: 2008-05-28 00:43+0000
X-Generator: Launchpad (build Unknown)
<y>? yes

Addresses-Launchpad-Bug: #246892

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate debian/changefile for 1.41.1-3 debian release
Theodore Ts'o [Fri, 5 Sep 2008 13:24:32 +0000 (09:24 -0400)]
Update debian/changefile for 1.41.1-3 debian release

15 years agoAdd more historical information into the debian/*.symbols files
Theodore Ts'o [Fri, 5 Sep 2008 15:10:11 +0000 (11:10 -0400)]
Add more historical information into the debian/*.symbols files

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agobadblocks: Display time and percentage complete in verbose mode.
Manish Katiyar [Thu, 4 Sep 2008 09:14:38 +0000 (14:44 +0530)]
badblocks: Display time and percentage complete in verbose mode.

Addresses-Debian-Bug: #429739.

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebugfs: Fix memory leak in do_ncheck()'s error path
Manish Katiyar [Wed, 3 Sep 2008 05:53:53 +0000 (11:23 +0530)]
debugfs: Fix memory leak in do_ncheck()'s error path

Also the progname printed as "ncheck" instead of "do_ncheck" to be
consistent with the other error messages in debugfs.

Signed-off-by: "Manish Katiyar" <mkatiyar@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Reorder rules to build udebs to avoid Lintian warning
Theodore Ts'o [Fri, 5 Sep 2008 02:49:15 +0000 (22:49 -0400)]
debian: Reorder rules to build udebs to avoid Lintian warning

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Fix dependencies field in the udeb packages
Theodore Ts'o [Fri, 5 Sep 2008 02:39:47 +0000 (22:39 -0400)]
debian: Fix dependencies field in the udeb packages

Addresses-Debian-Bug: #497619

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix e2initrd_helper, blkid, and fsck from linking with unneeded libraries
Theodore Ts'o [Fri, 5 Sep 2008 02:36:52 +0000 (22:36 -0400)]
Fix e2initrd_helper, blkid, and fsck from linking with unneeded libraries

... especially when using ELF shared libraries.  We only need to link
with a library if the executable uses that library directly.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update pl.po (from translationproject.org)
Jakub Bogusz [Wed, 3 Sep 2008 03:47:16 +0000 (23:47 -0400)]
po: update pl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agopo: update fr.po (from translationproject.org)
Samuel Thibault [Wed, 3 Sep 2008 03:47:16 +0000 (23:47 -0400)]
po: update fr.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoImprove ELF shared library handling
Theodore Ts'o [Wed, 3 Sep 2008 03:12:38 +0000 (23:12 -0400)]
Improve ELF shared library handling

Pass in -rpath-link option to the linker so that blkid will build
correctly on systems that don't have libcom_err.so.2 installed.

Fix debugfs to only try to link with -ldl when building without shared
libraries; with ELF shared libraries, the library which requires -ldl
(libss.so) can required the library dependency itself.

Fix how we build tune2fs.static so that we use @LDFLAG_STATIC@, via
$(LDFLAGS_STATIC), instead of hard-coding the use of -static.

Addresses-Sourceforge-Bug: #2088537

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix bold font specifer in mke2fs.8 man page
Theodore Ts'o [Wed, 3 Sep 2008 01:23:35 +0000 (21:23 -0400)]
Fix bold font specifer in mke2fs.8 man page

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix pkg-config files: use Requires.private and fix the include directory
Theodore Ts'o [Wed, 3 Sep 2008 01:20:44 +0000 (21:20 -0400)]
Fix pkg-config files: use Requires.private and fix the include directory

Addresses-Sourceforge-Bug: #2089537

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate debian/changefile for 1.41.1-2 debian release
Theodore Ts'o [Tue, 2 Sep 2008 16:33:00 +0000 (12:33 -0400)]
Update debian/changefile for 1.41.1-2 debian release

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Compile ext2fs_swab64() for all platforms
Theodore Ts'o [Tue, 2 Sep 2008 12:49:10 +0000 (08:49 -0400)]
libext2fs: Compile ext2fs_swab64() for all platforms

Although nothing uses ext2fs_swab64() yet, debian's dpkg-gensymbols
picked up the fact that ext2fs_swab64() isn't getting defined on
non-x86 platforms.  Oops.  This patch moves the definition of
ext2fs_swab64() to a place where it will be compiled for all
architectures.

Addresses-Debian-Bug: #497515

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Remove unused ext2fs_find_{first,ext}_bit_set()
Theodore Ts'o [Tue, 2 Sep 2008 12:45:56 +0000 (08:45 -0400)]
libext2fs: Remove unused ext2fs_find_{first,ext}_bit_set()

These functions were commented out for x86, but they were still being
defined for other architectures.  We now remove them entirely.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agobadblocks: Open the device with O_LARGEFILE
Theodore Ts'o [Tue, 2 Sep 2008 12:29:20 +0000 (08:29 -0400)]
badblocks: Open the device with O_LARGEFILE

Linux doesn't enforce the Large File Support API requirements on block
devices, but in case someone wants to run badblocks on a normal file,
open the device file with O_LARGEFILE.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix e2fsprogs-libs build failure due to 'subs' target
Theodore Ts'o [Mon, 1 Sep 2008 21:59:01 +0000 (17:59 -0400)]
Fix e2fsprogs-libs build failure due to 'subs' target

In e2fsprogs-libs the lib/ext2fs directory is not present, and we need
to make sure the top-level Makefile doesn't blow up in it's not there.

Addresses-Sourceforge-Bug: #2087502

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate release notes, changelog, etc., for e2fsprogs 1.41.1 release v1.41.1
Theodore Ts'o [Mon, 1 Sep 2008 14:39:35 +0000 (10:39 -0400)]
Update release notes, changelog, etc., for e2fsprogs 1.41.1 release

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agofilefrag: Fix calculation of ideal number of extents
Theodore Ts'o [Mon, 1 Sep 2008 19:48:28 +0000 (15:48 -0400)]
filefrag: Fix calculation of ideal number of extents

Fix calculation of the ideal number of extents needed for a file to
take into account sparse files.

In addition, suppress the "this file is extent-based" message unless
verbose mode is enabled.

Addresses-Debian-Bug: #458306

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoEnable test_io debugging by default
Theodore Ts'o [Mon, 1 Sep 2008 15:27:27 +0000 (11:27 -0400)]
Enable test_io debugging by default

Test I/O debugging is incredibly useful for rooting out problems, so
let's enable by default, especially now that its overhead is only
incurred when it is needed.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix debug flag definitions for the resize2fs man page
Theodore Ts'o [Mon, 1 Sep 2008 15:19:35 +0000 (11:19 -0400)]
Fix debug flag definitions for the resize2fs man page

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoOnly use the test_io manager if the right environment variables are set
Theodore Ts'o [Mon, 1 Sep 2008 15:17:29 +0000 (11:17 -0400)]
Only use the test_io manager if the right environment variables are set

In order to make it possible for the test_io manager to be compiled in
by default, make all of the programs that might try to use it to only
do so if the environment variables TEST_IO_FLAGS and TEST_IO_DEBUG are
set.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibe2p: Fix potential core-dumping bug in iterate_on_dir()
Theodore Ts'o [Mon, 1 Sep 2008 13:38:32 +0000 (09:38 -0400)]
libe2p: Fix potential core-dumping bug in iterate_on_dir()

iterate_on_dir() can try to copy too much data from the directory
entry, resulting in a crash.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate e2fsprogs.pot translation template
Theodore Ts'o [Sat, 30 Aug 2008 03:36:08 +0000 (23:36 -0400)]
Update e2fsprogs.pot translation template

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate makefile dependency for lib/e2p/Makefile.in
Theodore Ts'o [Sat, 30 Aug 2008 03:26:26 +0000 (23:26 -0400)]
Update makefile dependency for lib/e2p/Makefile.in

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agomke2fs: Allow the default hash algorithm in mke2fs.conf
Theodore Ts'o [Sat, 30 Aug 2008 01:39:36 +0000 (21:39 -0400)]
mke2fs: Allow the default hash algorithm in mke2fs.conf

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agotune2fs: Add support for setting the default hash algorithm for htree
Theodore Ts'o [Sat, 30 Aug 2008 01:21:19 +0000 (21:21 -0400)]
tune2fs: Add support for setting the default hash algorithm for htree

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Fix postinstall scripts when the user/group is in LDAP
Theodore Ts'o [Fri, 29 Aug 2008 23:53:34 +0000 (19:53 -0400)]
debian: Fix postinstall scripts when the user/group is in LDAP

Addresses-Debian-Bug: #497010

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agopo: update de.po (from translationproject.org)
Philipp Thomas [Fri, 29 Aug 2008 12:49:57 +0000 (08:49 -0400)]
po: update de.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agotune2fs, mke2fs: Change default directory hash algorithm to half_md4
Theodore Ts'o [Fri, 29 Aug 2008 03:09:35 +0000 (23:09 -0400)]
tune2fs, mke2fs: Change default directory hash algorithm to half_md4

The half_md4 algorithm is faster and more collision resistant.  Let's
switch to it as the default.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoresize2fs: Allow (non-optimal) on-line resizing for flex_bg filesystems
Theodore Ts'o [Thu, 28 Aug 2008 17:24:12 +0000 (13:24 -0400)]
resize2fs: Allow (non-optimal) on-line resizing for flex_bg filesystems

The current method of adding one block group at a time to a mounted
filesystem means it is impossible to accomodate the flex_bg allocation
method of placing the metadata together in a single block group.  For
now we "fix" this issue by using the traditional layout for new block
groups, where each block group is self-contained and contains its own
bitmap blocks and inode tables.  This means we don't get the layout
advantages of flex_bg in the new block groups, but at least it allows
on-line resizing to function.

Long term, we will need to create a new ioctl which does much more of
the resizing work in the kernel.

We also fix a bug in the ext3/ext4 ioctl fallback code so we stop
trying the ext3 ioctl for every single block group when resizing an
ext4 filesystem.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFurther optimize journal placement for flex_bg filesystems
Theodore Ts'o [Thu, 28 Aug 2008 14:20:43 +0000 (10:20 -0400)]
Further optimize journal placement for flex_bg filesystems

If the number of block groups is greater than half the flex_bg size,
the journal we be placed in the flex_bg super-group which is closest
to the mid-point of the filesystem, and in the first free block group
beyond where the metadata for the flex_bg is stored.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Change symbols files to only use uptream versions numbers
Theodore Ts'o [Thu, 28 Aug 2008 13:43:18 +0000 (09:43 -0400)]
debian: Change symbols files to only use uptream versions numbers

As suggested by lintian

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix breakage caused by commit da17e370 (missing dependency in Makefile)
Theodore Ts'o [Thu, 28 Aug 2008 11:15:52 +0000 (07:15 -0400)]
Fix breakage caused by commit da17e370 (missing dependency in Makefile)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate e2fsprogs.pot translation template file
Theodore Ts'o [Thu, 28 Aug 2008 03:18:29 +0000 (23:18 -0400)]
Update e2fsprogs.pot translation template file

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoRemove trailing whitespace for the entire source tree
Theodore Ts'o [Thu, 28 Aug 2008 03:07:54 +0000 (23:07 -0400)]
Remove trailing whitespace for the entire source tree

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoImprove future compatibility for the 64-bit I/O channel functions
Theodore Ts'o [Thu, 28 Aug 2008 01:46:26 +0000 (21:46 -0400)]
Improve future compatibility for the 64-bit I/O channel functions

Provide a C language wrapper function for io_channel_read_blk64() and
io_channel_write_blk64() instead of using a C preprocessor macro, with
an fallback to the old 32-bit functions if an application-provided I/O
channel manager doesn't supply 64-bit method functions and the block
numbers can fit in 32-bit integer.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoUpdate @-expansion script for the I18N translation template
Theodore Ts'o [Wed, 27 Aug 2008 23:00:50 +0000 (19:00 -0400)]
Update @-expansion script for the I18N translation template

Update the @-expansion script to support the @x -> extent expansion

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoBuild lib/ext2fs/ext2_err.h early to avoid parallel build problems
Theodore Ts'o [Wed, 27 Aug 2008 22:44:50 +0000 (18:44 -0400)]
Build lib/ext2fs/ext2_err.h early to avoid parallel build problems

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebugfs: Use extents when writing a file if the filesystem supports them
Theodore Ts'o [Wed, 27 Aug 2008 22:38:47 +0000 (18:38 -0400)]
debugfs: Use extents when writing a file if the filesystem supports them

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Fix ext2fs_bmap() to work with extents and BMAP_ALLOC
Theodore Ts'o [Wed, 27 Aug 2008 22:37:11 +0000 (18:37 -0400)]
libext2fs: Fix ext2fs_bmap() to work with extents and BMAP_ALLOC

Fix bugs with extents support when allocating blocks.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2fs_block_iterate2: Fix memory leak on error paths
Theodore Ts'o [Wed, 27 Aug 2008 21:50:14 +0000 (17:50 -0400)]
ext2fs_block_iterate2: Fix memory leak on error paths

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoIf the filesystem supports extents create an extent-based journal inode
Theodore Ts'o [Wed, 27 Aug 2008 19:50:44 +0000 (15:50 -0400)]
If the filesystem supports extents create an extent-based journal inode

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2fs_block_iterate2: Add BLOCK_FLAG_APPEND support for extent-based files
Theodore Ts'o [Wed, 27 Aug 2008 19:17:36 +0000 (15:17 -0400)]
ext2fs_block_iterate2: Add BLOCK_FLAG_APPEND support for extent-based files

This is needed so that extent-based inodes (including a journal inode)
can be created via block_iterate.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoCreate the journal in the middle of the filesystem
Theodore Ts'o [Wed, 27 Aug 2008 19:11:28 +0000 (15:11 -0400)]
Create the journal in the middle of the filesystem

This speeds up access to the journal by eliminating worst-case seeks
from one end of the disk to another, which can be quite common in very
fsync-intensive workloads if the file is located near the end of the
disk, and the journal is located the beginning of the disk.

In addition, this can help eliminate journal fragmentation when
flex_bg is enabled, since the first block group has a large amount of
metadata.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoext2fs_mkjournal(): Don't allocate an extra block to the journal
Theodore Ts'o [Wed, 27 Aug 2008 20:23:30 +0000 (16:23 -0400)]
ext2fs_mkjournal(): Don't allocate an extra block to the journal

Addresses-Sourceforge-Bug: 1483791

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Give a priority bonus to "leaf" devicemapper devices
Theodore Ts'o [Wed, 27 Aug 2008 06:24:51 +0000 (02:24 -0400)]
libblkid: Give a priority bonus to "leaf" devicemapper devices

Give a boost to dm devices which are not used to build other dm
devices, since "leaf" devices are generally more likely to be
interesting as devices to mount.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Unexport the private symbol blkid_devdirs
Theodore Ts'o [Wed, 27 Aug 2008 04:00:44 +0000 (00:00 -0400)]
libblkid: Unexport the private symbol blkid_devdirs

blkid_devdirs was defined in blkidP.h and was never intended to be
used outside of the library.  Since it no longer needs to be shared
across object files, rename it and turn it into a static variable.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoRemove use of devmapper library by the blkid library
Theodore Ts'o [Wed, 27 Aug 2008 03:56:00 +0000 (23:56 -0400)]
Remove use of devmapper library by the blkid library

The devmapper library is no longer needed given commit f4e89bcd.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Optimize devicemapper support
Theodore Ts'o [Tue, 26 Aug 2008 12:13:56 +0000 (08:13 -0400)]
libblkid: Optimize devicemapper support

This commit works by removing all calls from libdevmapper altogether,
and using the standard support for "normal" non-dm devices.

It depends on dm devices being placed in /dev/mapper (but the previous
code had this dependency anyway), and /proc/partitions containing dm
devices.

We don't actually rip out the libdevmapper code in this commit, but
just disable it via #undef HAVE_DEVMAPPER, just so it's easier to
review and understand the fundamental code changes.  A subsequent
commit will remove the libdevmapper code, as well as unexport
the blkid_devdirs string array.

Thanks to Karel Zak for inspiring me to look at the dm code in blkid,
so I could realize how much it deserved to ripped out by its roots.  :-)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoAdd support for with empty directory blocks in 64k blocksize filesystems
Theodore Ts'o [Tue, 26 Aug 2008 01:08:19 +0000 (21:08 -0400)]
Add support for with empty directory blocks in 64k blocksize filesystems

The rec_len field in the directory entry is 16 bits, so if the
filesystem is completely empty, rec_len of 0 is used to designate
65536, for the case where the directory entry takes the entire 64k
block.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agodebian: Add dpkg-gensymbols support to track ABI changes to the libraries
Theodore Ts'o [Mon, 25 Aug 2008 04:00:35 +0000 (00:00 -0400)]
debian: Add dpkg-gensymbols support to track ABI changes to the libraries

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibblkid: Fix namespace leakage of unicode_16be_to_utf8
Theodore Ts'o [Mon, 25 Aug 2008 03:34:13 +0000 (23:34 -0400)]
libblkid: Fix namespace leakage of unicode_16be_to_utf8

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibe2p: Fix namespace leakage of os_tab
Theodore Ts'o [Mon, 25 Aug 2008 02:46:31 +0000 (22:46 -0400)]
libe2p: Fix namespace leakage of os_tab

Make os_tab static, since there's no reason it should be exposed.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: Fix namespace leakage of crc16 functions
Theodore Ts'o [Mon, 25 Aug 2008 02:44:33 +0000 (22:44 -0400)]
libext2fs: Fix namespace leakage of crc16 functions

Rename crc16 to ext2fs_crc16, and make crc16_table static, since
there's not reason it should be exposed at all.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoRemove trailing space from the description of the r_move_itable test
Theodore Ts'o [Mon, 25 Aug 2008 01:58:03 +0000 (21:58 -0400)]
Remove trailing space from the description of the r_move_itable test

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agofix e2fsck error message for bad htree depth
Andreas Dilger [Sun, 24 Aug 2008 03:45:11 +0000 (21:45 -0600)]
fix e2fsck error message for bad htree depth

Fix error message to print the depth of a corrupt htree directory.

Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: Kalpak Shah <kalpak.shah@sun.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoadd debugfs command to print known features
Andreas Dilger [Sun, 24 Aug 2008 03:42:46 +0000 (21:42 -0600)]
add debugfs command to print known features

Print out the currently supported features of e2fsprogs/libext2fs
via a new "debugfs supported_features" command.  This helps scripts
to know whether it is possible to try and enable specific features
in the filesystem.

Signed-off-by: Kalpak Shah <kalpak.shah@sun.com>
Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoallow integrating the "make rpm" command into a build system
Andreas Dilger [Mon, 25 Aug 2008 01:03:17 +0000 (21:03 -0400)]
allow integrating the "make rpm" command into a build system

Allow "make rpm" to take some extra configure options from the build
environment without having to patch the code.

Build the tarball in a temporary directory instead of the e2fsprogs
source directory.

Signed-off-by: Michael MacDonald <Michael.Macdonald@Sun.COM>
Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agolibext2fs: grow dblist more aggressively
Andreas Dilger [Sun, 24 Aug 2008 03:17:17 +0000 (21:17 -0600)]
libext2fs: grow dblist more aggressively

Make the dblist grow more quickly when many directory blocks are added,
otherwise the array has to get copied too often, which is slow when it
is large.

Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
15 years agoe2fsck: Change comments in problem array to match what is printed
Andreas Dilger [Mon, 25 Aug 2008 00:38:22 +0000 (20:38 -0400)]
e2fsck: Change comments in problem array to match what is printed

This makes it easier to locate the problem code in question.

Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
15 years agoFix miscellaneous compile warnings
Andreas Dilger [Mon, 25 Aug 2008 00:37:39 +0000 (20:37 -0400)]
Fix miscellaneous compile warnings

Signed-off-by: Andreas Dilger <adilger@sun.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>