Whamcloud - gitweb
LU-6142 lnet: discard unused lnet_print_hdr() 58/39358/2
authorMr NeilBrown <neilb@suse.de>
Tue, 14 Jul 2020 04:12:54 +0000 (14:12 +1000)
committerOleg Drokin <green@whamcloud.com>
Fri, 7 Aug 2020 04:58:46 +0000 (04:58 +0000)
lnet_print_hdr() is unused, and has not been used in git history since
at least 2004.
So remove it.

Test-Parameters: trivial
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Change-Id: I0d72726b69f205a8c62ae4dbf1423f6e745db5fe
Reviewed-on: https://review.whamcloud.com/39358
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Chris Horn <chris.horn@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/include/lnet/lib-lnet.h
lnet/lnet/lib-move.c

index a89a802..dbe8ba5 100644 (file)
@@ -630,7 +630,6 @@ int lnet_msg_containers_create(void);
 
 char *lnet_health_error2str(enum lnet_msg_hstatus hstatus);
 char *lnet_msgtyp2str(int type);
-void lnet_print_hdr(struct lnet_hdr *hdr);
 int lnet_fail_nid(lnet_nid_t nid, unsigned int threshold);
 
 /** \addtogroup lnet_fault_simulation @{ */
index cb472df..bd947fc 100644 (file)
@@ -4213,68 +4213,6 @@ lnet_msgtyp2str (int type)
        }
 }
 
-void
-lnet_print_hdr(struct lnet_hdr *hdr)
-{
-       struct lnet_process_id src = {
-               .nid = hdr->src_nid,
-               .pid = hdr->src_pid,
-       };
-       struct lnet_process_id dst = {
-               .nid = hdr->dest_nid,
-               .pid = hdr->dest_pid,
-       };
-       char *type_str = lnet_msgtyp2str(hdr->type);
-
-       CWARN("P3 Header at %p of type %s\n", hdr, type_str);
-       CWARN("    From %s\n", libcfs_id2str(src));
-       CWARN("    To   %s\n", libcfs_id2str(dst));
-
-       switch (hdr->type) {
-       default:
-               break;
-
-       case LNET_MSG_PUT:
-               CWARN("    Ptl index %d, ack md %#llx.%#llx, "
-                     "match bits %llu\n",
-                     hdr->msg.put.ptl_index,
-                     hdr->msg.put.ack_wmd.wh_interface_cookie,
-                     hdr->msg.put.ack_wmd.wh_object_cookie,
-                     hdr->msg.put.match_bits);
-               CWARN("    Length %d, offset %d, hdr data %#llx\n",
-                     hdr->payload_length, hdr->msg.put.offset,
-                     hdr->msg.put.hdr_data);
-               break;
-
-       case LNET_MSG_GET:
-               CWARN("    Ptl index %d, return md %#llx.%#llx, "
-                     "match bits %llu\n", hdr->msg.get.ptl_index,
-                     hdr->msg.get.return_wmd.wh_interface_cookie,
-                     hdr->msg.get.return_wmd.wh_object_cookie,
-                     hdr->msg.get.match_bits);
-               CWARN("    Length %d, src offset %d\n",
-                     hdr->msg.get.sink_length,
-                     hdr->msg.get.src_offset);
-               break;
-
-       case LNET_MSG_ACK:
-               CWARN("    dst md %#llx.%#llx, "
-                     "manipulated length %d\n",
-                     hdr->msg.ack.dst_wmd.wh_interface_cookie,
-                     hdr->msg.ack.dst_wmd.wh_object_cookie,
-                     hdr->msg.ack.mlength);
-               break;
-
-       case LNET_MSG_REPLY:
-               CWARN("    dst md %#llx.%#llx, "
-                     "length %d\n",
-                     hdr->msg.reply.dst_wmd.wh_interface_cookie,
-                     hdr->msg.reply.dst_wmd.wh_object_cookie,
-                     hdr->payload_length);
-       }
-
-}
-
 int
 lnet_parse(struct lnet_ni *ni, struct lnet_hdr *hdr, lnet_nid_t from_nid,
           void *private, int rdma_req)