LU-15011 tests: pool spill test modifications

Make the following modifications to the ost-pools
test suite:
test 29 - change check for 'when striping is specified
          explicitly' file from 'file-2' to 'file-3'

test 30 - Add bad parameter check for setting the threshold
          below zero

test 31 - 'do_nodes $mdts $LCTL get_param lod.*.pool.*'
          doesn’t print anything. Change to
          'do_nodes $mdts $LCTL get_param lod.*.pool.*.spill*'

Fixes: 0a998f4723 (“LU-14825 lod: pool spilling”)
Test-Parameters: trivial testlist=ost-pools
Signed-off-by: James Nunez <jnunez@whamcloud.com>
Change-Id: Icbdc3d42b7f7609bc57cc37830975d831125d659
Reviewed-on: https://review.whamcloud.com/45056
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Alex Zhuravlev <bzzz@whamcloud.com>
Reviewed-by: Jian Yu <yujian@whamcloud.com>

diff --git a/lustre/tests/ost-pools.sh b/lustre/tests/ost-pools.sh
index d99578b..a10ca50 100755 (executable)
--- a/lustre/tests/ost-pools.sh
+++ b/lustre/tests/ost-pools.sh
@@ -1658,7 +1658,7 @@ test_29() {
        $LFS setstripe -p $pool1 $DIR/$tdir/$tfile-3 || error "can't setstripe"
        touch $DIR/$tdir/$tfile-3
        [[ $($LFS getstripe -p $DIR/$tdir/$tfile-3) == "$pool2" ]] || {
-               $LFS getstripe $DIR/$tdir/$tfile-2
+               $LFS getstripe $DIR/$tdir/$tfile-3
                error "old pool on $tfile-3"
        }
 
@@ -1715,6 +1715,8 @@ test_30() {
                error "poolback"
        do_facet mds1 $LCTL set_param $prefix.spill_threshold_pct="101" &&
                error ">100%"
+       do_facet mds1 $LCTL set_param $prefix.spill_threshold_pct="-1" &&
+               error "<0%"
 
        # set persistent spilling
        do_facet mgs $LCTL set_param -P $prefix.spill_target="$pool2"
@@ -1787,7 +1789,7 @@ test_31() {
        do_nodes $mdts $LCTL set_param lod.*.pool.$pool3.spill_target="$pool4"
        do_nodes $mdts $LCTL set_param lod.*.pool.$pool3.spill_threshold_pct="$threshold"
 
-       do_nodes $mdts $LCTL get_param lod.*.pool.*
+       do_nodes $mdts $LCTL get_param lod.*.pool.*.spill*
 
        $LFS setstripe -p $pool1 $DIR/$tdir || error "can't set default layout"
        local tmpfile=$DIR/$tdir/$tfile-2