Whamcloud - gitweb
LU-12895 mdt: check if object exists first 29/36629/5
authorSebastien Buisson <sbuisson@ddn.com>
Thu, 31 Oct 2019 11:33:45 +0000 (20:33 +0900)
committerOleg Drokin <green@whamcloud.com>
Fri, 6 Dec 2019 01:12:33 +0000 (01:12 +0000)
Make sure object exists before trying to get its attr.

Test-Parameters: clientselinux mdtcount=4 envdefinitions=ONLY=185a testlist=sanity,sanity,sanity,sanity
Test-Parameters: clientselinux mdtcount=4 testlist=sanity,recovery-small,sanity-sec
Signed-off-by: Sebastien Buisson <sbuisson@ddn.com>
Change-Id: Idb2cd5d6e3fdf7998040b933be54a001a0e5391b
Reviewed-on: https://review.whamcloud.com/36629
Reviewed-by: Alex Zhuravlev <bzzz@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
lustre/mdt/mdt_handler.c
lustre/tests/sanity.sh

index ac39725..84e21d6 100644 (file)
@@ -1927,9 +1927,9 @@ static int mdt_getattr_name_lock(struct mdt_thread_info *info,
                         PLDLMRES(lock->l_resource),
                         PFID(mdt_object_fid(child)));
 
-               if (S_ISREG(lu_object_attr(&child->mot_obj)) &&
-                   mdt_object_exists(child) && !mdt_object_remote(child) &&
-                   child != parent) {
+               if (mdt_object_exists(child) &&
+                   S_ISREG(lu_object_attr(&child->mot_obj)) &&
+                   !mdt_object_remote(child) && child != parent) {
                        mdt_object_put(info->mti_env, child);
                        rc = mdt_pack_size2body(info, child_fid,
                                                &lhc->mlh_reg_lh);
index df92c36..6b08430 100644 (file)
@@ -51,8 +51,8 @@ fi
 
 selinux_status=$(getenforce)
 if [ "$selinux_status" != "Disabled" ]; then
-       # bug number:    LU-12895 LU-12469 LU-12469
-       ALWAYS_EXCEPT+=" 185a     230b     230d"
+       # bug number:    LU-12469 LU-12469
+       ALWAYS_EXCEPT+=" 230b     230d"
 fi
 
 # skip the grant tests for ARM until they are fixed