RETURN(-ENODEV);
}
- if (arg != NULL) {
- if (strlen(arg) + 1 > sizeof(policy->pol_arg)) {
- CERROR("NRS: arg '%s' is too long\n", arg);
- GOTO(out, rc = -E2BIG);
- }
- strncpy(policy->pol_arg, arg, sizeof(policy->pol_arg));
- }
-
/**
* Serialize policy starting across the NRS head
*/
}
}
+ if (arg != NULL) {
+ if (strlcpy(policy->pol_arg, arg, sizeof(policy->pol_arg)) >=
+ sizeof(policy->pol_arg)) {
+ CERROR("NRS: arg '%s' is too long\n", arg);
+ GOTO(out, rc = -E2BIG);
+ }
+ }
+
policy->pol_state = NRS_POL_STATE_STARTED;
if (policy->pol_flags & PTLRPC_NRS_FL_FALLBACK) {
}
run_test 77g "Change TBF type directly"
+test_77h() {
+ [ $(lustre_version_code ost1) -ge $(version_code 2.8.55) ] ||
+ { skip "Need OST version at least 2.8.55"; return 0; }
+
+ local old_policy=$(do_facet ost1 \
+ lctl get_param ost.OSS.ost_io.nrs_policies)
+ local new_policy
+
+ do_facet ost1 lctl set_param \
+ ost.OSS.ost_io.nrs_policies="abc"
+ [ $? -eq 0 ] && error "should return error"
+
+ do_facet ost1 lctl set_param \
+ ost.OSS.ost_io.nrs_policies="tbf\ abc"
+ [ $? -eq 0 ] && error "should return error"
+
+ do_facet ost1 lctl set_param \
+ ost.OSS.ost_io.nrs_policies="tbf\ reg"
+ [ $? -eq 0 ] && error "should return error"
+
+ do_facet ost1 lctl set_param \
+ ost.OSS.ost_io.nrs_policies="tbf\ reg\ abc"
+ [ $? -eq 0 ] && error "should return error"
+
+ do_facet ost1 lctl set_param \
+ ost.OSS.ost_io.nrs_policies="tbf\ abc\ efg"
+ [ $? -eq 0 ] && error "should return error"
+
+ new_policy=$(do_facet ost1 lctl get_param ost.OSS.ost_io.nrs_policies)
+ [ $? -eq 0 ] || error "shouldn't LBUG"
+
+ [ "$old_policy" = "$new_policy" ] || error "NRS policy should be same"
+
+ return 0
+}
+run_test 77h "Wrong policy name should report error, not LBUG"
+
test_78() { #LU-6673
local rc