Whamcloud - gitweb
LU-7734 lnet: Fix crash in router_proc.c
authorAmir Shehata <amir.shehata@intel.com>
Thu, 14 Jul 2016 23:51:32 +0000 (16:51 -0700)
committerAmir Shehata <amir.shehata@intel.com>
Wed, 25 Jan 2017 03:10:17 +0000 (19:10 -0800)
Fixed NULL access in the case when a peer is a remote
peer. In that case lpni_net is NULL.

Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Change-Id: Ida234ff016b2bdc305acf74df0f99600d2555e27
Reviewed-on: http://review.whamcloud.com/21327

lnet/lnet/router_proc.c

index 7636202..209adab 100644 (file)
@@ -501,7 +501,8 @@ proc_lnet_peers(struct ctl_table *table, int write, void __user *buffer,
                        int nrefs = atomic_read(&peer->lpni_refcount);
                        int lastalive = -1;
                        char *aliveness = "NA";
                        int nrefs = atomic_read(&peer->lpni_refcount);
                        int lastalive = -1;
                        char *aliveness = "NA";
-                       int maxcr = peer->lpni_net->net_tunables.lct_peer_tx_credits;
+                       int maxcr = (peer->lpni_net) ?
+                         peer->lpni_net->net_tunables.lct_peer_tx_credits : 0;
                        int txcr = peer->lpni_txcredits;
                        int mintxcr = peer->lpni_mintxcredits;
                        int rtrcr = peer->lpni_rtrcredits;
                        int txcr = peer->lpni_txcredits;
                        int mintxcr = peer->lpni_mintxcredits;
                        int rtrcr = peer->lpni_rtrcredits;