Whamcloud - gitweb
LU-15069 llite: Rename 'skip' label 53/45653/10
authorPatrick Farrell <pfarrell@whamcloud.com>
Wed, 14 Feb 2024 17:40:40 +0000 (12:40 -0500)
committerOleg Drokin <green@whamcloud.com>
Mon, 4 Mar 2024 20:01:09 +0000 (20:01 +0000)
There's a goto label in ras_update named just "skip".
Skip what?  This is extra confusing because the concept of
"skip index" is used in neighboring code, and this is
unrelated.

Give it a more descriptive name.

Test-Parameters: trivial
Signed-off-by: Patrick Farrell <pfarrell@whamcloud.com>
Change-Id: I1e6ec7a75b6d9a296bfdea4c70a333497d804564
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/45653
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lustre/llite/rw.c

index 55ddd8b..e311f40 100644 (file)
@@ -1345,7 +1345,7 @@ static void ras_update(struct ll_sb_info *sbi, struct inode *inode,
                        ras->ras_window_pages = sbi->ll_ra_info.ra_range_pages;
                        ll_ra_stats_inc_sbi(sbi, RA_STAT_MMAP_RANGE_READ);
                }
-               goto skip;
+               goto skip_miss_checking;
        }
 
        if (flags & LL_RAS_MMAP) {
@@ -1374,7 +1374,7 @@ static void ras_update(struct ll_sb_info *sbi, struct inode *inode,
                        } else {
                                ras->ras_window_pages = 0;
                        }
-                       goto skip;
+                       goto skip_miss_checking;
                }
        }
 
@@ -1417,7 +1417,7 @@ static void ras_update(struct ll_sb_info *sbi, struct inode *inode,
                }
        }
 
-skip:
+skip_miss_checking:
        ras->ras_window_start_idx = ras_align(ras, index);
 
        if (stride_io_mode(ras)) {