Whamcloud - gitweb
LU-10560 llite: remove extra headers from rw26.c 51/31151/3
authorMike Marciniszyn <mike.marciniszyn@intel.com>
Fri, 2 Feb 2018 16:45:54 +0000 (08:45 -0800)
committerOleg Drokin <oleg.drokin@intel.com>
Fri, 9 Feb 2018 05:58:45 +0000 (05:58 +0000)
Remove headers from llite_mmap.c that are no longer (or were possibly
never) needed.  This avoids a compile problem with 4.14 kernels:

CC [M]  lustre/llite/rw26.o
In file included from lustre/llite/rw26.c:43:0:
./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
./arch/x86/include/asm/uaccess.h:31:9:
error: dereferencing pointer to incomplete type
current->thread.addr_limit = fs;

It turns out <asm/uaccess.h> was included twice but we don't need
anything from that header.  Same for <linux/stat.h> and a number of
other extraneous headers.

Sort headers alphabetically so it is easier to avoid duplicates.

Change-Id: I4cbe2c1c7289466396b2bb2eac3c475d1041a283
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-on: https://review.whamcloud.com/31151
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
lustre/llite/rw26.c

index be3d895..8f94c83 100644 (file)
  * Lustre Lite I/O page cache routines for the 2.5/2.6 kernel version
  */
 
  * Lustre Lite I/O page cache routines for the 2.5/2.6 kernel version
  */
 
+#include <linux/buffer_head.h>
+#include <linux/errno.h>
+#include <linux/fs.h>
 #include <linux/kernel.h>
 #include <linux/mm.h>
 #include <linux/kernel.h>
 #include <linux/mm.h>
+#include <linux/mpage.h>
+#include <linux/pagemap.h>
 #include <linux/string.h>
 #include <linux/string.h>
-#include <linux/stat.h>
-#include <linux/errno.h>
 #include <linux/unistd.h>
 #include <linux/unistd.h>
-#include <asm/uaccess.h>
+#include <linux/writeback.h>
 
 #ifdef HAVE_MIGRATE_H
 #include <linux/migrate.h>
 #elif defined(HAVE_MIGRATE_MODE_H)
 #include <linux/migrate_mode.h>
 #endif
 
 #ifdef HAVE_MIGRATE_H
 #include <linux/migrate.h>
 #elif defined(HAVE_MIGRATE_MODE_H)
 #include <linux/migrate_mode.h>
 #endif
-#include <linux/fs.h>
-#include <linux/buffer_head.h>
-#include <linux/mpage.h>
-#include <linux/writeback.h>
-#include <linux/stat.h>
-#include <asm/uaccess.h>
-#include <linux/mm.h>
-#include <linux/pagemap.h>
 
 #define DEBUG_SUBSYSTEM S_LLITE
 
 
 #define DEBUG_SUBSYSTEM S_LLITE