Whamcloud - gitweb
LU-1148 build: Handle download kernel-devel failure
authorBrian J. Murrell <brian@whamcloud.com>
Wed, 29 Feb 2012 14:46:58 +0000 (09:46 -0500)
committerOleg Drokin <green@whamcloud.com>
Thu, 29 Mar 2012 03:24:54 +0000 (23:24 -0400)
When the kernel-devel fails to get downloaded with yumdownloader,
emit a meaningful error message rather than just mysteriously exiting.
While it would be nice to actually be able to do something about this
failure programatically, typically it's something that requires
human intervention somewhere.  Or at least more time than we'd rather
have a build blocked for while it's rectified.

Signed-off-by: Brian J. Murrell <brian@whamcloud.com>
Change-Id: I070968f73eb0e78152705e78eedefdc3b6ac8e4f
Reviewed-on: http://review.whamcloud.com/2226
Reviewed-by: Minh Diep <mdiep@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
build/lbuild-rhel

index 0aa22ce..efb5c81 100644 (file)
@@ -195,7 +195,9 @@ find_linux_rpm-rhel() {
     if [ "$(lsb_release -s -i)" = "RedHatEnterpriseServer" ]; then
         sudo="sudo"
     fi
-    $sudo yumdownloader --destdir "$tmpdir" kernel-devel-"$wanted_kernel" > /dev/null
+    if ! $sudo yumdownloader --destdir "$tmpdir" kernel-devel-"$wanted_kernel" > /dev/null; then
+        fatal 1 "failed to fetch kernel-devel-$wanted_kernel with yumdownloader."
+    fi
     local rpm=$(cd $tmpdir; echo *)
     mv "$tmpdir/$rpm" "$pathtorpms"
     rmdir $tmpdir