Whamcloud - gitweb
LU-2779 osc: osc_extent_wait() shouldn't be interruptible
authorJinshan Xiong <jinshan.xiong@intel.com>
Wed, 13 Feb 2013 19:40:19 +0000 (11:40 -0800)
committerOleg Drokin <oleg.drokin@intel.com>
Wed, 30 Oct 2013 21:56:48 +0000 (17:56 -0400)
Otherwise it will hit the assertion at cl_lock.c:

   cl_lock.c:1967:discard_cb())
ASSERTION( (!(page->cp_type == CPT_CACHEABLE) ||
(!PageWriteback(cl_page_vmpage(env, page)))) ) failed:

This is because in osc_lock_flush() we have to make sure the IO
is finished before discarding the pages.

Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Change-Id: I296ab35d26b861f3c57ddba9f74564aa439aaa0b
Reviewed-on: http://review.whamcloud.com/5419
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/osc/osc_cache.c

index 7711496..702920e 100644 (file)
@@ -896,7 +896,7 @@ static int osc_extent_wait(const struct lu_env *env, struct osc_extent *ext,
                        "%s: wait ext to %d timedout, recovery in progress?\n",
                        osc_export(obj)->exp_obd->obd_name, state);
 
-               lwi = LWI_INTR(LWI_ON_SIGNAL_NOOP, NULL);
+               lwi = LWI_INTR(NULL, NULL);
                rc = l_wait_event(ext->oe_waitq, extent_wait_cb(ext, state),
                                  &lwi);
        }