Whamcloud - gitweb
LU-17000 coverity: Fix Logically dead code under liblnetconfig.c 50/52950/2
authorArshad Hussain <arshad.hussain@aeoncomputing.com>
Wed, 1 Nov 2023 07:53:54 +0000 (13:23 +0530)
committerOleg Drokin <green@whamcloud.com>
Wed, 8 Nov 2023 22:07:28 +0000 (22:07 +0000)
This patch fixes Logically dead code check reported
by coverity run.

CoverityID: 404752 ("Logically dead code")

Test-Parameters: trivial testlist=sanity-lnet
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: I5a435324a19e04805c2a7c555ac2a0c1433ce2d0
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52950
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/utils/lnetconfig/liblnetconfig.c

index 24215be..c759f7b 100644 (file)
@@ -1740,11 +1740,6 @@ int lustre_lnet_parse_nid_range(struct nid_node *head, char *nidstr,
        while ((nid = strsep(&nidstr, "@")) != NULL) {
                char *tmp = NULL, *tmp2 = NULL, *end = NULL;
 
-               if (!nid) {
-                       *errmsg = "Unable to parse nidlist: no proper NID string";
-                       return -ENOENT;
-               }
-
                tmp = strchr(nid, '[');
                tmp2 = strchr(nid, ']');