Whamcloud - gitweb
LU-10834 tests: fix cleanup_77c() defect 18/31918/2
authorElena Gryaznova <c17455@cray.com>
Mon, 9 Apr 2018 18:39:05 +0000 (21:39 +0300)
committerOleg Drokin <oleg.drokin@intel.com>
Sat, 14 Apr 2018 12:15:29 +0000 (12:15 +0000)
Check the length of string is non-zero properly.
Without this fix cleanup_77c() calls:
 "rm -f *" in case of empty $osc_file_prefix, and
 "do_facet ost1 rm -f *" in case of empty $ost_file_prefix

Signed-off-by: Elena Gryaznova <c17455@cray.com>
Cray-bug-id: LUS-5817
Test-Parameters: trivial testlist=sanity envdefinitions="ONLY=77c"
Reviewed-by: Vladimir Saveliev <c17830@cray.com>
Reviewed-by: Andrew Perepechko <c17827@cray.com>
Change-Id: Id3f3ec52c965b15900f7a649120b89267daa9810
Reviewed-on: https://review.whamcloud.com/31918
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/tests/sanity.sh

index 50e7abd..c537772 100755 (executable)
@@ -7003,8 +7003,8 @@ cleanup_77c() {
        $LCTL set_param osc.*osc-[^mM]*.checksum_dump=0
        $check_ost &&
                do_facet ost1 $LCTL set_param obdfilter.*-OST*.checksum_dump=0
-       [ -n $osc_file_prefix ] && rm -f ${osc_file_prefix}*
-       $check_ost && [ -n $ost_file_prefix ] &&
+       [ -n "$osc_file_prefix" ] && rm -f ${osc_file_prefix}*
+       $check_ost && [ -n "$ost_file_prefix" ] &&
                do_facet ost1 rm -f ${ost_file_prefix}\*
 }