Whamcloud - gitweb
LU-10391 socklnd: properly order headers in socklnd.h 87/38287/2
authorJames Simmons <jsimmons@infradead.org>
Mon, 20 Apr 2020 17:36:27 +0000 (13:36 -0400)
committerOleg Drokin <green@whamcloud.com>
Fri, 1 May 2020 04:26:33 +0000 (04:26 +0000)
We need the proper definitions in inetdevice.h for socklnd.h.
This breaks on newer platforms like Ubuntu18 with

error: implicit declaration of function ‘endfor_ifa’ [-Werror=implicit-function-declaration]

Reversing the order of the headers resolves this build issue.

Fixes: d720fbaada ("LU-10391 socklnd: use interface index to track local addr")
Change-Id: Id8fd27ca118c592b501b3d9241f87b05db3aba70
Signed-off-by: James Simmons <jsimmons@infradead.org>
Reviewed-on: https://review.whamcloud.com/38287
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: Neil Brown <neilb@suse.de>
Reviewed-by: Serguei Smirnov <ssmirnov@whamcloud.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

index 5a907fc..6003560 100644 (file)
@@ -37,8 +37,8 @@
  * Author: Eric Barton <eric@bartonsoftware.com>
-#include "socklnd.h"
 #include <linux/inetdevice.h>
+#include "socklnd.h"
 static const struct lnet_lnd the_ksocklnd;
 struct ksock_nal_data ksocknal_data;