Fix eric's extremely well-spotted locking bug. It's not clear that we even

need this lock, but I'll fix it by adding an unlock_kernel until I can ask zach.

diff --git a/lustre/ldlm/ldlm_test.c b/lustre/ldlm/ldlm_test.c
index 5bd79eb..041f66e 100644 (file)
--- a/lustre/ldlm/ldlm_test.c
+++ b/lustre/ldlm/ldlm_test.c
@@ -436,6 +436,7 @@ static int ldlm_test_main(void *data)
         spin_unlock_irq(&current->sigmask_lock);
 
         sprintf(current->comm, "ldlm_test");
+        spin_unlock();
 
         /* Record that the thread is running */
         thread->t_flags |= SVC_RUNNING;

diff --git a/lustre/llite/commit_callback.c b/lustre/llite/commit_callback.c
index 1f2c288..4a33904 100644 (file)
--- a/lustre/llite/commit_callback.c
+++ b/lustre/llite/commit_callback.c
@@ -63,6 +63,7 @@ static int ll_commitcbd_main(void *arg)
         spin_unlock_irq(&current->sigmask_lock);
 
         sprintf(current->comm, "lustre_commitcbd");
+        spin_unlock();
 
         /* Record that the  thread is running */
         sbi->ll_commitcbd_waketime = CURRENT_TIME;

diff --git a/lustre/ptlrpc/recovd.c b/lustre/ptlrpc/recovd.c
index ecbef41..37bcccf 100644 (file)
--- a/lustre/ptlrpc/recovd.c
+++ b/lustre/ptlrpc/recovd.c
@@ -165,6 +165,7 @@ static int recovd_main(void *arg)
         spin_unlock_irq(&current->sigmask_lock);
 
         sprintf(current->comm, "lustre_recovd");
+        spin_unlock();
 
         /* Record that the  thread is running */
         recovd->recovd_thread = current;

diff --git a/lustre/ptlrpc/service.c b/lustre/ptlrpc/service.c
index 4b71a4d..285fdee 100644 (file)
--- a/lustre/ptlrpc/service.c
+++ b/lustre/ptlrpc/service.c
@@ -248,6 +248,7 @@ static int ptlrpc_main(void *arg)
         spin_unlock_irq(&current->sigmask_lock);
 
         sprintf(current->comm, data->name);
+        spin_unlock();
 
         /* Record that the thread is running */
         thread->t_flags = SVC_RUNNING;