Whamcloud - gitweb
LU-10756 ptlrpc: fix IMP_CLOSED state is being never set 05/37405/4
authorMikhail Pershin <mpershin@whamcloud.com>
Mon, 3 Feb 2020 09:03:59 +0000 (12:03 +0300)
committerOleg Drokin <green@whamcloud.com>
Thu, 20 Feb 2020 07:15:02 +0000 (07:15 +0000)
Commit cf78502e48d checks the new state for IMP_CLOSED value
instead of import current state so instead of keeping import
closed it prevents import state from being set to IMP_CLOSE

Patch restores original check to keep import closed by
checking its current state

Fixes: cf78502e48d ("LU-10756 ptlrpc: change IMPORT_SET_* macros into real functions")
Signed-off-by: Mikhail Pershin <mpershin@whamcloud.com>
Change-Id: I7df2798f09ce7023381c03957adf530da4149c2d
Reviewed-on: https://review.whamcloud.com/37405
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

index b1e32cb..4ae967d 100644 (file)
@@ -76,7 +76,7 @@ static void import_set_state_nolock(struct obd_import *imp,
        /* A CLOSED import should remain so. */
-       if (state == LUSTRE_IMP_CLOSED)
+       if (imp->imp_state == LUSTRE_IMP_CLOSED)
        if (imp->imp_state != LUSTRE_IMP_NEW) {