Whamcloud - gitweb
LU-4738 lmv: access lum_stripe_offset as little endian 71/9671/2
authorJohn L. Hammond <john.hammond@intel.com>
Fri, 14 Mar 2014 16:01:32 +0000 (11:01 -0500)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 25 Mar 2014 23:52:21 +0000 (23:52 +0000)
By the time that a struct lmv_user_md reaches lmv_placement_policy()
it has already been converted to little endian. Therefore use the
appropriate macros around accesses to this this field. This issue was
found by rewriting the definition of struct lmv_user_md to use the
__leXX typedefs and running sparse.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: If641375eabd22cc3e935a2e8f1327c48081c6ed1
Reviewed-on: http://review.whamcloud.com/9671
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Swapnil Pimpale <spimpale@ddn.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/lmv/lmv_obd.c

index b6397d4..8f26e6c 100644 (file)
@@ -1358,13 +1358,13 @@ static int lmv_placement_policy(struct obd_device *obd,
 
                lum = op_data->op_data;
 
 
                lum = op_data->op_data;
 
-               if (lum->lum_stripe_offset != (__u32)-1) {
-                       *mds = lum->lum_stripe_offset;
+               if (le32_to_cpu(lum->lum_stripe_offset) != (__u32)-1) {
+                       *mds = le32_to_cpu(lum->lum_stripe_offset);
                } else {
                        /* -1 means default, which will be in the same MDT with
                         * the stripe */
                        *mds = op_data->op_mds;
                } else {
                        /* -1 means default, which will be in the same MDT with
                         * the stripe */
                        *mds = op_data->op_mds;
-                       lum->lum_stripe_offset = op_data->op_mds;
+                       lum->lum_stripe_offset = cpu_to_le32(op_data->op_mds);
                }
        } else {
                /* Allocate new fid on target according to operation type and
                }
        } else {
                /* Allocate new fid on target according to operation type and