Whamcloud - gitweb
LU-8403 obd: remove OBD_NOTIFY_CREATE 20/21420/5
authorJohn L. Hammond <john.hammond@intel.com>
Tue, 19 Jul 2016 14:16:15 +0000 (09:16 -0500)
committerOleg Drokin <oleg.drokin@intel.com>
Sat, 17 Dec 2016 05:40:59 +0000 (05:40 +0000)
None of the obd_notify() handlers listen for the OBD_NOTIFY_CREATE
event, so remove it and its sole use in lov_add_target().

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I976b2215ba4b8fecf170a4efd3d7ec642183daaf
Reviewed-on: https://review.whamcloud.com/21420
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Ben Evans <bevans@cray.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
lustre/include/obd.h
lustre/lov/lov_obd.c

index b4ee379..e5315ac 100644 (file)
@@ -526,8 +526,6 @@ static inline int is_lwp_on_ost(char *name)
  * Events signalled through obd_notify() upcall-chain.
  */
 enum obd_notify_event {
-        /* target added */
-        OBD_NOTIFY_CREATE,
         /* Device connect start */
         OBD_NOTIFY_CONNECT,
         /* Device activated */
index 5a52072..3744334 100644 (file)
@@ -617,8 +617,6 @@ static int lov_add_target(struct obd_device *obd, struct obd_uuid *uuidp,
         CDEBUG(D_CONFIG, "idx=%d ltd_gen=%d ld_tgt_count=%d\n",
                 index, tgt->ltd_gen, lov->desc.ld_tgt_count);
 
-        rc = obd_notify(obd, tgt_obd, OBD_NOTIFY_CREATE, &index);
-
         if (lov->lov_connects == 0) {
                 /* lov_connect hasn't been called yet. We'll do the
                    lov_connect_obd on this target when that fn first runs,