Whamcloud - gitweb
LU-10003 lnet: to properly handle errors reported use ssize_t 68/49068/2
authorJames Simmons <jsimmons@infradead.org>
Tue, 8 Nov 2022 14:24:45 +0000 (09:24 -0500)
committerOleg Drokin <green@whamcloud.com>
Thu, 10 Nov 2022 00:36:49 +0000 (00:36 +0000)
The function nla_strscpy() can return a negative error value.
Replace using size_t with ssize_t to handle potential error
states.

Test-Parameters: trivial
Fixes: 8f8f6e2f3 ("LU-10003 lnet: use Netlink to support old and new NI APIs.")
Change-Id: I079f93e3e1005a1062a3fe0807cf8b877712d818
Signed-off-by: James Simmons <jsimmons@infradead.org>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/49068
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Frank Sehr <fsehr@whamcloud.com>
Reviewed-by: Neil Brown <neilb@suse.de>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/lnet/api-ni.c

index 970bfed..637a9f6 100644 (file)
@@ -5181,7 +5181,7 @@ static int lnet_net_cmd(struct sk_buff *skb, struct genl_info *info)
                nla_for_each_nested(entry, attr, rem2) {
                        switch (nla_type(entry)) {
                        case LN_SCALAR_ATTR_VALUE: {
-                               size_t len;
+                               ssize_t len;
 
                                memset(&conf, 0, sizeof(conf));
                                if (nla_strcmp(entry, "ip2net") == 0) {