mdt_set_capainfo(info, 0, &info->mti_body->mbo_fid1,
req_capsule_client_get(info->mti_pill, &RMF_CAPA1));
+ /* Detect out-of range masks */
+ if ((hss->hss_setmask | hss->hss_clearmask) & ~HSM_FLAGS_MASK) {
+ CDEBUG(D_HSM, "Incompatible masks provided (set "LPX64
+ ", clear "LPX64") vs supported set (%#x).\n",
+ hss->hss_setmask, hss->hss_clearmask, HSM_FLAGS_MASK);
+ GOTO(out_unlock, rc = -EINVAL);
+ }
+
/* Non-root users are forbidden to set or clear flags which are
* NOT defined in HSM_USER_MASK. */
if (((hss->hss_setmask | hss->hss_clearmask) & ~HSM_USER_MASK) &&
- !md_capable(mdt_ucred(info), CFS_CAP_SYS_ADMIN))
+ !md_capable(mdt_ucred(info), CFS_CAP_SYS_ADMIN)) {
+ CDEBUG(D_HSM, "Incompatible masks provided (set "LPX64
+ ", clear "LPX64") vs unprivileged set (%#x).\n",
+ hss->hss_setmask, hss->hss_clearmask, HSM_USER_MASK);
GOTO(out_unlock, rc = -EPERM);
+ }
/* Read current HSM info */
ma->ma_valid = 0;
PFID(&info->mti_body->mbo_fid1));
GOTO(out_unlock, rc);
}
+
+ /* Detect out-of range archive id */
+ if (hss->hss_archive_id > LL_HSM_MAX_ARCHIVE) {
+ CDEBUG(D_HSM, "archive id %u exceeds maximum %zu.\n",
+ hss->hss_archive_id, LL_HSM_MAX_ARCHIVE);
+ GOTO(out_unlock, rc = -EINVAL);
+ }
+
ma->ma_hsm.mh_arch_id = hss->hss_archive_id;
}
hus.hus_archive_id, i);
}
- /* Bugs following. This should not succeed. Builds the following file:
- *
- * $ ../utils/lfs hsm_state /mnt/lustre/hsm_check_test
- *
- * /mnt/lustre/hsm_check_test: (0x8008007d) released exists
- * archived never_release never_archive lost_from_hsm,
- * archive_id:-1789
- */
-
/* Invalid archive numbers */
rc = llapi_hsm_state_set_fd(fd, HS_EXISTS, 0, 33);
- ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd: %s", strerror(-rc));
rc = llapi_hsm_state_set_fd(fd, HS_EXISTS, 0, 151);
- ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd: %s", strerror(-rc));
rc = llapi_hsm_state_set_fd(fd, HS_EXISTS, 0, -1789);
- ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd: %s", strerror(-rc));
- /* Setable + Unsettable flags */
+ /* Settable flags, with respect of the HSM file state transition rules:
+ * DIRTY without EXISTS: no dirty if no archive was created
+ * DIRTY and RELEASED: a dirty file could not be released
+ * RELEASED without ARCHIVED: do not release a non-archived file
+ * LOST without ARCHIVED: cannot lost a non-archived file.
+ */
rc = llapi_hsm_state_set_fd(fd, HS_DIRTY, 0, 0);
ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_EXISTS, 0);
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd failed: %s",
+ strerror(-rc));
+
rc = llapi_hsm_state_set_fd(fd, 0, HS_DIRTY, 0);
ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_EXISTS, 0);
+ ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, HS_DIRTY, 0, 0);
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd failed: %s",
+ strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, HS_RELEASED, 0, 0);
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd failed: %s",
+ strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, HS_LOST, 0, 0);
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd failed: %s",
+ strerror(-rc));
+
rc = llapi_hsm_state_set_fd(fd, HS_ARCHIVED, 0, 0);
ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
rc = llapi_hsm_state_set_fd(fd, HS_RELEASED, 0, 0);
ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ rc = llapi_hsm_state_set_fd(fd, HS_LOST, 0, 0);
+ ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, HS_DIRTY|HS_EXISTS, 0, 0);
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd failed: %s",
+ strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_RELEASED, 0);
+ ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, HS_DIRTY|HS_EXISTS, 0, 0);
+ ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_ARCHIVED, 0);
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd failed: %s",
+ strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_LOST, 0);
+ ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_ARCHIVED, 0);
+ ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+
rc = llapi_hsm_state_set_fd(fd, HS_NORELEASE, 0, 0);
ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_NORELEASE, 0);
+ ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+
rc = llapi_hsm_state_set_fd(fd, HS_NOARCHIVE, 0, 0);
ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
- rc = llapi_hsm_state_set_fd(fd, HS_LOST, 0, 0);
+ rc = llapi_hsm_state_set_fd(fd, 0, HS_NOARCHIVE, 0);
ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
/* Bogus flags for good measure. */
rc = llapi_hsm_state_set_fd(fd, 0x00080000, 0, 0);
- ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd: %s", strerror(-rc));
rc = llapi_hsm_state_set_fd(fd, 0x80000000, 0, 0);
- ASSERTF(rc == 0, "llapi_hsm_state_set_fd failed: %s", strerror(-rc));
+ ASSERTF(rc == -EINVAL, "llapi_hsm_state_set_fd: %s", strerror(-rc));
close(fd);
}