This fixes sparse warnings such as:
.../o2iblnd.c:424:1: warning: symbol 'kiblnd_get_peer_info' was not declared.
Should it be static?
This reduces the code size by 400 bytes.
The body of "the_o2iblnd" was moved at the end of the file, to avoid
having to declare some static prototypes.
Change-Id: I160a2cda3db1a581e0a961e0368d8ee6fd2781fd
Signed-off-by: frank zago <fzago@cray.com>
Reviewed-on: http://review.whamcloud.com/11255
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Patrick Farrell <paf@cray.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
-lnd_t the_o2iblnd = {
- .lnd_type = O2IBLND,
- .lnd_startup = kiblnd_startup,
- .lnd_shutdown = kiblnd_shutdown,
- .lnd_ctl = kiblnd_ctl,
- .lnd_query = kiblnd_query,
- .lnd_send = kiblnd_send,
- .lnd_recv = kiblnd_recv,
-};
+static lnd_t the_o2iblnd;
kiblnd_cksum (void *ptr, int nob)
{
char *c = ptr;
kiblnd_cksum (void *ptr, int nob)
{
char *c = ptr;
kiblnd_peer_decref(peer);
}
kiblnd_peer_decref(peer);
}
-int
-kiblnd_get_peer_info (lnet_ni_t *ni, int index,
- lnet_nid_t *nidp, int *count)
+static int
+kiblnd_get_peer_info(lnet_ni_t *ni, int index,
+ lnet_nid_t *nidp, int *count)
{
kib_peer_t *peer;
struct list_head *ptmp;
{
kib_peer_t *peer;
struct list_head *ptmp;
kiblnd_del_peer_locked (kib_peer_t *peer)
{
struct list_head *ctmp;
kiblnd_del_peer_locked (kib_peer_t *peer)
{
struct list_head *ctmp;
kiblnd_del_peer (lnet_ni_t *ni, lnet_nid_t nid)
{
struct list_head zombies = LIST_HEAD_INIT(zombies);
kiblnd_del_peer (lnet_ni_t *ni, lnet_nid_t nid)
{
struct list_head zombies = LIST_HEAD_INIT(zombies);
kiblnd_get_conn_by_idx(lnet_ni_t *ni, int index)
{
kib_peer_t *peer;
kiblnd_get_conn_by_idx(lnet_ni_t *ni, int index)
{
kib_peer_t *peer;
kiblnd_debug_rx (kib_rx_t *rx)
{
CDEBUG(D_CONSOLE, " %p status %d msg_type %x cred %d\n",
kiblnd_debug_rx (kib_rx_t *rx)
{
CDEBUG(D_CONSOLE, " %p status %d msg_type %x cred %d\n",
rx->rx_msg->ibm_credits);
}
rx->rx_msg->ibm_credits);
}
kiblnd_debug_tx (kib_tx_t *tx)
{
CDEBUG(D_CONSOLE, " %p snd %d q %d w %d rc %d dl %lx "
kiblnd_debug_tx (kib_tx_t *tx)
{
CDEBUG(D_CONSOLE, " %p snd %d q %d w %d rc %d dl %lx "
kiblnd_close_matching_conns(lnet_ni_t *ni, lnet_nid_t nid)
{
kib_peer_t *peer;
kiblnd_close_matching_conns(lnet_ni_t *ni, lnet_nid_t nid)
{
kib_peer_t *peer;
return (count == 0) ? -ENOENT : 0;
}
return (count == 0) ? -ENOENT : 0;
}
kiblnd_ctl(lnet_ni_t *ni, unsigned int cmd, void *arg)
{
struct libcfs_ioctl_data *data = arg;
kiblnd_ctl(lnet_ni_t *ni, unsigned int cmd, void *arg)
{
struct libcfs_ioctl_data *data = arg;
kiblnd_query(lnet_ni_t *ni, lnet_nid_t nid, cfs_time_t *when)
{
cfs_time_t last_alive = 0;
kiblnd_query(lnet_ni_t *ni, lnet_nid_t nid, cfs_time_t *when)
{
cfs_time_t last_alive = 0;
kiblnd_free_pages(kib_pages_t *p)
{
int npages = p->ibp_npages;
kiblnd_free_pages(kib_pages_t *p)
{
int npages = p->ibp_npages;
kiblnd_destroy_fmr_pool(kib_fmr_pool_t *pool)
{
LASSERT (pool->fpo_map_count == 0);
kiblnd_destroy_fmr_pool(kib_fmr_pool_t *pool)
{
LASSERT (pool->fpo_map_count == 0);
LIBCFS_FREE(pool, sizeof(kib_fmr_pool_t));
}
LIBCFS_FREE(pool, sizeof(kib_fmr_pool_t));
}
kiblnd_destroy_fmr_pool_list(struct list_head *head)
{
kib_fmr_pool_t *pool;
kiblnd_destroy_fmr_pool_list(struct list_head *head)
{
kib_fmr_pool_t *pool;
return max(IBLND_FMR_POOL_FLUSH, size);
}
return max(IBLND_FMR_POOL_FLUSH, size);
}
kiblnd_create_fmr_pool(kib_fmr_poolset_t *fps, kib_fmr_pool_t **pp_fpo)
{
/* FMR pool for RDMA */
kiblnd_create_fmr_pool(kib_fmr_poolset_t *fps, kib_fmr_pool_t **pp_fpo)
{
/* FMR pool for RDMA */
kiblnd_destroy_pool_list(struct list_head *head)
{
kib_pool_t *pool;
kiblnd_destroy_pool_list(struct list_head *head)
{
kib_pool_t *pool;
tx->tx_cookie = tps->tps_next_tx_cookie++;
}
tx->tx_cookie = tps->tps_next_tx_cookie++;
}
kiblnd_net_fini_pools(kib_net_t *net)
{
int i;
kiblnd_net_fini_pools(kib_net_t *net)
{
int i;
kiblnd_net_init_pools(kib_net_t *net, __u32 *cpts, int ncpts)
{
unsigned long flags;
kiblnd_net_init_pools(kib_net_t *net, __u32 *cpts, int ncpts)
{
unsigned long flags;
kiblnd_hdev_cleanup_mrs(kib_hca_dev_t *hdev)
{
int i;
kiblnd_hdev_cleanup_mrs(kib_hca_dev_t *hdev)
{
int i;
LIBCFS_FREE(hdev, sizeof(*hdev));
}
LIBCFS_FREE(hdev, sizeof(*hdev));
}
kiblnd_hdev_setup_mrs(kib_hca_dev_t *hdev)
{
struct ib_mr *mr;
kiblnd_hdev_setup_mrs(kib_hca_dev_t *hdev)
{
struct ib_mr *mr;
LIBCFS_FREE(dev, sizeof(*dev));
}
LIBCFS_FREE(dev, sizeof(*dev));
}
kiblnd_create_dev(char *ifname)
{
struct net_device *netdev;
kiblnd_create_dev(char *ifname)
{
struct net_device *netdev;
kiblnd_base_shutdown(void)
{
struct kib_sched_info *sched;
kiblnd_base_shutdown(void)
{
struct kib_sched_info *sched;
module_put(THIS_MODULE);
}
module_put(THIS_MODULE);
}
kiblnd_shutdown (lnet_ni_t *ni)
{
kib_net_t *net = ni->ni_data;
kiblnd_shutdown (lnet_ni_t *ni)
{
kib_net_t *net = ni->ni_data;
kiblnd_base_startup(void)
{
struct kib_sched_info *sched;
kiblnd_base_startup(void)
{
struct kib_sched_info *sched;
kiblnd_start_schedulers(struct kib_sched_info *sched)
{
int rc = 0;
kiblnd_start_schedulers(struct kib_sched_info *sched)
{
int rc = 0;
kiblnd_dev_start_threads(kib_dev_t *dev, int newdev, __u32 *cpts, int ncpts)
{
int cpt;
kiblnd_dev_start_threads(kib_dev_t *dev, int newdev, __u32 *cpts, int ncpts)
{
int cpt;
kiblnd_dev_search(char *ifname)
{
kib_dev_t *alias = NULL;
kiblnd_dev_search(char *ifname)
{
kib_dev_t *alias = NULL;
kiblnd_startup (lnet_ni_t *ni)
{
char *ifname;
kiblnd_startup (lnet_ni_t *ni)
{
char *ifname;
+static lnd_t the_o2iblnd = {
+ .lnd_type = O2IBLND,
+ .lnd_startup = kiblnd_startup,
+ .lnd_shutdown = kiblnd_shutdown,
+ .lnd_ctl = kiblnd_ctl,
+ .lnd_query = kiblnd_query,
+ .lnd_send = kiblnd_send,
+ .lnd_recv = kiblnd_recv,
+};
+
+static void __exit
kiblnd_module_fini (void)
{
lnet_unregister_lnd(&the_o2iblnd);
kiblnd_tunables_fini();
}
kiblnd_module_fini (void)
{
lnet_unregister_lnd(&the_o2iblnd);
kiblnd_tunables_fini();
}
kiblnd_module_init (void)
{
int rc;
kiblnd_module_init (void)
{
int rc;
kib_rdma_desc_t *rd, __u64 *iova, kib_phys_mr_t **pp_pmr);
void kiblnd_pmr_pool_unmap(kib_phys_mr_t *pmr);
kib_rdma_desc_t *rd, __u64 *iova, kib_phys_mr_t **pp_pmr);
void kiblnd_pmr_pool_unmap(kib_phys_mr_t *pmr);
-int kiblnd_startup (lnet_ni_t *ni);
-void kiblnd_shutdown (lnet_ni_t *ni);
-int kiblnd_ctl (lnet_ni_t *ni, unsigned int cmd, void *arg);
-void kiblnd_query (struct lnet_ni *ni, lnet_nid_t nid, cfs_time_t *when);
-
int kiblnd_tunables_init(void);
void kiblnd_tunables_fini(void);
int kiblnd_tunables_init(void);
void kiblnd_tunables_fini(void);
int kiblnd_failover_thread (void *arg);
int kiblnd_alloc_pages(kib_pages_t **pp, int cpt, int npages);
int kiblnd_failover_thread (void *arg);
int kiblnd_alloc_pages(kib_pages_t **pp, int cpt, int npages);
-void kiblnd_free_pages (kib_pages_t *p);
int kiblnd_cm_callback(struct rdma_cm_id *cmid,
struct rdma_cm_event *event);
int kiblnd_cm_callback(struct rdma_cm_id *cmid,
struct rdma_cm_event *event);