if (attr == NULL)
RETURN(-ENOMEM);
- memset(attr, 0, sizeof(attr));
+ memset(attr, 0, sizeof(*attr));
attr->la_valid = LA_MODE;
attr->la_mode = S_IFREG | 0666;
dof.dof_type = DFT_INDEX;
obd->obd_force = 1;
OBD_ALLOC_PTR(ioc_data);
- if (ioc_data) {
- obd_iocontrol(IOC_OSC_SET_ACTIVE, sbi->ll_md_exp,
- sizeof ioc_data, ioc_data, NULL);
+ if (ioc_data) {
+ obd_iocontrol(IOC_OSC_SET_ACTIVE, sbi->ll_md_exp,
+ sizeof *ioc_data, ioc_data, NULL);
- obd_iocontrol(IOC_OSC_SET_ACTIVE, sbi->ll_dt_exp,
- sizeof ioc_data, ioc_data, NULL);
+ obd_iocontrol(IOC_OSC_SET_ACTIVE, sbi->ll_dt_exp,
+ sizeof *ioc_data, ioc_data, NULL);
- OBD_FREE_PTR(ioc_data);
- }
+ OBD_FREE_PTR(ioc_data);
+ }
/* Really, we'd like to wait until there are no requests outstanding,
meap->mea_count = cpu_to_le32(lsmp->mea_count);
meap->mea_master = cpu_to_le32(lsmp->mea_master);
- for (i = 0; i < lmv->desc.ld_tgt_count; i++) {
- meap->mea_ids[i] = meap->mea_ids[i];
- fid_cpu_to_le(&meap->mea_ids[i], &meap->mea_ids[i]);
- }
+ for (i = 0; i < lmv->desc.ld_tgt_count; i++) {
+ meap->mea_ids[i] = lsmp->mea_ids[i];
+ fid_cpu_to_le(&meap->mea_ids[i], &lsmp->mea_ids[i]);
+ }
RETURN(mea_size);
}
}
LASSERT(obd->obd_lu_dev);
- LASSERT(obd->obd_lu_dev->ld_site = lod->lod_dt_dev.dd_lu_dev.ld_site);
+ LASSERT(obd->obd_lu_dev->ld_site == lod->lod_dt_dev.dd_lu_dev.ld_site);
ldev = obd->obd_lu_dev;
d = lu2dt_dev(ldev);
if (rc)
RETURN(rc);
} else {
- memset(attr, 0, sizeof(attr));
+ memset(attr, 0, sizeof(*attr));
attr->la_valid = LA_TYPE | LA_MODE;
attr->la_mode = S_IFREG;
}
struct lfsck_bookmark *mb = &lfsck->ml_bookmark_ram;
int rc;
- memset(mb, 0, sizeof(mb));
+ memset(mb, 0, sizeof(*mb));
mb->lb_magic = LFSCK_BOOKMARK_MAGIC;
mb->lb_version = LFSCK_VERSION_V2;
mutex_lock(&lfsck->ml_mutex);
for (i = 0; i < class_devno_max(); i++) {
struct obd_device *obd = class_num2obd(i);
- if (obd && obd->obd_name &&
- (strcmp(name, obd->obd_name) == 0)) {
+ if (obd && (strcmp(name, obd->obd_name) == 0)) {
CERROR("Device %s already exists at %d, won't add\n",
name, i);
if (result) {
for (i = 0; i < class_devno_max(); i++) {
struct obd_device *obd = class_num2obd(i);
- if (obd && obd->obd_name && strcmp(name, obd->obd_name) == 0) {
+ if (obd && strcmp(name, obd->obd_name) == 0) {
/* Make sure we finished attaching before we give
out any references */
LASSERT(obd->obd_magic == OBD_DEVICE_MAGIC);
struct obd_device *dev = data;
LASSERT(dev != NULL);
- LASSERT(dev->obd_name != NULL);
*eof = 1;
return snprintf(page, count, "%s\n", dev->obd_name);
}
int total = 0;
int i;
- LASSERT(svc->srv_parts != NULL);
ptlrpc_service_for_each_part(svcpt, i, svc)
total += svcpt->scp_nthrs_running;
int rc = 0;
int i;
- LASSERT(svc->srv_parts != NULL);
-
if (AT_OFF) {
rc += snprintf(page + rc, count - rc,
"adaptive timeouts off, using obd_timeout %u\n",
struct ptlrpc_service_part *svcpt;
int i;
- if (svc == NULL || svc->srv_parts == NULL)
+ if (svc == NULL)
return 0;
ptlrpc_service_for_each_part(svcpt, i, svc) {
}
fprintf(stderr, "accessing (1)\n");
- if (access(fname, F_OK) == 0) {
- fprintf(stderr, "%s still exists\n", fname2);
- exit(1);
- }
+ if (access(fname, F_OK) == 0) {
+ fprintf(stderr, "%s still exists\n", fname);
+ exit(1);
+ }
fprintf(stderr, "seeking (1)\n");
rc = lseek(fd, 0, SEEK_SET);