Whamcloud - gitweb
LU-12503 vvp_dev: increment *pos in .next 65/35765/2
authorNeilBrown <neilb@suse.com>
Sun, 11 Aug 2019 15:43:40 +0000 (11:43 -0400)
committerOleg Drokin <green@whamcloud.com>
Wed, 21 Aug 2019 04:48:31 +0000 (04:48 +0000)
As described in

Commit ec2e9995e4c5 ("lustre: llite: change how "dump_page_cache" walks a hash table")

The .next function should increment *pos. For some reason it
didn't, and this can trigger the warning in that function.

Change-Id: If4ac748f455750d82712299b7915eb541a3ddc7e
Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-on: https://review.whamcloud.com/35765
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/llite/vvp_dev.c

index 3802bc7..d36aed3 100644 (file)
@@ -558,7 +558,7 @@ static void *vvp_pgcache_next(struct seq_file *f, void *v, loff_t *pos)
        struct vvp_seq_private *priv = f->private;
 
        WARN_ON(*pos != priv->vvp_prev_pos);
-
+       *pos += 1;
        priv->vvp_prev_pos = *pos;
        return vvp_pgcache_next_page(priv);
 }