Whamcloud - gitweb
LU-4937 osc: get rid of old checksum initial value 54/10354/2
authorBobi Jam <bobijam.xu@intel.com>
Tue, 13 May 2014 11:59:08 +0000 (19:59 +0800)
committerOleg Drokin <oleg.drokin@intel.com>
Mon, 26 May 2014 23:27:37 +0000 (23:27 +0000)
Old code residue assumes initial checksum value as ~0, and relies on
that to check whether OST server has calculated bulk data checksum.
That is not the case anymore.

Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
Change-Id: I99779eaf02d22b470978448ad3f17b35f0e9a475
Reviewed-on: http://review.whamcloud.com/10354
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Jenkins
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
lustre/osc/osc_request.c

index 6575d79..3416fe3 100644 (file)
@@ -1585,12 +1585,7 @@ static int osc_brw_fini_request(struct ptlrpc_request *req, int rc)
                         router = libcfs_nid2str(req->rq_bulk->bd_sender);
                 }
 
-               if (server_cksum == ~0 && rc > 0) {
-                       CERROR("Protocol error: server %s set the 'checksum' "
-                              "bit, but didn't send a checksum.  Not fatal, "
-                              "but please notify on http://bugs.whamcloud.com/\n",
-                              libcfs_nid2str(peer->nid));
-               } else if (server_cksum != client_cksum) {
+               if (server_cksum != client_cksum) {
                        LCONSOLE_ERROR_MSG(0x133, "%s: BAD READ CHECKSUM: from "
                                           "%s%s%s inode "DFID" object "DOSTID
                                           " extent ["LPU64"-"LPU64"]\n",