Whamcloud - gitweb
tools/e2fsprogs.git
4 years agolibext2fs: properly free the bitmaps in read_bitmap()'s error/cleanup path
Theodore Ts'o [Fri, 8 Nov 2019 14:49:51 +0000 (09:49 -0500)]
libext2fs: properly free the bitmaps in read_bitmap()'s error/cleanup path

Use ext2fs_free_{block,inode}_bitmaps() instead of ext2fs_free_mem()
to avoid some memory leaks if there is an error while calling
read_bitmaps().

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
4 years agoFix UBSan when shifting (1LL << 63)
Theodore Ts'o [Tue, 5 Nov 2019 02:22:54 +0000 (21:22 -0500)]
Fix UBSan when shifting (1LL << 63)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
4 years agolibext2fs: fix UBSan when updating an inline_data file
Theodore Ts'o [Mon, 4 Nov 2019 23:43:49 +0000 (18:43 -0500)]
libext2fs: fix UBSan when updating an inline_data file

What memcpy does when the length is zero is not well-defined.  So
avoid it.

Bug: https://github.com/tytso/e2fsprogs/issues/25
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
4 years agolibext2fs: fix bug when reading or writing more than 2GB in unix_io
Theodore Ts'o [Mon, 4 Nov 2019 21:43:41 +0000 (16:43 -0500)]
libext2fs: fix bug when reading or writing more than 2GB in unix_io

If count * block_size exceeds 2GB, we will overflow a 32-bit signed
integer value.  This shouldn't happen in practice except for
fuzz-corrupted file systems, but let's fix the code so it's correct.

Bug: https://github.com/tytso/e2fsprogs/issues/24
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoAOSP: Link to production releases, not testing releases
Eric Biggers [Tue, 24 Sep 2019 21:59:10 +0000 (14:59 -0700)]
AOSP: Link to production releases, not testing releases

The testing links are not stable and are not guaranteed to exist.

Test: After re-generating the generated files, the link works now.
Change-Id: I36e73ef74571b3246f470280a75ae1098245eff5
From AOSP commit: 5971f6a5113b12b33d9454229bf27621853e1da7

5 years agoAOSP: Add new source files to Android.bp files
Eric Biggers [Tue, 24 Sep 2019 21:59:10 +0000 (14:59 -0700)]
AOSP: Add new source files to Android.bp files

Test: see I3781b6d1e55923e9410644e8a7ba834b4d13b733
Change-Id: Ie071b30937dcf73f34df5dc3aa08d23ae30d9c63
From AOSP commit: d2a16e1616b807a6143b9c6232a1c54f90dc06f6

5 years agoDefine the codepoint for the fast_commit compat feature
Theodore Ts'o [Fri, 4 Oct 2019 01:14:31 +0000 (21:14 -0400)]
Define the codepoint for the fast_commit compat feature

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoUpdate release notes, etc., for the 1.45.4 release v1.45.4
Theodore Ts'o [Mon, 23 Sep 2019 20:04:59 +0000 (16:04 -0400)]
Update release notes, etc., for the 1.45.4 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agotune2fs.8: tweak the documentation for the encrypt feature
Eric Biggers [Fri, 20 Sep 2019 21:29:54 +0000 (14:29 -0700)]
tune2fs.8: tweak the documentation for the encrypt feature

Try to make it clearer that enabling 'encrypt' just enables *support*
for encryption; it doesn't actually encrypt anything by itself.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agotune2fs.8: document the verity feature
Eric Biggers [Fri, 20 Sep 2019 21:29:53 +0000 (14:29 -0700)]
tune2fs.8: document the verity feature

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoext4.5: tweak the documentation for the encrypt feature
Eric Biggers [Fri, 20 Sep 2019 21:29:52 +0000 (14:29 -0700)]
ext4.5: tweak the documentation for the encrypt feature

Try to make it clearer that enabling 'encrypt' just enables *support*
for encryption; it doesn't actually encrypt anything by itself.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoext4.5: document the verity feature
Eric Biggers [Fri, 20 Sep 2019 21:29:51 +0000 (14:29 -0700)]
ext4.5: document the verity feature

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoext4.5: document first kernel version to support casefold feature
Eric Biggers [Fri, 20 Sep 2019 21:29:50 +0000 (14:29 -0700)]
ext4.5: document first kernel version to support casefold feature

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoext4.5: move casefold feature to correct position
Eric Biggers [Fri, 20 Sep 2019 21:29:49 +0000 (14:29 -0700)]
ext4.5: move casefold feature to correct position

The features are listed in alphabetic order, so put the casefold feature
in the right place.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub_all: make sure fd 3 is closed before running lvm commands
Theodore Ts'o [Mon, 23 Sep 2019 17:17:13 +0000 (13:17 -0400)]
e2scrub_all: make sure fd 3 is closed before running lvm commands

Some versions of cron leave fd 3 open for some unknown reason.  So
when e2scrub_all is run by cron (on non-systemd systems) this results
in an annoying message from the Cron Daemon because lvm will print
warning messages about "leaked file descriptors.  So force close fd 3
at the beginning of e2scrub and e2scrub_all.

Addresses-Debian-Bug: #940240
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update vi.po (from translationproject.org)
Trần Ngọc Quân [Mon, 23 Sep 2019 17:10:37 +0000 (13:10 -0400)]
po: update vi.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update nl.po (from translationproject.org)
Benno Schulenberg [Mon, 23 Sep 2019 17:10:36 +0000 (13:10 -0400)]
po: update nl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update ms.po (from translationproject.org)
Sharuzzaman Ahmat Raslan [Mon, 23 Sep 2019 17:10:36 +0000 (13:10 -0400)]
po: update ms.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update es.po (from translationproject.org)
Antonio Ceballos [Mon, 23 Sep 2019 17:10:36 +0000 (13:10 -0400)]
po: update es.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update de.po (from translationproject.org)
Mario Blättermann [Mon, 23 Sep 2019 17:10:36 +0000 (13:10 -0400)]
po: update de.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agolibsupport: add checks to prevent buffer overrun bugs in quota code
Theodore Ts'o [Sun, 1 Sep 2019 04:59:16 +0000 (00:59 -0400)]
libsupport: add checks to prevent buffer overrun bugs in quota code

A maliciously corrupted file systems can trigger buffer overruns in
the quota code used by e2fsck.  To fix this, add sanity checks to the
quota header fields as well as to block number references in the quota
tree.

Addresses: CVE-2019-5094
Addresses: TALOS-2019-0887
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: check the validity of the casefold flag
Theodore Ts'o [Tue, 3 Sep 2019 00:49:09 +0000 (20:49 -0400)]
e2fsck: check the validity of the casefold flag

The casefold flag is only allowed on directories and when the casefold
feature is enabled.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: make the low dtime check consistent when using the backup superblock
Theodore Ts'o [Mon, 2 Sep 2019 21:44:14 +0000 (17:44 -0400)]
e2fsck: make the low dtime check consistent when using the backup superblock

The backup superblock may have a last mounted time of zero, if it has
never been updated since the file system was created.  In that case,
the low dtime check may get disabled when using the backup superblock,
even though subsequent e2fsck runs will end up using the low dtime
check.  This can cause a failure of ext4/007, since since when e2fsck
is run a second time after the file system is mounted, the low dtime
check will trigger the e2fsck complaint:

Inode NNNN was part of the orphaned inode list.  IGNORED.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: update the quota records when the root directory is recreated
Theodore Ts'o [Sun, 1 Sep 2019 05:19:24 +0000 (01:19 -0400)]
e2fsck: update the quota records when the root directory is recreated

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agolibsupport: remove unnecessary code to set the quota inode size
Theodore Ts'o [Sun, 1 Sep 2019 05:17:42 +0000 (01:17 -0400)]
libsupport: remove unnecessary code to set the quota inode size

This is done correctly by the fileio routines; and it forces the quota
inode's file size to be unnecessarily rounded up to the block size.

Also remove the unnecessary double colon in the quota's error messages.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub_all: allow scrubbing in vg's whose free space == snapshot size
Theodore Ts'o [Sun, 18 Aug 2019 23:23:07 +0000 (19:23 -0400)]
e2scrub_all: allow scrubbing in vg's whose free space == snapshot size

If the volume group's free space is exactly the same as snapshot size,
e2scrub_all will skip those logical volumes in those volume groups.
Fix this by changing the test from '>' to '>='.

Fixes: c120312253 ("e2scrub_all: make sure there's enough free space...")
Addresses-Debian-Bug: #935009
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agolibuuid: signedness/type fixes
Matthias Andree [Sat, 17 Aug 2019 11:16:02 +0000 (13:16 +0200)]
libuuid: signedness/type fixes

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: add changelog for 1.45.3-4 release
Theodore Ts'o [Wed, 7 Aug 2019 00:19:26 +0000 (20:19 -0400)]
debian: add changelog for 1.45.3-4 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: don't gitignore debian/patches
Theodore Ts'o [Sat, 3 Aug 2019 03:53:38 +0000 (23:53 -0400)]
debian: don't gitignore debian/patches

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agolibblkid: fix gcc -Wall warnings
Theodore Ts'o [Wed, 31 Jul 2019 01:13:44 +0000 (21:13 -0400)]
libblkid: fix gcc -Wall warnings

Google-Bug-Id: 118836063

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: stop using LTO (link-time optimization)
Theodore Ts'o [Mon, 29 Jul 2019 15:40:25 +0000 (11:40 -0400)]
debian: stop using LTO (link-time optimization)

LTO breaks reproducible builds, and there is some question as to how
reliable LTO's code generator is --- there are some scary stories that
it doesn't work well, and the GCC maintainers aren't super-interested
in fixing the bugs:

https://lists.debian.org/debian-devel/2019/07/msg00610.html

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: skip running "make check" if DEB_BUILD_OPTIONS contains nocheck
Theodore Ts'o [Sat, 27 Jul 2019 16:17:06 +0000 (12:17 -0400)]
debian: skip running "make check" if DEB_BUILD_OPTIONS contains nocheck

This was done automatically by debhelper, but it got dropped when
override_dh_auto_test was added by commit 7f4c3bb120 ("debian: run
"make check" with V=1 to keep blhc happy").

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: mark more files in e2fsprogs.install as only being present on Linux
Theodore Ts'o [Fri, 26 Jul 2019 00:07:45 +0000 (20:07 -0400)]
debian: mark more files in e2fsprogs.install as only being present on Linux

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: update changelog for 1.45.3-3 release
Theodore Ts'o [Thu, 25 Jul 2019 19:38:59 +0000 (15:38 -0400)]
debian: update changelog for 1.45.3-3 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: set E2FSCK_TIME correctly on a 32-bit arch with a 64-bit time_t
Theodore Ts'o [Thu, 25 Jul 2019 02:25:11 +0000 (22:25 -0400)]
e2fsck: set E2FSCK_TIME correctly on a 32-bit arch with a 64-bit time_t

Addresses-Debian-Bug: #932906

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: mark logsave as Multi-Arch: foreign
Theodore Ts'o [Thu, 25 Jul 2019 01:54:23 +0000 (21:54 -0400)]
debian: mark logsave as Multi-Arch: foreign

Also fix logsave so it is Architecure: any.  It was previously
"linux-any kfreebsd-any" due to a cut-and-paste error.

Addresses-Debian-Bug: #932876

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: fix Breaks/Replace dependency for logsave
Theodore Ts'o [Thu, 25 Jul 2019 01:50:24 +0000 (21:50 -0400)]
debian: fix Breaks/Replace dependency for logsave

Addresses-Debian-Bug: #932874

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: only install the udev and systemd files to e2fsprogs on Linux systems
Theodore Ts'o [Thu, 25 Jul 2019 01:31:20 +0000 (21:31 -0400)]
debian: only install the udev and systemd files to e2fsprogs on Linux systems

Otherwise it will fail to build on hurd and kfreebsd.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: run "make check" with V=1 to keep blhc happy
Theodore Ts'o [Thu, 25 Jul 2019 00:40:19 +0000 (20:40 -0400)]
debian: run "make check" with V=1 to keep blhc happy

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: update changelog for 1.45.3-2 release
Theodore Ts'o [Wed, 24 Jul 2019 17:19:10 +0000 (13:19 -0400)]
debian: update changelog for 1.45.3-2 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: add a hard dependency on logsave to e2fsprogs
Theodore Ts'o [Wed, 24 Jul 2019 16:20:11 +0000 (12:20 -0400)]
debian: add a hard dependency on logsave to e2fsprogs

The initramfs created by the initramfs-tools package needs logsave and
assumes it comes along with e2fsprogs.  If it is not present, the
result systems which will fail to boot.  Fix this by adding the
dependency.

In the future initramfs-tools will explicitly ask for logsave (tracked
in Debian Bug: #932854), but we'll need to keep this dependency until
the next stable release of Debian.

Addresses-Debian-Bug: #932855
Addresses-Debian-Bug: #932859
Addresses-Debian-Bug: #932861
Addresses-Debian-Bug: #932881
Addresses-Debian-Bug: #932888

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update fr.po (from translationproject.org)
Samuel Thibault [Sun, 21 Jul 2019 23:33:33 +0000 (19:33 -0400)]
po: update fr.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: update to standards version 4.4.0
Theodore Ts'o [Sun, 21 Jul 2019 19:08:14 +0000 (15:08 -0400)]
debian: update to standards version 4.4.0

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub_all_cron: check to make sure e2scrub_all exists
Theodore Ts'o [Sun, 21 Jul 2019 17:13:24 +0000 (13:13 -0400)]
e2scrub_all_cron: check to make sure e2scrub_all exists

Since e2scrub_all.cron is marked as a config file, it can hang around
after the package is removed, in which case e2scrub_all might not be
present.  So check to make sure e2scrub_all exists before trying to
execute it.

Addresses-Debian-Bug: #932622

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reported-by: Laurent Bigonville <bigon@debian.org>
5 years agopo: update pt.po (from translationproject.org)
Pedro Albuquerque [Sun, 21 Jul 2019 16:53:10 +0000 (12:53 -0400)]
po: update pt.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update uk.po (from translationproject.org)
Yuri Chornoivan [Sat, 20 Jul 2019 20:32:18 +0000 (16:32 -0400)]
po: update uk.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update sv.po (from translationproject.org)
Göran Uddeborg [Sat, 20 Jul 2019 20:32:18 +0000 (16:32 -0400)]
po: update sv.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update pl.po (from translationproject.org)
Jakub Bogusz [Sat, 20 Jul 2019 20:32:18 +0000 (16:32 -0400)]
po: update pl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update de.po (from translationproject.org)
Mario Blättermann [Sat, 20 Jul 2019 20:32:17 +0000 (16:32 -0400)]
po: update de.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update cs.po (from translationproject.org)
Petr Pisar [Sat, 20 Jul 2019 20:32:17 +0000 (16:32 -0400)]
po: update cs.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoFinal updates to release notes, etc., for the v1.45.3 release v1.45.3
Theodore Ts'o [Sun, 14 Jul 2019 20:47:09 +0000 (16:47 -0400)]
Final updates to release notes, etc., for the v1.45.3 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: add help text to e2fsprogs.pot explaining ix-nay on positional indicators
Theodore Ts'o [Mon, 15 Jul 2019 00:57:51 +0000 (20:57 -0400)]
po: add help text to e2fsprogs.pot explaining ix-nay on positional indicators

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update nl.po (from translationproject.org)
Benno Schulenberg [Mon, 15 Jul 2019 00:45:46 +0000 (20:45 -0400)]
po: update nl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update cs.po (from translationproject.org)
Petr Pisar [Mon, 15 Jul 2019 00:45:46 +0000 (20:45 -0400)]
po: update cs.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agofuse2fs: stop using the nonempty option by default
Theodore Ts'o [Sun, 14 Jul 2019 16:03:29 +0000 (12:03 -0400)]
fuse2fs: stop using the nonempty option by default

The nonempty option isn't supported by fuse3, and so if fusermount is
from fuse3, having fuse2fs specify nonempty automatically will prevent
fuse2fs from working correctly.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agofuse2fs: install fuse2fs in /usr/bin instead of /usr/sbin
Theodore Ts'o [Sun, 14 Jul 2019 15:05:47 +0000 (11:05 -0400)]
fuse2fs: install fuse2fs in /usr/bin instead of /usr/sbin

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: add lintian override to suppress a false positive
Theodore Ts'o [Sun, 14 Jul 2019 14:44:23 +0000 (10:44 -0400)]
debian: add lintian override to suppress a false positive

Suppress the false positive:

   e2fsprogs: package-supports-alternative-init-but-no-init.d-script

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebugfs: clean up gcc -Wall warning from using snprintf
Theodore Ts'o [Sun, 14 Jul 2019 14:41:36 +0000 (10:41 -0400)]
debugfs: clean up gcc -Wall warning from using snprintf

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agotests: suppress e2image version number from being printed
Theodore Ts'o [Sat, 13 Jul 2019 21:44:20 +0000 (17:44 -0400)]
tests: suppress e2image version number from being printed

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agotests: fix test_script so that it will run all tests if w/o arguments
Theodore Ts'o [Sat, 13 Jul 2019 21:42:30 +0000 (17:42 -0400)]
tests: fix test_script so that it will run all tests if w/o arguments

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: drop "new-essential-package" lintian override
Theodore Ts'o [Sat, 13 Jul 2019 21:40:22 +0000 (17:40 -0400)]
debian: drop "new-essential-package" lintian override

This is no longer necessary, since e2fsprogs is no longer considered
an "essential" package.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: move logsave to its own package
Theodore Ts'o [Sat, 13 Jul 2019 21:29:32 +0000 (17:29 -0400)]
debian: move logsave to its own package

Addresses-Debian-Bug: #923372
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoUpdate release notes, etc., for the 1.45.3 release
Theodore Ts'o [Sat, 13 Jul 2019 20:55:30 +0000 (16:55 -0400)]
Update release notes, etc., for the 1.45.3 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: convert from using dh_movefiles to dh_install
Theodore Ts'o [Sat, 13 Jul 2019 19:58:56 +0000 (15:58 -0400)]
debian: convert from using dh_movefiles to dh_install

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: add xgettext:no-c-format tags
Theodore Ts'o [Sat, 13 Jul 2019 17:49:34 +0000 (13:49 -0400)]
e2fsck: add xgettext:no-c-format tags

The xgettext program is incorrectly marking e2fsck problem
descriptions as being c-style printf strings.  Override its mistakes.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: remove unnecessary/buggy positional parameter specifiers
Theodore Ts'o [Sat, 13 Jul 2019 16:49:26 +0000 (12:49 -0400)]
po: remove unnecessary/buggy positional parameter specifiers

The strings in e2fsck/problem.c use a special %-expansion scheme,
where %b gets expanded to a block number, %i gets expanded to an inode
number, etc., where these values are in a problem context data
structure.  As such, there is no need to use a printf style positional
indicator (e.g., %2$s).  Indeed, the use of things like %1$i or %2$b
will cause the %-expansion code to just print %1$i or %2$b, instead of
the inode or block number, respectively.

Addresses-Debian-Bug: #892173

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Philipp Thomas <pth@suse.de>
Cc: Benno Schulenberg <vertaling@coevern.nl>
Cc: Trần Ngọc Quân <vnwildman@gmail.com>
Cc: Petr Pisar <petr.pisar@atlas.cz>
5 years agoe2scrub_all: only run in service mode when periodic_e2scrub=1
Theodore Ts'o [Thu, 11 Jul 2019 23:41:56 +0000 (19:41 -0400)]
e2scrub_all: only run in service mode when periodic_e2scrub=1

By default, e2scrub_all will not actually trigger online scrubs unless
periodic_e2scrub=1 is set in /etc/e2scrub.conf.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: drop special case CFLAGS for Alpha and PowerMac architectures
Theodore Ts'o [Thu, 11 Jul 2019 22:19:52 +0000 (18:19 -0400)]
debian: drop special case CFLAGS for Alpha and PowerMac architectures

Defining HAVE_NETINET_IN_H for Alpha and __NO_STRING_INLINES for the
PowerMac QUICK bootloader date back to over two decades, to 1997 and
1998, respectively.  These two architectures are no longer supported
by Debian, and it's not clear they are actually needed in 2019 even
for someone building for these architectures.  So let's drop them and
see if anyone complains (or notices).

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub_all: fix "e2scurb_all -r"
Theodore Ts'o [Thu, 11 Jul 2019 17:28:05 +0000 (13:28 -0400)]
e2scrub_all: fix "e2scurb_all -r"

The e2scrub_all program was broken by commit c7d6525ecaab
("e2scrub_all: refactor device probe loop") so that it would use the
path of the snapshot volume instead of the base volume.  This caused
"e2scrub_all -r" to pass the wrong pathname to e2scrub, with the
result that e2scrub would abort with an error instead of removing the
snapshot volume.

Fixes: c7d6525ecaab ("e2scrub_all: refactor device probe loop")
Addresses-Debian-Bug: #931679
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoutil: add a script gen-git-tarball to generate a release tarball from git
Theodore Ts'o [Thu, 11 Jul 2019 16:24:02 +0000 (12:24 -0400)]
util: add a script gen-git-tarball to generate a release tarball from git

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: convert debian/rules to use dh
Theodore Ts'o [Thu, 11 Jul 2019 04:06:07 +0000 (00:06 -0400)]
debian: convert debian/rules to use dh

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: drop support for not building the e2fsck-static and udebs packages
Theodore Ts'o [Tue, 9 Jul 2019 23:04:20 +0000 (19:04 -0400)]
debian: drop support for not building the e2fsck-static and udebs packages

The ability to not build udebs packages and e2fsck-static made sense
when we were doing a separate e2fsprogs builds for those packages.
Since we're not doing that any more, we can simplify things by
dropping that flexibility.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: drop support for Debian Jessie
Theodore Ts'o [Mon, 8 Jul 2019 04:32:25 +0000 (00:32 -0400)]
debian: drop support for Debian Jessie

This allows us to drop the complexity needed to support debhelper v9
and the legacy -dbg packages.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: stop building a special version of e2fsprogs for e2fsprogs-udeb
Theodore Ts'o [Mon, 8 Jul 2019 03:38:25 +0000 (23:38 -0400)]
debian: stop building a special version of e2fsprogs for e2fsprogs-udeb

Previously, we configured and built a separate version of e2fsprogs
for the e2fsprogs-udeb package.  This was important back when we still
cared about build floppies, but going to extra lengths to save 145k of
disk space isn't worth it any more.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: only require the udev, systemd, cron packages when build on Linux
Theodore Ts'o [Fri, 5 Jul 2019 01:21:34 +0000 (21:21 -0400)]
debian: only require the udev, systemd, cron packages when build on Linux

Addresses-Debian-Bug: #931266

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub_all: correctly handle the case where LUKS is stacked on an LV
Theodore Ts'o [Thu, 4 Jul 2019 15:39:45 +0000 (11:39 -0400)]
e2scrub_all: correctly handle the case where LUKS is stacked on an LV

We handle the case where an LVM's PV is stacked on top of a dm-crypt
device, but not the case where it's the other way around, where a LVM
LV contains a LUKS encrypted file system.  Fix this oversight.

Addresses-Debian-Bug: #931387

Reported-by: Marc Haber <mh+debian-bugs@zugschlus.de>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: correctly handle inline directories when large_dir is enabled.
Artem Blagodarenko [Fri, 14 Jun 2019 14:42:37 +0000 (17:42 +0300)]
e2fsck: correctly handle inline directories when large_dir is enabled.

Historically, e2fsck has required that directories not contain holes.
(In fact, as of this writing, ext4 still requires this to be the
case.)  Commit ae9efd05a98 ("e2fsck: 3 level hash tree directory
optimization") removed this requirement if the large_dir feature is
enabled; however, the way it was done caused it to incorrectly handle
inline directories.

To reproduce the problem fixed by this commit:

truncate -s 100000000 ext4.img
misc/mke2fs -t ext4 -I 512 -O 'inline_data,large_dir' ext4.img
mkdir m
sudo mount ext4.img m
mkdir m/aa
sudo umount m
e2fsck/e2fsck -f -n ext4.img

The last command gives this output:

[root@localhost e2fsprogs-kernel]# e2fsck/e2fsck -f -n ext4-2.img
e2fsck 1.45.2 (27-May-2019)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
'..' in /aa (12) is <The NULL inode> (0), should be / (2).
Fix? no

Pass 4: Checking reference counts
Inode 2 ref count is 4, should be 3.  Fix? no

Inode 12 ref count is 2, should be 1.  Fix? no

Pass 5: Checking group summary information

ext4-2.img: ********** WARNING: Filesystem still has errors **********

ext4-2.img: 12/24384 files (0.0% non-contiguous), 17874/97656 blocks

Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Artem Blagodarenko <c17828@cray.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoFix posix_memalign and posix_fadvise calls.
Theodore Ts'o [Fri, 7 Jun 2019 17:07:12 +0000 (13:07 -0400)]
Fix posix_memalign and posix_fadvise calls.

Almost all posix_ functions return a positive errno value (without
setting errno) rather than -1 and setting errno. Most calls in this
project were correct, but these two weren't.

Reported-by: Hughes <enh@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub: remove -C from e2scrub_all
Darrick J. Wong [Tue, 4 Jun 2019 04:27:12 +0000 (21:27 -0700)]
e2scrub: remove -C from e2scrub_all

We already have the "SERVICE_MODE=1" feature that signals to e2scrub
that we're running as a background daemon and therefore we should exit
quietly if conditions aren't right.

It's therefore unnecessary to have a separate -C flag to achieve the
same outcome for cron jobs.  Merge the two together.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update pt.po (from translationproject.org)
Pedro Albuquerque [Thu, 30 May 2019 21:05:57 +0000 (17:05 -0400)]
po: update pt.po (from translationproject.org)

Note: This fixes the yes/no matching strings for mke2fs and tune2fs if
Portuguese is in use.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agotests: add test for e2fsck of verity file
Eric Biggers [Tue, 28 May 2019 23:12:30 +0000 (16:12 -0700)]
tests: add test for e2fsck of verity file

Test that e2fsck doesn't report errors when an inode with the 'verity'
flag has blocks past i_size.

This is a regression test for commits 3baafde6a8ae ("e2fsck: allow
verity files to have initialized blocks past i_size") and 43466d039689
("e2fsck: handle verity files in scan_extent_node()").

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoUpdate release notes, etc., for the 1.45.2 release v1.45.2
Theodore Ts'o [Tue, 28 May 2019 02:10:51 +0000 (22:10 -0400)]
Update release notes, etc., for the 1.45.2 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update the binary gmo files
Theodore Ts'o [Tue, 28 May 2019 00:05:54 +0000 (20:05 -0400)]
po: update the binary gmo files

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agomke2fs: accept the english yes character to the proceed question
Theodore Ts'o [Mon, 27 May 2019 23:36:15 +0000 (19:36 -0400)]
mke2fs: accept the english yes character to the proceed question

In some cases if the translation file is missing some translations,
mke2fs can end up printing an English message, e.g.:

% LANG=it_IT.UTF-8 ./mke2fs /tmp/foo.img 8M
mke2fs 1.45.1 (12-May-2019)
/tmp/foo.img contiene un file system ext4
created on Mon May 27 19:35:48 2019
Proceed anyway? (y,N)

However, if there is a translation for string to match with "yY"
(e.g., to "sS" for Italian), then 'y' won't work.  Fix this by falling
back to the english 'yY' characters.

Addresses-Debian-Bug: #907034
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update ms.po (from translationproject.org)
Sharuzzaman Ahmat Raslan [Mon, 27 May 2019 04:24:01 +0000 (00:24 -0400)]
po: update ms.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update es.po (from translationproject.org)
Antonio Ceballos [Mon, 27 May 2019 04:24:01 +0000 (00:24 -0400)]
po: update es.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: handle verity files in scan_extent_node()
Eric Biggers [Thu, 23 May 2019 15:30:33 +0000 (08:30 -0700)]
e2fsck: handle verity files in scan_extent_node()

Don't report PR_1_EXTENT_END_OUT_OF_BOUNDS on verity files during
scan_extent_node(), since they will have blocks stored past i_size.

This was missed during the earlier fix because this check only triggers
if the inode has enough extents to need at least one extent index node.

This bug is causing one of the fs-verity xfstests to fail with the
reworked fs-verity patchset.

Fixes: 3baafde6a8ae ("e2fsck: allow verity files to have initialized blocks past i_size")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoconfigure: fix test where cron is not installed on a non-systemd system
Theodore Ts'o [Wed, 22 May 2019 17:03:38 +0000 (13:03 -0400)]
configure: fix test where cron is not installed on a non-systemd system

Reported-by: thomas@linuxfromscratch.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: add new Portuguese translation from the Translation Project
Theodore Ts'o [Wed, 22 May 2019 16:33:55 +0000 (12:33 -0400)]
po: add new Portuguese translation from the Translation Project

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update sv.po (from translationproject.org)
Göran Uddeborg [Wed, 22 May 2019 16:31:37 +0000 (12:31 -0400)]
po: update sv.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agodebian: update changelog for maintenance releases
Theodore Ts'o [Wed, 22 May 2019 16:31:04 +0000 (12:31 -0400)]
debian: update changelog for maintenance releases

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub_all: fix missing getopts argument which broke e2scrub_all -C
Theodore Ts'o [Tue, 21 May 2019 00:34:59 +0000 (20:34 -0400)]
e2scrub_all: fix missing getopts argument which broke e2scrub_all -C

Addresses-Debian-Bug: #929287

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub: fix grammar nit: "a LVM" -> "an LVM"
Theodore Ts'o [Mon, 20 May 2019 14:56:51 +0000 (10:56 -0400)]
e2scrub: fix grammar nit: "a LVM" -> "an LVM"

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update uk.po (from translationproject.org)
Yuri Chornoivan [Sun, 19 May 2019 03:32:30 +0000 (23:32 -0400)]
po: update uk.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update pl.po (from translationproject.org)
Jakub Bogusz [Sun, 19 May 2019 03:32:29 +0000 (23:32 -0400)]
po: update pl.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agopo: update cs.po (from translationproject.org)
Petr Pisar [Sun, 19 May 2019 03:32:29 +0000 (23:32 -0400)]
po: update cs.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub_all: avoid scrubbing all devices when there is nothing to scrub
Theodore Ts'o [Sun, 19 May 2019 03:04:49 +0000 (23:04 -0400)]
e2scrub_all: avoid scrubbing all devices when there is nothing to scrub

Running lsblk when there are no valid block devicse results in
generating all block devices as the list of devices to scrub; this
results in a lot of e2scrub_all failures.

Addresses-Debian-Bug: #929186

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2scrub: stop cron spam if lvm2 is not installed.
Theodore Ts'o [Thu, 16 May 2019 18:56:37 +0000 (14:56 -0400)]
e2scrub: stop cron spam if lvm2 is not installed.

Addresses-Debian-Bug: #928977

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoUpdate release notes, etc., for the 1.45.1 release v1.45.1
Theodore Ts'o [Mon, 13 May 2019 01:10:29 +0000 (21:10 -0400)]
Update release notes, etc., for the 1.45.1 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
5 years agoe2fsck: remove an potentially ambiguous dangling else clause
Theodore Ts'o [Fri, 10 May 2019 23:21:03 +0000 (19:21 -0400)]
e2fsck: remove an potentially ambiguous dangling else clause

This doesn't actually fix a bug or change behavior, but it removes a
clang warning.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>