Whamcloud - gitweb
Eric Sandeen [Wed, 19 Mar 2008 20:20:18 +0000 (15:20 -0500)]
Fix ext2fs_extent_get for uninit leaf extents
The ext2fs_extent_get() function was not OR-ing together UNINIT
and LEAF flags in the case where an extent was both; so if we
had an extent which was both uniint and leaf, pass1 would bail
out where depth == max_depth but was not marked as leaf, and
e2fsck (from the next branch) would abort with:
e2fsck 1.40.8 (13-Mar-2008)
Pass 1: Checking inodes, blocks, and sizes
Error1: No 'down' extent
Aborted
Also, if the error is encountered again, print the inode number
to aid debugging until it's properly handled, at least.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:04:24 +0000 (21:04 -0500)]
Add m_uninit test case
Add test case to test for uninit block groups.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:04:19 +0000 (21:04 -0500)]
Add new m_lazy test case
Add test case for lazy bg feature.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:04:03 +0000 (21:04 -0500)]
Make e2fsck uninit block group aware
This patch has all the necesary pieces to open and fix filesystems created
with the uninit block group feature.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:57 +0000 (21:03 -0500)]
Make debugfs uninit block group aware
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:52 +0000 (21:03 -0500)]
Make resize2fs uninit block group aware
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:46 +0000 (21:03 -0500)]
Make dumpe2fs uninit block group aware
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:41 +0000 (21:03 -0500)]
Make tune2fs uninit block group aware
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:36 +0000 (21:03 -0500)]
Add support for creating filesystems using uninit block group
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:30 +0000 (21:03 -0500)]
Rename feature name from gdt_checksum to uninit_groups
This name is a more intuitive option when running mke2fs.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:25 +0000 (21:03 -0500)]
Add uninit block group support to various libext2fs functions
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 22 Oct 2007 02:03:19 +0000 (21:03 -0500)]
Add initial checksum support for the gdt_checksum/uninit_group feature
- Add support for computing CRC-16 value.
- Add call to check/verify/set csum on block_groups.
- Add a test program to verify csum operations.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Thu, 20 Mar 2008 19:31:03 +0000 (15:31 -0400)]
Merge branch 'maint' into next
Theodore Ts'o [Thu, 20 Mar 2008 14:57:55 +0000 (10:57 -0400)]
debugfs: Don't use a pager if stdout is not a tty
If we are redirecting the output of debugfs to a file or to another
process via a pipe, there's no point sending the output to a pager.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Philipp Thomas [Tue, 18 Mar 2008 18:36:12 +0000 (14:36 -0400)]
po: update de.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Theodore Ts'o [Tue, 18 Mar 2008 03:17:13 +0000 (23:17 -0400)]
Fix miscellaneous gcc -Wall warnings
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Sat, 15 Mar 2008 15:16:56 +0000 (11:16 -0400)]
Change valgrind options in test_script to conform with valgrind 3.2.3
Newer versions of valgrind seem to have renamed --wierd-hacks to
--sim-hints.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Andreas Dilger [Sat, 2 Feb 2008 08:25:03 +0000 (01:25 -0700)]
Add support for the DIR_NLINK feature.
This patch includes the changes required to e2fsck to understand the
nlink count changes made in the kernel.
In e2fsck pass 4, when we fetch the actual link count, if it is
exceeds 65,000 we set the link count to 1. We silently fix the
situation where the nlink count of the directory is 1, and there are
fewer than 65,000 subdirectories, since since that can happen
naturally.
Patch originally from CFS, significantly rewritten by Theodore Ts'o.
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: Kalpak Shah <kalpak@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Thu, 13 Mar 2008 17:37:29 +0000 (13:37 -0400)]
libext2fs: Make icount use a 32-bit counter
In order to more accurately count the number of directories, which
with the DIR_NLINKS feature can now be greater than 65,000, change
icount to use a 32-bit counter. This doesn't cost us anything extra
when the icount data structures are stored in memory, since due to
padding for alignment reasons.
If the actual count is greater than 65,500, we return 65,500. This is
because e2fsck doesn't actually need to know the exact count; it only
needs to know if the number of subdirectories is greater than 65,000.
In the future if someone really needs to know the exact number, we
could add a 32-bit interface. One isn't needed now, though.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Josef Bacik [Thu, 13 Mar 2008 17:46:10 +0000 (13:46 -0400)]
resize2fs: Add options to print (and resizing to) the minimum filesystem size
Add the -P option to print the minimum filesystem size and exit.
Add the -M option to force resizing the filesystem to the minimum
filesystem size.
Signed-off-by: Josef Back <jbacik@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Sat, 15 Mar 2008 05:27:08 +0000 (01:27 -0400)]
Merge branch 'maint'
Theodore Ts'o [Sat, 15 Mar 2008 05:25:51 +0000 (01:25 -0400)]
ext2_fs.h: Rename EXT4_ORPHAN_FS to be EXT3_ORPHAN_FS
No application will ever use the ORPHAN_FS flag, since it only shows
up in kernel memory, but it's been pointed out it was first used in
ext3, and so it should be renamed for accuracy.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 14 Mar 2008 18:29:51 +0000 (14:29 -0400)]
Update release notes and debian changelog for 1.40.8-2 release
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 14 Mar 2008 19:13:45 +0000 (15:13 -0400)]
debian: Remove preinstall script which is no longer necessary
The preinstall script checked for dpkg --asert-support-predepends,
which has been true since 1996. Also it removed configuration files
which haven't been around since well before Debian sarge, more than
two stable releases ago.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Matthias Koenig [Fri, 14 Mar 2008 17:29:35 +0000 (13:29 -0400)]
uuidd: Fix issues identified by SuSE's security team
SuSE's security team audited uuidd and came up with these issues.
None of them are serious given that uuidd runs setuid as a
unprivileged user which has no special access other than libuuid
directory, but it's good to get them fixed.
Signed-off-by: Matthias Koenig <mkoenig@suse.de>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Eric Sandeen [Fri, 29 Feb 2008 22:10:21 +0000 (16:10 -0600)]
Fix ext2fs_swap_inode_full() for in-inode xattrs on big-endian machines
After the fix for resize2fs's inode mover losing in-inode
extended attributes, the regression test I wrote caught
that the attrs were still getting lost on powerpc.
Looks like the problem is that ext2fs_swap_inode_full()
isn't paying attention to whether or not the EA magic is
in hostorder, so it's not recognized (and not swapped)
on BE machines. Patch below seems to fix it.
Yay for regression tests. ;)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Theodore Ts'o [Fri, 14 Mar 2008 14:42:50 +0000 (10:42 -0400)]
libext2fs: Fix fencepost error in ext2fs_extent_insert()
ext2fs_extent_insert() was copying n-1 of the existing extents when
moving things down to make room for the new extent.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 14 Mar 2008 03:55:40 +0000 (23:55 -0400)]
libext2fs: Fix ext2fs_extent_delete() to always point at a valid entry
When deleting the last entry in a node, back up the current pointer so
it is always pointing at a valid entry.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 14 Mar 2008 03:13:18 +0000 (23:13 -0400)]
e2fsck: Check for fast symlinks that have EXTENTS_FL set
These shouldn't show up in the wild, but if they do, e2fsck will offer
to clear them.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 14 Mar 2008 03:05:00 +0000 (23:05 -0400)]
e2fsck: Support long symlinks which use extents
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 14 Mar 2008 00:25:51 +0000 (20:25 -0400)]
Update release notes, version files for 1.40.8 release
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Thu, 13 Mar 2008 22:52:18 +0000 (18:52 -0400)]
Don't fail the "make install" if the info files have not been built
We don't fail the "make all" if the "makeinfo" command isn't there, so
we shouldn't fail the "make install", either.
Addresses-Sourceforge-Bug: #1586610
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Philipp Thomas [Thu, 13 Mar 2008 22:21:09 +0000 (18:21 -0400)]
po: update de.po (from translationproject.org)
Addresses-Debian-Bug: #302512
Addresses-Debian-Bug: #370247
Addresses-Debian-Bug: #401092
Addresses-Debian-Bug: #412882
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Jose R. Santos [Mon, 3 Mar 2008 16:41:29 +0000 (10:41 -0600)]
Add {read,write}_blk64 to inode_io.c
Add 64-bit block capable routines to inode IO manager. Since fileio.c
does not yet have 64bit support, these routines will not handle 64bit
block numbers correctly yet.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 3 Mar 2008 16:41:24 +0000 (10:41 -0600)]
Add {read,write}_blk64 to unix_io.c
Add 64-bit block capable routines to Unix IO manager.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jose R. Santos [Mon, 3 Mar 2008 16:41:18 +0000 (10:41 -0600)]
Add 64-bit IO manager operations to struct_io_manager.
In order to provide 64-bit block support for IO managers an maintain
ABI compatibility with the old API, some new functions need to be
added to struct_io_manger. Luckily, strcut_io_manager has some
reserved space that we can use to add these new functions.
Signed-off-by: Jose R. Santos <jrs@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Thu, 13 Mar 2008 14:53:26 +0000 (10:53 -0400)]
Merge branch 'maint'
Conflicts:
lib/ext2fs/ext2_err.et.in
Theodore Ts'o [Thu, 13 Mar 2008 14:44:54 +0000 (10:44 -0400)]
e2fsck: Use "Clear Htree" instead of "Clear" when the Htree is corrupt
Change the prompt so it is clear to the user that e2fsck will be
clearing the htree information, not the directory inode itself, when
the htree information has proven to be corrupt.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Thu, 13 Mar 2008 05:03:28 +0000 (01:03 -0400)]
e2image: Use open64() so that "e2image -I" works on image files > 2GB
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Thu, 13 Mar 2008 04:58:54 +0000 (00:58 -0400)]
e2fsck: Fix directory i_size handling
If a directory's i_size is bigger than the number of blocks, don't try
to allocate extra empty blocks to the end of the directory; there's no
real point to do that. Also, if a directory's i_size is not a
multiple of the blocksize, flag that as a mistake so it can be fixed.
This more elegantly addresses the problem which was found on Bas van
Schaik's filesystem.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Thu, 13 Mar 2008 04:34:16 +0000 (00:34 -0400)]
libext2fs: Add ext2fs_dblist_get_last() and ext2fs_dblist_drop_last()
Add two new functions which allows the caller to examine the last
directory block entry added to the list, and to drop if it necessary.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 12 Mar 2008 20:10:48 +0000 (16:10 -0400)]
e2fsck: Handle a pass 2 "should never happen" error gracefully
Turns out a "should never happen" error can indeed happen very easily
if a directory with an htree index has an incorrect, and too-large,
i_size field. This patch fixes this so that we handle this situation
gracefully, allowing filesystems with this error to be fixed.
In another patch I will clean up the specific problem which caused the
internal "should never happen" error from happening at all, but patch
will prevent e2fsck from crashing, and prompt the user to remove the
htree index, so it can be rebuilt again after pass 3.
Thanks to Bas van Schaik at Tetra for giving me access to his system
so this problem could be debugged.
Addresses-Launchpad-Bug: #129395
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 12 Mar 2008 16:12:50 +0000 (12:12 -0400)]
e2fsck: Fix obvious typo in an "internal error" message
Thanks to Philipp Thomas for pointing this out.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Petr Pisar [Tue, 11 Mar 2008 16:08:52 +0000 (12:08 -0400)]
po: update cs.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Clytie Siddall [Mon, 10 Mar 2008 19:08:29 +0000 (15:08 -0400)]
po: update vi.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Göran Uddeborg [Mon, 10 Mar 2008 19:08:29 +0000 (15:08 -0400)]
po: update sv.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Jakub Bogusz [Mon, 10 Mar 2008 19:08:29 +0000 (15:08 -0400)]
po: update pl.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Benno Schulenberg [Mon, 10 Mar 2008 19:08:29 +0000 (15:08 -0400)]
po: update nl.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Theodore Ts'o [Sun, 9 Mar 2008 01:20:40 +0000 (20:20 -0500)]
resize2fs: Fix resizing filesystems with large inodes
Use ext2fs_get_next_inode_full() in resize2fs and clean up large inode
handling; previous attempt was not properly handling all cases, and
was incorrectly setting i_extra_isize. This caused some extended
attributes to get removed or randomly assigned to other inodes as a
result of the resize, which can be unfortunate on systems using
SELinux.
The previous commit didn't fix things completely on big-endian systems
like PowerPC.
Addresses-Red-Hat-Bugzilla: #434893
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Sun, 9 Mar 2008 01:01:05 +0000 (20:01 -0500)]
blkid: Fix portability problem caused by using uint instead of unsigned int
This is needed to fix compilation with DJGPP; thanks to Cristophe
Grenier for pointing this out.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Sun, 9 Mar 2008 00:48:56 +0000 (19:48 -0500)]
Fix mke2fs man page regarding 128-byte default inode size
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 05:43:29 +0000 (00:43 -0500)]
Merge branch 'maint'
Theodore Ts'o [Fri, 29 Feb 2008 03:51:49 +0000 (22:51 -0500)]
Update release notes, version files for 1.40.7 release
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 04:43:34 +0000 (23:43 -0500)]
debian: Avoid adding an empty directory in the uuid-dev package
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 04:43:03 +0000 (23:43 -0500)]
debian: Add required ${shlibs:Depends} to libss2's depend header
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 04:42:26 +0000 (23:42 -0500)]
Fix up debian copyright files to avoid Lintian errors
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 02:47:05 +0000 (21:47 -0500)]
Update e2fsprogs translation template and po/gmo files
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 02:26:01 +0000 (21:26 -0500)]
tune2fs: Remove support for clearing the SPARSE_SUPER feature
Clearing SPARSE_SUPER is dangerous; it can result in a filesystem
which e2fsck can't fix easily. Since there is very few good reasons
for wanting to turn this feature off, disable tune2fs's abiity to do
this. Users who really want this can use debugfs.
Also, deprecate the tune2fs -s option. Remove it from the man page
and usage message.
Addresses-Sourceforge-Bug: #1840286
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 02:12:31 +0000 (21:12 -0500)]
Update mke2fs usage message
Add options supported by mke2fs to its usage message.
Addresses-Sourceforge-Bug: #1751393
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Andreas Mohr [Fri, 29 Feb 2008 01:50:05 +0000 (20:50 -0500)]
Add manpage references to debugfs/tune2fs commands
Make debugfs and tune2fs reference each other in the "SEE ALSO"
section.
Addresses-Sourceforge-Patches: #1399325
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Mike Frysinger [Fri, 29 Feb 2008 01:41:17 +0000 (20:41 -0500)]
Fix makefile dependency issues for various install targets
Addresses-Sourceforge-Patches: #1903484
Addresses-Sourceforge-Patches: #1903466
Addresses-Sourceforge-Patches: #1903456
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 29 Feb 2008 00:54:03 +0000 (19:54 -0500)]
Improve descriptions for the r_move_itable and r_resize_inode tests
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Eric Sandeen [Thu, 28 Feb 2008 19:22:12 +0000 (13:22 -0600)]
Add regression test for resize2fs moving inodes with inline xattrs
The image contains an inode past the resize point with an inline xattr
value of "propervalue". It also contains deleted inodes which had the
xattr value "oldvalue".
When resize2fs moves the inode, it should copy the xattr as well, so
that post-resize we see "propervalue" not "oldvalue".
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Eric Sandeen [Thu, 28 Feb 2008 19:24:17 +0000 (13:24 -0600)]
resize2fs: Fix movement of large (greater than 128 byte) inodes
inode_scan_and_fix() in resize2fs needs to do read/write of the full
inode to be sure it gets all data from larger (>128 byte) inodes.
Addresses-Red-Hat-Bugzilla: #434893
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 23:53:34 +0000 (18:53 -0500)]
Merge branch 'maint'
Conflicts:
lib/blkid/devname.c
lib/blkid/probe.c
misc/mke2fs.c
misc/tune2fs.c
Theodore Ts'o [Wed, 27 Feb 2008 20:10:20 +0000 (15:10 -0500)]
e2fsck: Print an explicit message when the bad block inode is updated
Some users were confused about why the filesystem was modified.
Addresses-Sourceforge-Bug: #756460
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 20:01:19 +0000 (15:01 -0500)]
Add support for manipulating large_file feature in mke2fs and tune2fs
Previously we just let the kernel and e2fsck do this automatically,
but e2fsck will no longer automatically clear the large_file feature.
It still isn't really necessary to worry about this feature flag
explicitly, but some users seem to care.
Addresses-Red-Hat-Bugzilla: #258381
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 19:19:18 +0000 (14:19 -0500)]
fsck: Don't complain about an old-style fstab if the fstab is empty
Addresses-Debian-Bug: 468176
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 18:38:56 +0000 (13:38 -0500)]
debugfs: Fix find_free_block to avoid reporting the block more than once
Addresses-Sourceforge-Bug: #1096315
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 07:06:08 +0000 (02:06 -0500)]
Fix gcc -Wall warnings for lib/blkid/probe.c
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 05:00:30 +0000 (00:00 -0500)]
e2fsck: Don't clear the LARGE_FILES feature flag
Stop clearing the EXT2_FEATURE_RO_COMPAT_LARGE_FILE flag automatically
if there are no large files in the filesystem. It's been almost a
decade since there have been kernels that don't support this flag, and
e2fsck clears it quietly without telling the user why the filesystem
has been changed.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 03:24:42 +0000 (22:24 -0500)]
libblkid: Add error checking to devicemapper code to avoid segfaults
If a device mapper volume disappears while libblkid code is running,
it is possible for the devicemapper code to return errors, and since
libblkid wasn't checking for error returns, it would dereference a
null pointer and crash. Add error checking to prevent this.
Addresses-RedHat-Bugzilla: #433857
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 01:59:56 +0000 (20:59 -0500)]
Enhance e2fsck's reporting for reporting unsupported filesystem features
Addresses-Sourceforge-Feature-Request: #1175808
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 01:45:36 +0000 (20:45 -0500)]
libext2fs: Add EXT2_FLAG_NONFREE_ON_ERROR to ext2fs_open2()
Add a flag which returns the partially completed filesystem object so
e2fsck can print more intelligent error messages.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 27 Feb 2008 00:05:33 +0000 (19:05 -0500)]
Fix dumpe2fs parsing of explicit superblock/blocksize parameters
The dumpe2fs syntax documented in the man page has been broken for
some time due to getopt() changes. Change the option syntax in
dumpe2fs to be one which is more extensible and consistent with the
format for extended options in mke2fs and tune2fs.
Addresses-Sourceforge-Bug: #1830994
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 26 Feb 2008 22:38:48 +0000 (17:38 -0500)]
Eliminate really obsolete references to Linux 2.0/2.1/2.2 in tune2fs man page
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 26 Feb 2008 22:31:06 +0000 (17:31 -0500)]
tune2fs: Add support to clear the resize_inode feature
This requires an fsck aftwards. We don't allow setting the
resize_inode feature because extensive work to tune2fs or e2fsck to
safely relocate blocks is necessary in order to reserve the blocks
needed by the resize inode.
Addresses-Red-Hat-Bugzilla: #167816
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 26 Feb 2008 20:08:14 +0000 (15:08 -0500)]
tune2fs: Cleanup feature handling to avoid merge conflicts
Use a more abstract set of feature tests to avoid merge conflicts as
we add support for new features in the maint, master, next, and pu git
branches.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 26 Feb 2008 19:27:57 +0000 (14:27 -0500)]
Teach tune2fs to use e2p_edit_feature2() to provide better error handling
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 26 Feb 2008 19:26:01 +0000 (14:26 -0500)]
libe2p: New e2p_edit_feature2 which provides better error handling
This creates a new enhanced edit_feature function for libe2p which
supports a different set of feature flags that are OK to clear as
opposed to set, and which returns more specific information about why
the user provided an invalid edit feature command.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 26 Feb 2008 17:50:51 +0000 (12:50 -0500)]
e2fsck: Document that the -D option finds duplicate file names
Document in the e2fsck man page that e2fsck finds duplicate filenames
only when the -D option is passed to e2fsck.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 26 Feb 2008 17:11:47 +0000 (12:11 -0500)]
debian: Pass 100 to UID_MIN and GID_MIN, not 1
According to the policy, UIDs and GIDs in the range 1-100 are reserved
to be globally allocated by the base-passwd package. The libuuid1
postinstall script passes in UID_MIN=1 and GID_MIN=1. The useradd and
groupadd commands seems to skip UID's between 1 and 100 anyway, but
it's confusing, so we should pass in UID_MIN=100 and GID_MIN=100 for
clarity and in case useradd and groupadd ever changes their behaviour.
Addresses-Debian-Bug: #466929
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 22 Feb 2008 21:52:27 +0000 (16:52 -0500)]
libe2p: Change Raid to RAID in display option
Update m_raid_opt test so that it reflects the code change.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Valerie Clement [Thu, 21 Feb 2008 15:39:23 +0000 (16:39 +0100)]
Add missing shift for ei_leaf_hi
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Valerie Clement [Thu, 21 Feb 2008 15:39:23 +0000 (16:39 +0100)]
Add missing free in ext2fs_extent_free()
handle->path should be freed in ext2fs_extent_free()
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 22 Feb 2008 20:53:50 +0000 (15:53 -0500)]
e2fsck: Account for index nodes in the extent tree for i_blocks
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 22 Feb 2008 20:04:37 +0000 (15:04 -0500)]
mke2fs: Remove warning for inode_size > 128 bytes
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 22 Feb 2008 20:03:49 +0000 (15:03 -0500)]
mke2fs: Remove 2.4 kernel warning for blocksizes > 4096 bytes
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Fri, 22 Feb 2008 20:01:03 +0000 (15:01 -0500)]
mke2fs: Remove requirement for -f option for filesystems > 2**31 blocks
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 20 Feb 2008 13:20:02 +0000 (08:20 -0500)]
Add ability to set (but not clear) the extents feature to tune2fs
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Wed, 20 Feb 2008 13:13:19 +0000 (08:13 -0500)]
Allow mke2fs to create filesystems with the EXTENTS feature
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 19 Feb 2008 13:33:50 +0000 (08:33 -0500)]
Fix memory leak in ext2fs_alloc_block()
If a block buffer was not supplied and ext2fs_alloc_block() returned
with no errors, it would leak a temporary block buffer.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Eric Sandeen [Wed, 30 Jan 2008 23:25:03 +0000 (17:25 -0600)]
blkid: detect LVM2 physical volumes
Bits liberally stolen from lvm2 userspace.
Addresses-Red-Hat-Bugzilla: #409321
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Theodore Ts'o [Tue, 19 Feb 2008 04:01:43 +0000 (23:01 -0500)]
Merge branch 'maint' into next
Theodore Ts'o [Tue, 19 Feb 2008 03:59:42 +0000 (22:59 -0500)]
libe2p: Make list_super2() print the RAID stride and stripe-width
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 19 Feb 2008 03:56:25 +0000 (22:56 -0500)]
Add support for setting RAID stride and strip-width via mke2fs and tune2fs
This is useful for mballoc to align block allocation on the RAID
stripe boundaries.
Signed-off-by: Rupesh Thakare <rupesh@clusterfs.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Theodore Ts'o [Tue, 19 Feb 2008 03:16:52 +0000 (22:16 -0500)]
debugfs: Add new superblock fields to the set_super_value command
Signed-off-by: Rupesh Thakare <rupesh@clusterfs.com>
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Eric Sandeen [Wed, 30 Jan 2008 03:30:46 +0000 (21:30 -0600)]
print "mostly-printable" xattr strings in debugfs
Taking a cue from getfattr... if a string is "mostly"
printable characters, go ahead & print as a string,
and escape what's left over.
so we get:
Extended attributes stored in inode body:
selinux = "system_u:object_r:root_t:s0\000" (28)
instead of:
Extended attributes stored in inode body:
selinux = "73 79 73 74 65 6d 5f 75 3a 6f 62 6a 65 63 74 5f 72 3a 72 6f 6f 74 5f 74 3a 73 30 00 " (28)
(selinux includes the trailing null in "len" so it
never prints as a string today)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Andreas Dilger [Sat, 2 Feb 2008 08:22:05 +0000 (01:22 -0700)]
e2fsprogs-tests-f_ea_checks.patch
Test case for various types of extended attribute block corruption
Signed-off-by: Andreas Dilger <adilger@sun.com>
Andreas Dilger [Sat, 2 Feb 2008 08:22:05 +0000 (01:22 -0700)]
e2fsprogs-tests-f_unsorted_EAs.patch
Test case for allowing unsorted EAs in the fast in-inode space.
Signed-off-by: Andreas Dilger <adilger@sun.com>