Whamcloud - gitweb
tools/e2fsprogs.git
6 years agoAOSP: Revert "Add "libc" to soong static_executable targets."
Jeff Gaston [Thu, 16 Mar 2017 22:41:13 +0000 (15:41 -0700)]
AOSP: Revert "Add "libc" to soong static_executable targets."

This reverts commit b799ad178fa18c2925a283206496d3f5d6e87f35.
It's no longer needed after https://android-review.googlesource.com/c/329298/

Bug: 34722432
Test: lunch aosp_arm-eng && mmma external/e2fsprogs
Change-Id: I4115fe89ef7751364053223be24e7682e66b6b67
From AOSP commit: 34115ec38e86ba3cc17ae7a866e891abf7bd3aeb

6 years agoAOSP: mke2fs: Don't require mke2fs.conf on Windows.
Steven Moreland [Mon, 12 Feb 2018 23:18:03 +0000 (15:18 -0800)]
AOSP: mke2fs: Don't require mke2fs.conf on Windows.

This target doesn't exist on Windows.

Fixes the following error:
build/make/core/main.mk:586: warning: Missing required dependency host_cross_mke2fs.conf from module host_cross_mke2fs defined in out/soong/Android-aosp_walleye.mk

Bug: 7456955
Test: above error no longer present
Change-Id: I278e53488ecfc4f9d5e540a70276344af06ad455
From AOSP commit: dd086f6cfbec49e47ae407d9cbbbc374edd2925b

6 years agoAOSP: mke2fs: add links for mkfs.ext[234]
Mark Salyzyn [Mon, 12 Feb 2018 21:17:21 +0000 (13:17 -0800)]
AOSP: mke2fs: add links for mkfs.ext[234]

LTP tests assume existence of mkfs.ext[234] in order to create
filesystems, so we add the symbolic links.

Test: vts
Bug: 31226527
Bug: 31226662
Bug: 31226379
Bug: 31226047
Bug: 31226376
Bug: 31226714
Bug: 31226122
Bug: 31225634
Bug: 31226069
Bug: 31226031
Bug: 31225881
Bug: 31226562
Bug: 31226411
Bug: 31226410
Bug: 31226028
Bug: 31226509
Bug: 31226253
Bug: 31226404
Bug: 31226353
Bug: 31225624
Bug: 31225677
Bug: 31225191
Change-Id: I039c9e495d11dfc448f7f0de9e519394ed827d7a
From AOSP commit: cca6a5cea983546f08584e74bba271524ce37b11

6 years agoAOSP: blkid: sanity check 'end' address must be greater than or equal to 'lable'...
Dong Jinguang [Fri, 29 Dec 2017 09:00:37 +0000 (17:00 +0800)]
AOSP: blkid: sanity check 'end' address must be greater than or equal to 'lable' address.

Avoid a potential out-of-bounds memory access address of label

Test: mma -j8 and boot devices
Change-Id: I155aa4e26f7079f517be3202de0032a86368559d
From AOSP commit: 38324e758b803e99419d24e16a00b32f8ebbf473

6 years agoAOSP: Suppress warnings/errors for clang+mingw
Dan Willemsen [Thu, 30 Nov 2017 04:20:04 +0000 (20:20 -0800)]
AOSP: Suppress warnings/errors for clang+mingw

Hide unused parameters/variables warnings for mingw.

There are a lot of typedef redefinition errors (warnings) stemming from
linux/types.h being included after ext2_types.h

Bug: 69933068
Test: mmma external/e2fsprogs
Change-Id: Id0815e9e01f4c137fb57696f7afd37935ebd35a1
From AOSP commit: 5155fb404659d345ee4b536673ac83b0f822e8a3

6 years agoAOSP: Standarize on VFS_CAP_REVISION_2
Nick Kralevich [Mon, 27 Nov 2017 22:07:42 +0000 (14:07 -0800)]
AOSP: Standarize on VFS_CAP_REVISION_2

In https://github.com/torvalds/linux/commit/8db6c34f1dbc8 , namespaced
file capabilities were introduced. That change updated VFS_CAP_REVISION
from VFS_CAP_REVISION_2 to VFS_CAP_REVISION_3.

Android code is written assuming v2 capabilities, and the code will
break if we naively try to treat a v2 structure as a v3 structure.
So don't even try.

Android kernels prior to v4.14 will not support this extended capability
structure, so attempting to set such capabilities will ultimately fail.

With 8db6c34f1dbc8, it appears that attempting to read a v3 capabilities
xattr will always downgrade the capability to a v2 capability, so it
really doesn't make sense to look for a v3 capability.

Android capabilities are only created at /system and /vendor filesystem
creation time by host tools. Android processes, within or outside a
namespace, are not permitted CAP_SETFCAP
(https://android-review.googlesource.com/c/platform/system/sepolicy/+/547801/1/public/domain.te
line 1101). So we should never have to deal with a v3 capability other
than those that might appear on the /system / /vendor partition at a
future date by a future author.

Bug: 69617725
Test: build/test/boot/CTS passes
Change-Id: I7f9ed62b0a539f705d697113d007f0e7379221ea
From AOSP commit: b256c96940e8e709456f0dc29cce5bf8285f687d

6 years agoAOSP: Remove unnecessary warning flags, now that the warnings are fixed.
Stephen Hines [Fri, 10 Nov 2017 23:49:47 +0000 (15:49 -0800)]
AOSP: Remove unnecessary warning flags, now that the warnings are fixed.

Bug: http://b/66996870
Bug: http://b/67046543
Test: Built aosp_sailfish successfully.
Change-Id: Ie527b8f4d2917f226c6379bc5873a14d51782ecd
From AOSP commit: 70c8ef1b628bffd2d816774a03b513f30e202715

6 years agoAOSP: Add e2fsprogs-defaults cc_defaults
Chih-Hung Hsieh [Wed, 27 Sep 2017 18:12:30 +0000 (11:12 -0700)]
AOSP: Add e2fsprogs-defaults cc_defaults

This is the result of two commits:

AOSP: Use -Werror in external/e2fsprogs
AOSP: Revert "Use -Werror in external/e2fsprogs"

... where the second wasn't quite an exact revert of the first.
Sigh.

Change-Id: I3842bd72cdb24ca51a0a42685a33a0ce082f9c77
From AOSP commit: 2002d7f1fca44300198d7eee8503e015e4d4682e

Change-Id: I16e52d4088c5b85dd23de519cb5af8aefeef85e6
From AOSP commit: ec02acfd8576df4bd0779c9f88f32e02355c5d2c

6 years agoFix whitespace fixups in ext2_types.h.in
Theodore Ts'o [Mon, 26 Feb 2018 17:41:39 +0000 (12:41 -0500)]
Fix whitespace fixups in ext2_types.h.in

This was the remaining cleanup still left from AOSP commit
3b6444cb27c196ad4f8356c7cee4465b6cd7865e

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoRemove fsstress from build
Jin Qian [Tue, 10 Oct 2017 00:42:13 +0000 (17:42 -0700)]
Remove fsstress from build

This is outdated and deprecated by android-xfstests
http://thunk.org/android-xfstests

Bug: 67046543
Change-Id: Ic80d5636bc06420f92ee2400bada5b7eb5595253
From AOSP commit: da63249bb23d54e7a9eaab1d365ec7b175ad5e30

6 years agoAOSP: Suppress use of ASan on e2fsdroid temporarily.
Stephen Hines [Fri, 27 Oct 2017 18:44:15 +0000 (11:44 -0700)]
AOSP: Suppress use of ASan on e2fsdroid temporarily.

There is a heap buffer overflow that the next toolchain detects on
e2fsdroid. In order to expedite deploying that toolchain, which has been
validated on all of our other targets, we are going to suppress
host sanitization of this executable until we can resolve the actual
bug.

Bug: http://b/68387795
Test: ASAN_OPTIONS=detect_leaks=0 SANITIZE_HOST=address m -j48
Change-Id: I35126c25a65304e53a18031d99334cc57e21a6a5
From AOSP commit: 4705e518c65bf38d876188f28b65fd4815c716d7

6 years agoAOSP: Rename libz-host -> libz
Dan Willemsen [Wed, 27 Sep 2017 23:11:57 +0000 (16:11 -0700)]
AOSP: Rename libz-host -> libz

Test: m host
Change-Id: I8b0edfe2076531bd4c4f1023b1076aec5f722a44
From AOSP commit: d4356bb606dbcad0b77788318c6199081262b373

6 years agoAOSP: mke2fs, libext2fs: make filesystem image reproducible
Jin Qian [Mon, 28 Aug 2017 21:44:14 +0000 (14:44 -0700)]
AOSP: mke2fs, libext2fs: make filesystem image reproducible

Override fs->now with env E2FSPROGS_FAKE_TIME
Override hash seed with -E hash_seed=<uuid>

Bug: 64994964
Change-Id: If1af7e990b5bf2939a7d5f2a9986406e12c294e9
From AOSP commit: 51663e0d2aa2958b5ef590299b2018a2ae01d256

6 years agoAOSP: Add missing libdl dependencies
Pavlin Radoslavov [Wed, 23 Aug 2017 22:02:55 +0000 (15:02 -0700)]
AOSP: Add missing libdl dependencies

Bug: 62815515
Test: lunch full-eng; make checkbuild
Change-Id: I1751669c4ed046c22587938e04eb76abe8553a8d
From AOSP commit: a24084ceb74c84b0943c86deb5cb99a63d3c46d7

6 years agoAOSP: Fix android build warnings in e2fsdroid and libext2fs
Jin Qian [Thu, 10 Aug 2017 18:12:16 +0000 (11:12 -0700)]
AOSP: Fix android build warnings in e2fsdroid and libext2fs

Change-Id: I23b7abc8af87d87786523944186de1321726a529
From AOSP commit: 424fa8ce373566040ae6ba31151bfbef566b7166

6 years agoAOSP: misc: fix resource leak in populate_fs
Jin Qian [Thu, 10 Aug 2017 18:11:09 +0000 (11:11 -0700)]
AOSP: misc: fix resource leak in populate_fs

Contributed-By: Ivan Maidanski <i.maidanski@samsung.com>
Change-Id: Ibffdeea347d993c97f86ff7bfc5e78024048afce
From AOSP commit: 978002e04483ddab12187f2e08b28996657bc818

6 years agoAOSP: e2fsdroid: print used/total inode and block count
Yang Jin [Thu, 3 Aug 2017 23:46:48 +0000 (16:46 -0700)]
AOSP: e2fsdroid: print used/total inode and block count

Bug: 64272984
Change-Id: Idc727e556a3fa7fb85ff0f845b9452c8c033c22d
From AOSP commit: 131d29f6a826438aff0e5870fb3711358d2a0988

6 years agoAOSP: build mke2fs for windows using android mingw library
Jin Qian [Wed, 12 Jul 2017 22:18:33 +0000 (15:18 -0700)]
AOSP: build mke2fs for windows using android mingw library

Bug: 23686092
Change-Id: I4c7b0c69e3e3c48321d3a0a964ad65c87fc32bbd
From AOSP commit: 83da0276c3ff0a1c33f9042798b319542e254060

6 years agoAOSP: mke2fs, libext2fs: fix bugs on windows
Jin Qian [Mon, 24 Jul 2017 21:18:16 +0000 (14:18 -0700)]
AOSP: mke2fs, libext2fs: fix bugs on windows

Added O_BINARY to open output files on windows, otherwise they're
written as text files and have invalid data.

Use '(filename):block_count:block_size' for sparse file name because
windows file name can contain ':', e.g. 'c:\output_file'.

Bug: 23686092

Change-Id: I731c13e5df0be8c831464c431b8949d33438fb24
From AOSP commit: 0dcf8ec6a429ce4f024fe7838fee2d5636e8ba4d

6 years agoAOSP: build static version of mke2fs and e2fsdroid for host
Jin Qian [Wed, 12 Jul 2017 20:29:38 +0000 (13:29 -0700)]
AOSP: build static version of mke2fs and e2fsdroid for host

Statically link those two binaries for host build so that we can
package them with fastboot without including other library files.

Bug: 35219933
Change-Id: Ic4762ba5eda8ac61723a2c4137690d12a0aa57f2
From AOSP commit: 42297fb01aa2a49ead938c1d24868941a39fd434

6 years agoAOSP: e2fsdroid: use libselinux function to read file context on device
Jin Qian [Tue, 20 Jun 2017 20:49:53 +0000 (13:49 -0700)]
AOSP: e2fsdroid: use libselinux function to read file context on device

When e2fsdroid runs on device, location of selinux file contexts
should be determined by libselinux instead of using arbitrary paths.

Bug: 35219933
Change-Id: I413b198422eddb212599498b532ba2c4d8bb36c6
From AOSP commit: c0bd89b31a7719dd3d51137b3d47a9597ba6b038

6 years agoAOSP: Require mke2fs.conf when building mke2fs
Jin Qian [Wed, 7 Jun 2017 19:39:18 +0000 (12:39 -0700)]
AOSP: Require mke2fs.conf when building mke2fs

make sure mke2fs.conf is copied to /etc so that mke2fs can find it
when running on device.

Bug: 35219933
Change-Id: I400cd21ea3b643469e89bb9bb6cd1536a090598a
From AOSP commit: a86e4d29450668be7bc36f4450e6948bd95b39d8

6 years agoAOSP: build mke2fs and e2fsdroid as static executables for recovery mode
Jin Qian [Fri, 9 Jun 2017 19:37:27 +0000 (12:37 -0700)]
AOSP: build mke2fs and e2fsdroid as static executables for recovery mode

Bug: 35219933
Change-Id: I84f105cafc57c513d83d9e4d26e9e67ef805e33e
From AOSP commit: 834180cc81c100f264d4f96a2776c51a99a810f8

6 years agoMerge branch 'maint' into next
Theodore Ts'o [Mon, 26 Feb 2018 16:13:35 +0000 (11:13 -0500)]
Merge branch 'maint' into next

6 years agodebian: fix maintainer name in changelog
Theodore Ts'o [Sun, 25 Feb 2018 04:01:51 +0000 (23:01 -0500)]
debian: fix maintainer name in changelog

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: update changelog for 1.43.9-2 release
Theodore Ts'o [Sun, 25 Feb 2018 01:48:51 +0000 (20:48 -0500)]
debian: update changelog for 1.43.9-2 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agotune2fs: if turning off csum_seed and the UUID has changed, require fsck
Theodore Ts'o [Sun, 25 Feb 2018 01:23:24 +0000 (20:23 -0500)]
tune2fs: if turning off csum_seed and the UUID has changed, require fsck

In the case where the UUID has changed and the user wants to turn off
the csum_seed feature, it's important that file system be freshly
checked.  That's also the only case when it's necessary to recalculate
all of the metadata file systems.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agotune2fs/fuse2fs/debugfs: after replaying the journal, fix up s_lastcheck
Theodore Ts'o [Sat, 24 Feb 2018 23:11:19 +0000 (18:11 -0500)]
tune2fs/fuse2fs/debugfs: after replaying the journal, fix up s_lastcheck

If the file system needs to have the journal replayed, but definition
it can't be freshly checked.  So if the time when the file system was
last checked (s_lastcheck) is before the time it was last mounted
(s_mtime), force s_lastcheck to be before s_mtime.

This is necessary to make sure some of tune2fs's safety checks work
correctly after replaying the journal, since some of tune2fs's
operations really require that the file system be self-consistent or
grave damage can result.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agotune2fs: move the journal recovery before we try to modify the superblock
Theodore Ts'o [Sat, 24 Feb 2018 23:07:44 +0000 (18:07 -0500)]
tune2fs: move the journal recovery before we try to modify the superblock

Also change the t_replay_and_set test so that we do something more
innocuous, such as setting the file system label, instead of something
much more dangerous such as removing metadata_csum feature (which
requires rewriting the metadat checksums, and this will fail
catastrophically after the test corrupts the inode bitmaps and we
perform the journal replay correctly).

Reported-by: NeilBrown <neilb@suse.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agotune2fs: don't recover journal if device is busy.
NeilBrown [Sat, 24 Feb 2018 19:56:06 +0000 (14:56 -0500)]
tune2fs: don't recover journal if device is busy.

tune2fs currently replays the journal if it needs
recovery and the filesystem isn't mounted.

The test for "is the filesystem mounted" isn't completely robust.
Lustre makes use of ext4 filesystems in a way that they are mounted
without being visible in /proc/mounts or similar.
This usage can easily be detected by attempting to open the device
with O_EXCL.  tune2fs already does this and the EXT2_MF_BUSY flag
is set if open(O_EXCL) fails.
Several uses other than lustre mounts could cause O_EXCL to fail,
but in any case it seems unwise to recover the journal when something
else is keeping the device busy.

So add an extra test to avoid journal recovery when the device
is busy.  This fixes some problems with lustre usage.

Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
6 years agolibss: add newer libreadline.so.7 to dlopen path
Lukas Czerner [Thu, 22 Feb 2018 13:25:03 +0000 (14:25 +0100)]
libss: add newer libreadline.so.7 to dlopen path

Rawhide now has libreadline.so.7. Add it to the list of libs to look
for.

Based on commit 4e79a19fe0b6dc3c2bd9cae9dfdbc5e96a3f98f8 for previous
libreadline version.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agofsck: avoid buffer overflow if user passes in an insanely long fs type
Theodore Ts'o [Fri, 23 Feb 2018 20:42:27 +0000 (15:42 -0500)]
fsck: avoid buffer overflow if user passes in an insanely long fs type

Reported-by: <Hornseth_Brenan@bah.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agolibuuid: fix UBSAN issue in get_random_fd()
Theodore Ts'o [Fri, 23 Feb 2018 20:39:46 +0000 (15:39 -0500)]
libuuid: fix UBSAN issue in get_random_fd()

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: make transitional libraries to be Arch:any and M-A:same
Theodore Ts'o [Fri, 23 Feb 2018 20:19:39 +0000 (15:19 -0500)]
debian: make transitional libraries to be Arch:any and M-A:same

Make transitional library packages be Arch: any and Multi-Arch: same
so that upgrades actually function correctly when two or more exist.

Addresses-Debian-Bug: #890590

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoMerge tag 'v1.43.9' into next
Theodore Ts'o [Fri, 9 Feb 2018 05:29:10 +0000 (00:29 -0500)]
Merge tag 'v1.43.9' into next

v1.43.9

6 years agoUpdate release notes, etc., for the 1.43.9 release v1.43.9
Theodore Ts'o [Fri, 9 Feb 2018 04:39:22 +0000 (23:39 -0500)]
Update release notes, etc., for the 1.43.9 release

This also includes some debian package renames to conform with Debian
naming conventions.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agopo: update hu.po (from translationproject.org)
Balázs Úr [Thu, 8 Feb 2018 05:08:06 +0000 (00:08 -0500)]
po: update hu.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: fix false positive lintian warning (new essential package)
Theodore Ts'o [Thu, 8 Feb 2018 04:52:54 +0000 (23:52 -0500)]
debian: fix false positive lintian warning (new essential package)

This is caused by a transition to make e2fsprogs no longer be essential.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agochattr/lsattr: update obsolete attribute support
Tyson Nottingham [Mon, 5 Feb 2018 22:45:30 +0000 (14:45 -0800)]
chattr/lsattr: update obsolete attribute support

* Remove description of and printing of h, which was never visible to
  clients of the EXT4_IOC_GETFLAGS ioctl, including chattr and lsattr.

* Remove descriptions of X and Z, whose support was removed in
  4a05268cf86f713 (Remove compression support).

* Update a brief description of E, whose meaning was changed in
  22f22ab1d2bc5ae (Reserve the codepoints for the new INCOMPAT
  feature ENCRYPT).

* Add P to symbolic mode format string.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebugfs: remove misplaced "MMP is unsupported" message
Tyson Nottingham [Wed, 24 Jan 2018 03:33:17 +0000 (19:33 -0800)]
debugfs: remove misplaced "MMP is unsupported" message

This message was inadvertently copied from the version of do_dump_mmp
that is used when CONFIG_MMP is disabled.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
6 years agodebian: Fix missing "General" in "GNU General Public License" in copyright files
Theodore Ts'o [Fri, 5 Jan 2018 22:10:16 +0000 (17:10 -0500)]
debian: Fix missing "General" in "GNU General Public License" in copyright files

This was issue was pointed out by Lintian.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: fix whitespace issue in debian/control
Theodore Ts'o [Fri, 5 Jan 2018 22:07:06 +0000 (17:07 -0500)]
debian: fix whitespace issue in debian/control

Fix a minor issue pointed out by Lintian.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoMerge branch 'maint' into next
Theodore Ts'o [Thu, 4 Jan 2018 02:38:24 +0000 (21:38 -0500)]
Merge branch 'maint' into next

6 years agodebian: remove -dbg packages from the control file
Theodore Ts'o [Thu, 4 Jan 2018 00:28:43 +0000 (19:28 -0500)]
debian: remove -dbg packages from the control file

It looks like Debian's upload automation will reject a control file
that has packages that it doesn't recognize, even if they are not
built in the default build profile.  (e.g., the expectation is that
build profiles will *disable* packages, but not *add* new binary
packages not normally built.)

So move the offending lines into debian/control.legacy-dbg which is
tacked onto the debian/control file via "./debian/rules debian-files"
and then removed via "./debian/rules mrproper".  It's a hack, but it's
only needed when building backports for Debian Jessie.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoUpdate debian changelog for 1.43.8-2 release
Theodore Ts'o [Wed, 3 Jan 2018 21:19:36 +0000 (16:19 -0500)]
Update debian changelog for 1.43.8-2 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: convert to use build profile rules exclusively
Theodore Ts'o [Wed, 3 Jan 2018 21:05:44 +0000 (16:05 -0500)]
debian: convert to use build profile rules exclusively

This commit drops support for the debian/rules.custom file, and only
relies on build profiles.

This means we no longer need to build the control file from
control.in, which simplifies this; developers can now build a debian
package immediately after checking out the tree from git.  This also
implies that we are dropping support for Debian 7 (wheezy) and Ubuntu
Trusty (14.04LTS) and older releases.  (People who want to backport to
these older distributions will have to make manual adjustments to the
debian/control and debian/rules files.)

Instead of using SKIP_E2FSCK_STATIC in debian/rules.custom, use the
new build profile: pkg.e2fsprogs.no-static-e2fsck

Support for the old-style *-dbg files used in Debian Jessie (which did
not support dbgsym packages) is completely automated.  The system will
auto-detect systems which do not support dbgsym and automatically set
the pkg.e2fsprogs.legacy-pkg build profile.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: add the build profile noudeb
Simon McVittie [Mon, 1 Jan 2018 23:24:03 +0000 (23:24 +0000)]
debian: add the build profile noudeb

This is a standard build profile.  Not building udebs speeds up test
builds if only the full-fat version is going to be tested anyway.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: add the build profile pkg.e2fsprogs.no-fuse2fs
Simon McVittie [Mon, 1 Jan 2018 23:23:36 +0000 (23:23 +0000)]
debian: add the build profile pkg.e2fsprogs.no-fuse2fs

This build profile is designed for use when bootstrapping a new Debian
architecture.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoUpdate debian changelog for 1.43.8-2 release
Theodore Ts'o [Wed, 3 Jan 2018 06:37:26 +0000 (01:37 -0500)]
Update debian changelog for 1.43.8-2 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agolibext2fs: fix build failure in swapfs.c on big-endian systems
Theodore Ts'o [Wed, 3 Jan 2018 06:32:02 +0000 (01:32 -0500)]
libext2fs: fix build failure in swapfs.c on big-endian systems

Addresses-Debian-Bug: #886119

Reported-by: James Clarke <jrtc27@debian.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: simplify rules file and don't build e2fsprogs-l10n unnecessarily
Theodore Ts'o [Wed, 3 Jan 2018 06:28:55 +0000 (01:28 -0500)]
debian: simplify rules file and don't build e2fsprogs-l10n unnecessarily

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: update standards compliance to 4.1.3
Theodore Ts'o [Wed, 3 Jan 2018 04:17:30 +0000 (23:17 -0500)]
debian: update standards compliance to 4.1.3

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: mark library packages as optional
Theodore Ts'o [Wed, 3 Jan 2018 03:17:34 +0000 (22:17 -0500)]
debian: mark library packages as optional

They will be pulled in by the binary package which is priority:
required.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoMerge branch 'maint' into next
Theodore Ts'o [Tue, 2 Jan 2018 05:53:10 +0000 (00:53 -0500)]
Merge branch 'maint' into next

6 years agoUpdate release notes, etc., for the 1.43.8 release v1.43.8
Theodore Ts'o [Tue, 2 Jan 2018 02:33:09 +0000 (21:33 -0500)]
Update release notes, etc., for the 1.43.8 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoe2fsck: fix printf format %d on ext2_ino_t
Shen-Ta Hsieh [Mon, 18 Dec 2017 15:19:52 +0000 (23:19 +0800)]
e2fsck: fix printf format %d on ext2_ino_t

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebugfs: fix printf format %d on ext2_ino_t
Shen-Ta Hsieh [Mon, 18 Dec 2017 15:18:52 +0000 (23:18 +0800)]
debugfs: fix printf format %d on ext2_ino_t

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agomisc: rename copy_file_range to copy_file_chunk
Palmer Dabbelt [Fri, 29 Dec 2017 18:19:51 +0000 (10:19 -0800)]
misc: rename copy_file_range to copy_file_chunk

As of 2.27, glibc will have a copy_file_range library call to wrap the
new copy_file_range system call.  This conflicts with the function in
misc/create_inode.c, which this patch renames _copy_file_range.

Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoUpdate translation template in preparation for e2fsprogs 1.43.8 release.
Theodore Ts'o [Tue, 2 Jan 2018 00:36:37 +0000 (19:36 -0500)]
Update translation template in preparation for e2fsprogs 1.43.8 release.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agopo: update uk.po (from translationproject.org)
Yuri Chornoivan [Tue, 2 Jan 2018 00:14:51 +0000 (19:14 -0500)]
po: update uk.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agopo: update es.po (from translationproject.org)
Antonio Ceballos [Tue, 2 Jan 2018 00:14:51 +0000 (19:14 -0500)]
po: update es.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agolibext2fs: when writing bitmaps mark the fs as dirty if necessary
Theodore Ts'o [Mon, 1 Jan 2018 23:59:16 +0000 (18:59 -0500)]
libext2fs: when writing bitmaps mark the fs as dirty if necessary

If any checksum fields are updated in the block group descriptors, we
need to set the EXT2_FLAG_DIRTY flag so that the block group
descriptors are written to disk.

Addresses-Debian-Bug: #883869

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoAdd documentation for e4crypt's add_key command in the man page
Theodore Ts'o [Mon, 1 Jan 2018 21:29:56 +0000 (16:29 -0500)]
Add documentation for e4crypt's add_key command in the man page

Correctly document that the -S option takes an argument, and describe
what arguments to the -S, -k, and -p options.

Addresses-Debian-Bug: #880483

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoFix minor typos in libext2fs documentation
Tyson Nottingham [Thu, 14 Dec 2017 07:13:13 +0000 (23:13 -0800)]
Fix minor typos in libext2fs documentation

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoAdd missing information to various man pages and usage texts
Tyson Nottingham [Thu, 14 Dec 2017 07:13:12 +0000 (23:13 -0800)]
Add missing information to various man pages and usage texts

badblocks.c: Add -B and -X to usage text.

chattr.1.in: Add P to list of settable attributes.

e2image.8.in, e2image.c: Remove superfluous mention of -r option.

e2undo.8.in, e2undo.c: Add description for -z to man page and add -o and
  -z to synopsis and usage text.

e4crypt.8.in: Add -p pad option to relevant command descriptions.

lsattr.1.in: Fix typo.

mke2fs.8.in: Add -C to synopsis. Add MKE2FS_DEVICE_PHYS_SECTSIZE
  description and update MKE2FS_DEVICE_SECTSIZE description.

mke2fs.conf.5.in: Add devices stanza summary. Remove base_features and
  default_features descriptions from defaults section, as they are
  already described in fs_types section. Move enable_periodic_fsck and
  force_undo to fs_types section, as they can be set per filesystem
  type. Add missing lazy_journal_init and hugefiles_dir descriptions.

tune2fs.8.in: Remove unsupported -p option and deprecated -s option.
  Add 64bit, ea_inode, large_dir, and metadata_csum_seed descriptions.

tune2fs.c: Remove unsupported -p option from usage text.
  Add mmp_update_interval to extended option usage text.

resize/main.c: Add -S option to usage text.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoAdd missing information to debugfs man pages and usage texts
Tyson Nottingham [Thu, 14 Dec 2017 07:13:11 +0000 (23:13 -0800)]
Add missing information to debugfs man pages and usage texts

Add descriptions for dump_unused, get_quota, list_quota,
set_current_time, show_debugfs_params, and supported_features
commands to debugfs man page. Add various missing command
arguments and correct a few typos in man page and usage texts.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoAdd missing information to e2fsck man pages and usage text
Tyson Nottingham [Thu, 14 Dec 2017 07:13:10 +0000 (23:13 -0800)]
Add missing information to e2fsck man pages and usage text

Add environment variable and defaults stanza information.
Also, update a couple of descriptions.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoAdd missing features and mount options to ext4 man page
Tyson Nottingham [Thu, 14 Dec 2017 07:13:09 +0000 (23:13 -0800)]
Add missing features and mount options to ext4 man page

Add descriptions for the metadata_csum and metadata_csum_seed
features, as well as nombcache and prjquota mount options.  Also,
update a couple of descriptions.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoAdd missing features to ext4 man page
Tyson Nottingham [Thu, 14 Dec 2017 19:55:31 +0000 (14:55 -0500)]
Add missing features to ext4 man page

Add descriptions for the ea_inode and large_dir features.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agolibext2fs: add missing swab for superblock, add checks
Andreas Dilger [Wed, 13 Dec 2017 23:47:14 +0000 (16:47 -0700)]
libext2fs: add missing swab for superblock, add checks

Several recently-added fields in struct ext2_super_block were
not being swabbed in ext2fs_swap_super(), in particular:

   s_raid_stride, s_raid_stripe_width, s_{first,last}_error_*
   s_lpf_ino, s_prj_quota_inum

Add swabbing for these missing fields.  Reorder the swabbing
on other fields so that they are in struct order, and add
comments for fields that do not need swabbing, so it is easier
to see that all fields are being handled.

Since this seems to be a fairly common occurrence, add compile
time checks to ext2fs_swap_super(), ext2fs_swap_inode_large(),
and ext2fs_swap_group_desc2() via a new EXT2FS_BUILD_BUG_ON()
macro to cause a compile warning if fields are used from these
structs without a corresponding change to the swab functions.

Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
Reported-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebugfs: fix ncheck program output
Qian Yingjin [Wed, 13 Dec 2017 15:59:39 +0000 (10:59 -0500)]
debugfs: fix ncheck program output

Fix the bug that print the inode number not the program name
when reporting bad inode name during checking in ncheck.
Minor bug fix: it should reduce iw->inodes_left when found
matched inode number.

Signed-off-by: Qian Yingjin <qian@ddn.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoMerge branch 'maint' into next
Theodore Ts'o [Wed, 13 Dec 2017 04:45:02 +0000 (23:45 -0500)]
Merge branch 'maint' into next

6 years agomisc: clean up Makefile output
Theodore Ts'o [Wed, 13 Dec 2017 04:18:27 +0000 (23:18 -0500)]
misc: clean up Makefile output

Make the Makefile's summary output to be consistent for its CC
messages.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoFix -Wunused-variable compilation warnings
Dmitry V. Levin [Wed, 13 Dec 2017 04:05:45 +0000 (23:05 -0500)]
Fix -Wunused-variable compilation warnings

Fix the following compilation warnings:

sha256.c: In function 'main':
sha256.c:238:20: warning: unused variable 'md' [-Wunused-variable]
sha512.c: In function 'main':
sha512.c:286:20: warning: unused variable 'md' [-Wunused-variable]

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoFix compilation warnings in digest_encode.c
Dmitry V. Levin [Wed, 13 Dec 2017 04:05:01 +0000 (23:05 -0500)]
Fix compilation warnings in digest_encode.c

Fix -Wpointer-sign and -Wunused-variable compilation warnings
in digest_encode.c

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoFix compilation warnings about functions declared in sys/xattr.h
Dmitry V. Levin [Thu, 18 May 2017 17:46:49 +0000 (17:46 +0000)]
Fix compilation warnings about functions declared in sys/xattr.h

attr commit v2.4.47-34-g7921157 removes <attr/xattr.h>
and syscall wrappers with the following wording:
"The xattr syscalls are provided by glibc since ages [...]
This removes the need for the <attr/xattr.h> header;
use <sys/xattr.h> instead."

Check for <sys/xattr.h> and include it to fix the following compilation
warnings:

create_inode.c: In function 'set_inode_xattr':
create_inode.c:136:9: warning: implicit declaration of function 'llistxattr' [-Wimplicit-function-declaration]
create_inode.c:172:16: warning: implicit declaration of function 'lgetxattr' [-Wimplicit-function-declaration]

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: add Multi-Arch hints to the Debian packages
Theodore Ts'o [Wed, 13 Dec 2017 03:52:26 +0000 (22:52 -0500)]
debian: add Multi-Arch hints to the Debian packages

Addresses-Debian-Bug: Bug#881408
Addresses-Debian-Bug: Bug#881590
Addresses-Debian-Bug: Bug#881591

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agodebian: add missing copyright file for the e2fsprogs-l10 package
Theodore Ts'o [Wed, 13 Dec 2017 03:25:10 +0000 (22:25 -0500)]
debian: add missing copyright file for the e2fsprogs-l10 package

Addresses-Debian-Bug: #880207

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoe2fsck: fix potential Floating Point Exception in show_stats()
Theodore Ts'o [Wed, 13 Dec 2017 02:46:36 +0000 (21:46 -0500)]
e2fsck: fix potential Floating Point Exception in show_stats()

If the free inodes count in the superblock is equal to the inodes
count in the superblock (which is not possible with a valid file
system and will be fixed by e2fsck unless it is prevented by, for
example, e2fsck -n), it is possible for e2fsck to crash due to a
divide by zero error.

Fix this potential bug.

Addresses-Debian-Bug: #879220

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoMerge branch 'maint' into next
Theodore Ts'o [Tue, 5 Dec 2017 03:24:01 +0000 (22:24 -0500)]
Merge branch 'maint' into next

6 years agoe2freefrag: print 64bit free blocks count
Kazuya Mio [Tue, 5 Dec 2017 00:15:38 +0000 (00:15 +0000)]
e2freefrag: print 64bit free blocks count

e2freefrag prints incorrect free blocks count when the number of free blocks
is larger than 2^32.
To fix this problem, e2freefrag uses ext2fs_free_blocks_count(),
not fs->super->s_free_blocks_count.

Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agoe2fsck: fix access after free for dx_db structure
Artem Blagodarenko [Sat, 4 Nov 2017 17:22:18 +0000 (20:22 +0300)]
e2fsck: fix access after free for dx_db structure

dx_db structure is freed after fixing of PR_2_HTREE_BAD_ROOT
problem. Next code block use this structure to unerstand if leaf
is beeng processed.

If dx_db is freed, then root block is being processed and if_leaf
need to be set to 0.

Signed-off-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
6 years agopo: update sr.po (from translationproject.org)
Мирослав Николић [Mon, 4 Dec 2017 00:41:43 +0000 (19:41 -0500)]
po: update sr.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
6 years agopo: update de.po (from translationproject.org)
Philipp Thomas [Mon, 4 Dec 2017 00:41:42 +0000 (19:41 -0500)]
po: update de.po (from translationproject.org)

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agoresize2fs: fix free blocks count sanity check for 64-bit file systems
Theodore Ts'o [Thu, 2 Nov 2017 13:36:37 +0000 (09:36 -0400)]
resize2fs: fix free blocks count sanity check for 64-bit file systems

The sanity check that the free blocks count is not insane could fail
with a false positive on 64-bit file systems.  Fix it.

Reported-by: Ian Astle <iastle@ott-fortimail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agoMerge branch 'maint' into next
Theodore Ts'o [Wed, 18 Oct 2017 15:32:18 +0000 (11:32 -0400)]
Merge branch 'maint' into next

7 years agoFix up additional release notes typos
Theodore Ts'o [Wed, 18 Oct 2017 15:30:44 +0000 (11:30 -0400)]
Fix up additional release notes typos

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agodebian: fix Lintian warning: not-binnmuable-all-depends-any
Theodore Ts'o [Tue, 17 Oct 2017 13:56:05 +0000 (09:56 -0400)]
debian: fix Lintian warning: not-binnmuable-all-depends-any

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agoMerge branch 'maint' into next
Theodore Ts'o [Tue, 17 Oct 2017 02:06:06 +0000 (22:06 -0400)]
Merge branch 'maint' into next

7 years agoUpdate release notes, etc., for the 1.43.7 release v1.43.7
Theodore Ts'o [Mon, 16 Oct 2017 05:45:45 +0000 (01:45 -0400)]
Update release notes, etc., for the 1.43.7 release

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agodebian: update to Debian Standards Version 4.1.1
Theodore Ts'o [Mon, 16 Oct 2017 04:53:19 +0000 (00:53 -0400)]
debian: update to Debian Standards Version 4.1.1

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agopo: update de.po (from translationproject.org)
Philipp Thomas [Mon, 16 Oct 2017 04:42:40 +0000 (00:42 -0400)]
po: update de.po (from translationproject.org)

Addresses-Debian-Bug: #833514

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agodebian: fix FTBFS regression caused by debhelper/10.9
Theodore Ts'o [Mon, 16 Oct 2017 04:38:00 +0000 (00:38 -0400)]
debian: fix FTBFS regression caused by debhelper/10.9

The problem is caused by obsolete packages referenced in the rules
file.  The latest version of debhelper is no longer forgiving about
non-existing packages being referenced in debhelper commands.

Addresses-Debian-Bug: #876551
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agolibext2fs: fix potential memory access overrun in ext2fs_inode_csum()
Theodore Ts'o [Mon, 16 Oct 2017 04:28:45 +0000 (00:28 -0400)]
libext2fs: fix potential memory access overrun in ext2fs_inode_csum()

If the superblock has a revision level of 0, then s_inode_size is
undefined, and the actual inode size is 128 bytes.  This is handled by
the EXT2_INODE_SIZE() helper macro.  If s_inode_size is maliciously
set to a large value, and the s_rev_level is 0, then this could result
in an illegal memory pointer dereference.

Addresses-Debian-Bug: #878104
Reported-by: Jakub Wilk <jwilk@jwilk.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agoFix spelling typos in contrib/android code
Theodore Ts'o [Mon, 16 Oct 2017 03:22:05 +0000 (23:22 -0400)]
Fix spelling typos in contrib/android code

These typos were found by Sebastian Rasmussen <sebras@gmail.com>

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agoMerge branch 'maint' into next
Theodore Ts'o [Mon, 16 Oct 2017 03:20:53 +0000 (23:20 -0400)]
Merge branch 'maint' into next

7 years agoFix historic typos in changelogs and release notes
Sebastian Rasmussen [Mon, 16 Oct 2017 03:18:25 +0000 (23:18 -0400)]
Fix historic typos in changelogs and release notes

Signed-off-by: Sebastian Rasmussen <sebras@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
7 years agoFix typos in code comments and developer docs
Sebastian Rasmussen [Sun, 8 Oct 2017 11:30:08 +0000 (13:30 +0200)]
Fix typos in code comments and developer docs

Signed-off-by: Sebastian Rasmussen <sebras@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
7 years agoFix typos in error messages and documentation
Sebastian Rasmussen [Sat, 14 Oct 2017 18:44:54 +0000 (20:44 +0200)]
Fix typos in error messages and documentation

Signed-off-by: Sebastian Rasmussen <sebras@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
7 years agotests: log tests that are taking a long time
Andreas Dilger [Mon, 16 Oct 2017 02:28:39 +0000 (22:28 -0400)]
tests: log tests that are taking a long time

Create a .slow file for tests that take too long to run, so it is
possible to find them easily after all of the tests have run.

Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>