Whamcloud - gitweb
tools/e2fsprogs.git
18 years agoRead in /etc/e2fsck.conf configuration file at startup
Theodore Ts'o [Sat, 31 Dec 2005 05:00:10 +0000 (00:00 -0500)]
Read in /etc/e2fsck.conf configuration file at startup

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd the profile library code to e2fsck
Theodore Ts'o [Sat, 31 Dec 2005 04:57:32 +0000 (23:57 -0500)]
Add the profile library code to e2fsck

The profile library was originally written by Theodore Ts'o in 1995
for use in the MIT Kerberos v5 library.  It has been
modified/enhanced/bug-fixed over time by other members of the MIT
Kerberos team.  This version was originally taken from the Kerberos
v5 distribution, version 1.4.2, and radically simplified for use in
e2fsprogs.  (Support for locking for multi-threaded operations,
being able to modify and update the configuration file
programmatically, and Mac/Windows portability have been removed.
It has been folded into a single C source file to make it easier to
fold into an application program.)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAvoid needlessly recompilation of library objection files
Theodore Ts'o [Fri, 30 Dec 2005 03:45:29 +0000 (22:45 -0500)]
Avoid needlessly recompilation of library objection files

Fixing the problem of parallel builds sometimes not creating the library
subdirectories caused library object files to get constantly recompiled.
Fix this by remaping how the Makefile subdirectories decide to create
the subdirectories.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoClean up gcc -Wall complaints in resize2fs
Theodore Ts'o [Thu, 29 Dec 2005 20:44:45 +0000 (15:44 -0500)]
Clean up gcc -Wall complaints in resize2fs

Remove unused variables in mark_table_blocks()

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoMake resize2fs expand or truncate a file containing a filesystem.
Theodore Ts'o [Thu, 29 Dec 2005 20:39:40 +0000 (15:39 -0500)]
Make resize2fs expand or truncate a file containing a filesystem.

(Addresses Debian Bug: #271607)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd missing parameter to error printf in blkid test program.
Theodore Ts'o [Thu, 29 Dec 2005 19:07:45 +0000 (14:07 -0500)]
Add missing parameter to error printf in blkid test program.

The blkid tag.c's test driver program had  a missing parameter to an
error message printf.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd support for lib64ext2fs-nopic.a for mips in the Debian rules file.
Theodore Ts'o [Thu, 29 Dec 2005 14:16:00 +0000 (09:16 -0500)]
Add support for lib64ext2fs-nopic.a for mips in the Debian rules file.
(Addresses Debian Bug #329074)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAutomatically fix superblock times in the future
Theodore Ts'o [Mon, 19 Dec 2005 05:02:47 +0000 (00:02 -0500)]
Automatically fix superblock times in the future

If the superblock last mount time or last write time is in the future, fix
this automatically if e2fsck is in preeen mode, since Debian's boot sequence
bogusly doesn't set the time correctly until potentially very late in the bootup
process, and this can cause false positives that will cause users' systems
to fail to booting.  (Addresses Debian Bugs #343662 and #343645)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoNewer versions of debian-buildpackage are much pickier about spacing and
Theodore Ts'o [Mon, 19 Dec 2005 04:33:15 +0000 (23:33 -0500)]
Newer versions of debian-buildpackage are much pickier about spacing and
formatting of the Debian changelog fix.  Fix very old entries that had invalid
spacing.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix typo'ed version number in Debian changelog
Theodore Ts'o [Sun, 11 Dec 2005 04:11:34 +0000 (23:11 -0500)]
Fix typo'ed version number in Debian changelog

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdded tag E2FSPROGS-1.39-WIP-1210 for changeset 502cdad9110a8f5bec2ff7842a6e90a543d49840 E2FSPROGS-1.39-WIP-1210
Theodore Ts'o [Sun, 11 Dec 2005 04:05:53 +0000 (23:05 -0500)]
Added tag E2FSPROGS-1.39-WIP-1210 for changeset 502cdad9110a8f5bec2ff7842a6e90a543d49840

18 years agoUpdate release notes for 1.39-WIP-1210 release.
Theodore Ts'o [Sun, 11 Dec 2005 04:05:30 +0000 (23:05 -0500)]
Update release notes for 1.39-WIP-1210 release.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAvoid trying to mount the root device if it is an NFS device.
Theodore Ts'o [Sun, 11 Dec 2005 03:57:05 +0000 (22:57 -0500)]
Avoid trying to mount the root device if it is an NFS device.

Addresses Debian Bug #310428

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd resize2fs and badblocks to the e2fsprogs udeb
Theodore Ts'o [Sun, 11 Dec 2005 03:56:21 +0000 (22:56 -0500)]
Add resize2fs and badblocks to the e2fsprogs udeb

Addresses Debian Bugs #290429 and #310950

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoUse $(LDFLAGS) when generating shared libraries
Theodore Ts'o [Sun, 11 Dec 2005 03:33:25 +0000 (22:33 -0500)]
Use $(LDFLAGS)  when generating shared libraries

Makefile.elf-lib, Makefile.solaris-lib: Add $(LDFLAGS) to the command line
argument when generating the shared library, to allow cross-compile
and other builds that might need to specify -L paths to needed
libraries.

Addresses Sourceforge Bug #1261549

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAddress parallel build problem in the library Makefiles
Theodore Ts'o [Sun, 11 Dec 2005 03:23:01 +0000 (22:23 -0500)]
Address parallel build problem in the library Makefiles

Add a dependency to make sure that the subdirectories are created before
creating all of the object files.

Addresses Sourceforge Bug: #1261553

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix various gcc -Wall complaints.
Theodore Ts'o [Sun, 11 Dec 2005 02:50:30 +0000 (21:50 -0500)]
Fix various gcc -Wall complaints.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd ext2fs_read_bb_FILE test to confirm proper detection of invalid block #'s
Theodore Ts'o [Sat, 10 Dec 2005 19:37:10 +0000 (14:37 -0500)]
Add ext2fs_read_bb_FILE test to confirm proper detection of invalid block #'s

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoUpdate release notes.
Theodore Ts'o [Sat, 10 Dec 2005 00:20:01 +0000 (19:20 -0500)]
Update release notes.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix bogus spaces before '!' and '?' characters in unused programs.
Theodore Ts'o [Sat, 10 Dec 2005 00:16:40 +0000 (19:16 -0500)]
Fix bogus spaces before '!' and '?' characters in unused programs.

On Mon, Oct 31, 2005 at 01:23:53PM +0000, Martin Michlmayr wrote:
> Package: e2fsprogs
> Version: 1.38-2
> Severity: minor
>
> e2fsprogs isn't consistent in its use of spaces before an exclamation
> mark.  The patch below fixed this by removing some spaces.
> (Interestingly, I couldn't find the error message in the sources where
> I noticed this inconsistency, namely "group descriptors corrupted !").

Patch applied, but none of the source files you touched are actually
compiled in e2fsprogs, and most of them weren't written by me.  :-)

Addresses Debian Bug #336604

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd more description in mke2fs's man page of the -T option
Theodore Ts'o [Fri, 9 Dec 2005 23:42:30 +0000 (18:42 -0500)]
Add more description in mke2fs's man page of the -T option

Addresses Debian Bug #316811

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoUpdate the Dutch translation file.
Theodore Ts'o [Fri, 9 Dec 2005 23:18:28 +0000 (18:18 -0500)]
Update the Dutch translation file.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoClarify the e2fsck man page regarding the -c option
Theodore Ts'o [Fri, 9 Dec 2005 23:18:06 +0000 (18:18 -0500)]
Clarify the e2fsck man page regarding the -c option

A user was confused about whether or not e2fsck -c performed a destructive
test on the filesystem, since it stated that -cc resulted in a non-destructive
read/write test.   Clarify that -c does a read/only test.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoMake e2fsck -cc warn on a read-only root filesystem
Theodore Ts'o [Fri, 9 Dec 2005 23:11:16 +0000 (18:11 -0500)]
Make e2fsck -cc warn on a read-only root filesystem

Don't let the user run e2fsck -ccn on the root partition, without warning
that he or she might be doing something Really Stupid.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix typo in e2fsck error message.
Theodore Ts'o [Fri, 9 Dec 2005 22:31:08 +0000 (17:31 -0500)]
Fix typo in e2fsck error message.

Thanks to Solar Designer for pointing out the missing preposition.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoClarify description of the -p, -n, and -y options in the e2fsck man page.
Theodore Ts'o [Fri, 9 Dec 2005 22:28:56 +0000 (17:28 -0500)]
Clarify description of the -p, -n, and -y options in the e2fsck man page.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix gcc compilation on sparc architectures in bitops.h
Theodore Ts'o [Mon, 21 Nov 2005 05:04:31 +0000 (00:04 -0500)]
Fix gcc compilation on sparc architectures in bitops.h

We no longer have the sparc assembly code in the header file any more, so we
shouldn't set _EXT2_HAVE_AS_BITOPS_.  This would break compiles on the sparc
architectures when using gcc.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd missing #include for string.h to ext2fs.h to fix GCC 4.01 complaints
Theodore Ts'o [Mon, 14 Nov 2005 19:49:15 +0000 (14:49 -0500)]
Add missing #include for string.h to ext2fs.h to fix GCC 4.01 complaints

#include <string.h> is needed since the inline functions use memcpy().
(Addresses Sourceforge Bug #1251062)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd missing fsck.* programs to SEE ALSO section of fsck's man page.
Theodore Ts'o [Sun, 13 Nov 2005 04:41:08 +0000 (23:41 -0500)]
Add missing fsck.* programs to SEE ALSO section of fsck's man page.

fsck.8.in: Add additional fsck.* programs to the SEE ALSO section.
Fix missing commas in list.  (Addresses Debian Bug #329859)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix writing external journals on big-endian machines
Theodore Ts'o [Sun, 13 Nov 2005 04:30:39 +0000 (23:30 -0500)]
Fix writing external journals on big-endian machines

Fix a bug when writing an external journal device on an big
endian machine (such as a S/390), where when the number of
block groups is zero, we never end up writing out the
primary superblock at all.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix cross-compilation problems when CFLAGS contain target-specific options
Theodore Ts'o [Wed, 9 Nov 2005 22:37:07 +0000 (18:37 -0400)]
Fix cross-compilation problems when CFLAGS contain target-specific options

Use BUILD_CCFLAGS and BUILD_LDFLAGS instead of CCFLAGS and LDFLAGS in
the build system when building files in the util directory which are
needed during the build process.  This avoids potential problems when
cross-compiling some of the options are not recognized as valid by the
host compiler.  (Addresses Sourceforge Bug #1261547)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoE2fsck: fix future times in the superblock's last mount or last write fields
Theodore Ts'o [Sun, 25 Sep 2005 01:59:45 +0000 (21:59 -0400)]
E2fsck: fix future times in the superblock's last mount or last write fields

Detect if the superblock's last mount field or last write field is in
the future, and offer to fix if so.  (Addresses Debian Bug #327580)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoNew debugfs command: set_current_time
Theodore Ts'o [Sun, 25 Sep 2005 01:56:38 +0000 (21:56 -0400)]
New debugfs command: set_current_time

Generalize the time parsing code and move it to
util.c:string_to_time().  Add new command, set_current_time, which
sets the time used to set the filesystems's time fields.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd fs->now to override time(0) in libext2fs
Theodore Ts'o [Sun, 25 Sep 2005 00:14:51 +0000 (20:14 -0400)]
Add fs->now to override time(0) in libext2fs

If fs->now is non-zero, use that as the time instead of the system
time when setting various filesystem fields (last modified time, last
write time, etc.)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix mke2fs man page's description of the -L option
Theodore Ts'o [Sat, 24 Sep 2005 22:47:39 +0000 (18:47 -0400)]
Fix mke2fs man page's description of the -L option

Fix mke2fs man page to properly document the fact that mke2fs -L takes
an argument.  (Addresses Debian Bug #322188)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix display bug in badblocks -w
Theodore Ts'o [Sat, 24 Sep 2005 22:28:00 +0000 (18:28 -0400)]
Fix display bug in badblocks -w

Add extra spaces when printing the "done" message to clear out the
block number to fix a display corruption when the -s option is used to
display the progress of the test.  (Addresses Debian Bug #322231)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoSearch the root directory of FAT filesystems for the label information
Theodore Ts'o [Sun, 11 Sep 2005 01:51:20 +0000 (21:51 -0400)]
Search the root directory of FAT filesystems for the label information

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoGeneric blkid library cleanup
Theodore Ts'o [Sun, 11 Sep 2005 01:07:23 +0000 (21:07 -0400)]
Generic blkid library cleanup

Change superblock and generic i/o functions to be more generic.  Clean
up interface to the probe function.  Fix memory leak.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd a regression test suite for the blkid library
Theodore Ts'o [Sat, 10 Sep 2005 19:55:14 +0000 (15:55 -0400)]
Add a regression test suite for the blkid library

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd support to extract basic iso9660 label information to the blkid library
Theodore Ts'o [Sat, 10 Sep 2005 19:46:57 +0000 (15:46 -0400)]
Add support to extract basic iso9660 label information to the blkid library

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd support for detecting the reiser4 filesystem in the blkid library.
Theodore Ts'o [Sat, 10 Sep 2005 15:48:38 +0000 (11:48 -0400)]
Add support for detecting the reiser4 filesystem in the blkid library.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoImprove blkid's VFAT/FAT filesystem probe code
Theodore Ts'o [Wed, 7 Sep 2005 16:14:53 +0000 (12:14 -0400)]
Improve blkid's VFAT/FAT filesystem probe code

Collapse vfat and fat code and make it more paranoid when probing for
vat/fat filesystems.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoRemove unneeded probe.h header file in lib/blkid/resolve.c
Theodore Ts'o [Wed, 7 Sep 2005 16:12:21 +0000 (12:12 -0400)]
Remove unneeded probe.h header file in lib/blkid/resolve.c

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoImprove VFAT detection to support filesystems w/o a magic string in the superblock
Karel Zak [Tue, 6 Sep 2005 12:13:35 +0000 (08:13 -0400)]
Improve VFAT detection to support filesystems w/o a magic string in the superblock

The current libblkid code expects that there's magic string in FAT super
block (like "FAT12", "FAT16", ...). It's very often right, but valid FAT
super block may be without magic string too :-(

The patch from attachment fix this problem. It's inspired by HAL and
Linux kernel.

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoAdd support for detecting software suspend partitions to blkid
Karel Zak [Tue, 6 Sep 2005 10:42:49 +0000 (06:42 -0400)]
Add support for detecting software suspend partitions to blkid

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix blkid library so that the cache validation notices ext2 to ext3 conversion
Karel Zak [Tue, 6 Sep 2005 10:26:45 +0000 (06:26 -0400)]
Fix blkid library so that the cache validation notices ext2 to ext3 conversion

There's mistake in blkid ext2 detection code. The libblkid doesn't
check for journal when revalidate the cache information about an ext2
device.

        # rm -f /etc/blkid.tab

        # mkfs.ext2 /dev/loop0 &> /dev/null
        # blkid -s TYPE /dev/loop0
        /dev/loop0: TYPE="ext2"

        # mkfs.ext3 /dev/loop0 &> /dev/null
        # blkid -s TYPE /dev/loop0
        /dev/loop0: TYPE="ext2"

That bug doesn't appear when libblkid creates new cache and checks for
all possible filesystems, because it tries ext3 before ext2. BUT when
the library only revalidate the cache it first probes for old cached
filesystem (e.g. ext2).

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix compiler warnings about missing memcpy prototypes.
Matthias Andree [Tue, 6 Sep 2005 09:59:52 +0000 (05:59 -0400)]
Fix compiler warnings about missing memcpy prototypes.

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix debugfs's set_inode_field so it can properly set i_size
Theodore Ts'o [Tue, 6 Sep 2005 09:42:44 +0000 (05:42 -0400)]
Fix debugfs's set_inode_field so it can properly set i_size

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoUpdate Debian changelog for 1.38-2 release.
Theodore Ts'o [Mon, 22 Aug 2005 05:20:23 +0000 (01:20 -0400)]
Update Debian changelog for 1.38-2 release.

18 years agoAdd valgrind support to the regression test suite
Theodore Ts'o [Tue, 9 Aug 2005 00:29:15 +0000 (19:29 -0500)]
Add valgrind support to the regression test suite

Add the --valgrind option to the tests/test_script which allows us to
run the e2fsprogs regression test suite under valgrind.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix fencepost error in resize2fs caught by valgrind
Theodore Ts'o [Mon, 8 Aug 2005 23:57:04 +0000 (18:57 -0500)]
Fix fencepost error in resize2fs caught by valgrind

There was a off-by-one fencepost error in the logic used to check if
we avoid copying zero-filled blocks when moving an inode table down by
a block or two.  Thanks to valgrind for catching it.  As far as I know
this fencepost error wasn't causing any actual problems, but it was
definitely a bug.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix use-after-free bug of e2fsck context structure.
Theodore Ts'o [Mon, 25 Jul 2005 16:36:43 +0000 (11:36 -0500)]
Fix use-after-free bug of e2fsck context structure.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix false positives from valgrind: memcpy via no-op structure copy
Theodore Ts'o [Mon, 25 Jul 2005 16:36:43 +0000 (11:36 -0500)]
Fix false positives from valgrind: memcpy via no-op structure copy

Don't do a structure copy via an assignment in e2fsck's pass #1 when
it is a no-op in order to avoid false positives from valgrind.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix false positives from valgrind: prctl(PR_GET_DUMPABLE)
Theodore Ts'o [Mon, 25 Jul 2005 16:36:43 +0000 (11:36 -0500)]
Fix false positives from valgrind: prctl(PR_GET_DUMPABLE)

Pass in zero to the unusued arguments of prctl(PR_GET_DUMPABLE) to
avoid false positives from valgrind.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoFix Debian build rules to reflect changes in texi2html (Debian Bug #317862)
Theodore Ts'o [Fri, 22 Jul 2005 00:32:36 +0000 (19:32 -0500)]
Fix Debian build rules to reflect changes in texi2html (Debian Bug #317862)

Texi2html's behavior changed recently: if it is invoked with
-split=chapter, old versions place the HTML files in the same
directory as the documentation source, whereas new versions place the
generated files in a subdirectory.

Reported by Matt Kraai.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoCheck for a busy device when creating a journal.
Theodore Ts'o [Tue, 19 Jul 2005 20:04:22 +0000 (15:04 -0500)]
Check for a busy device when creating a journal.

In ext2fs_add_journal_inode() check for the case where the filesystem
appears to be unmounted, but the device is still apparently busy.
This can happen when the luser doesn't bother to mount /proc and has a
bogus /etc/mtab, but still wants to mount the filesystem before using
tune2fs(?!?).  Add a safety check to save him from his own stupidity,
at least on 2.6 kernels.  (Addresses Debian Bug #319002)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoMake the helper scripts in the config directory executable.
Theodore Ts'o [Tue, 19 Jul 2005 19:30:48 +0000 (14:30 -0500)]
Make the helper scripts in the config directory executable.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoChange gen_tarball to ignore Mercurial/quilt files (and remove BK ignores).
Theodore Ts'o [Tue, 19 Jul 2005 18:21:34 +0000 (13:21 -0500)]
Change gen_tarball to ignore Mercurial/quilt files (and remove BK ignores).

Since e2fsprogs is now being managed by Mercurial instead of BK,
remove BitKeeper and add ".hg", ".hgignore", ".pc", and "patches" to
the list of files/directories not included in the tar file.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoIgnore quilt work files
Theodore Ts'o [Tue, 19 Jul 2005 13:41:27 +0000 (08:41 -0500)]
Ignore quilt work files

Add .pc and patches to the .hgignore file.

18 years agoFix com_err bug in compile_et: # of error messages can be wrong
Theodore Ts'o [Tue, 19 Jul 2005 13:24:59 +0000 (08:24 -0500)]
Fix com_err bug in compile_et: # of error messages can be wrong

Fixed bug where error messages using continuations wouldn't increment
the message count.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoThis patch adds a check to use fstat or fstat64 in getsize.c if the
Andreas Dilger [Sun, 10 Jul 2005 03:06:59 +0000 (22:06 -0500)]
This patch adds a check to use fstat or fstat64 in getsize.c if the
target is a regular file, instead of doing binary searching.  It also
fixes a couple of cases where a file descriptor is leaked in the
ext2fs_getsize() routine on error.

Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
18 years agoMiscellaneous mke2fs cleanup
Andreas Dilger [Wed, 6 Jul 2005 17:58:15 +0000 (12:58 -0500)]
Miscellaneous mke2fs cleanup

Reorder some mke2fs arg parsing to be more alphabetical, and remove
use of atoi() (which doesn't report errors) in favour of strtoul().

Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
18 years agoAllow fractional percentages to the -m option in mke2fs and tune2fs
Andreas Dilger [Wed, 6 Jul 2005 16:50:08 +0000 (11:50 -0500)]
Allow fractional percentages to the -m option in mke2fs and tune2fs

Allow the reserved blocks ratio to be specified in fractional
percentages.

Addresses-Debian-Bug: #80205
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
18 years agoAdded SUBMITTING-PATCHES file
Theodore Ts'o [Wed, 6 Jul 2005 03:30:13 +0000 (22:30 -0500)]
Added SUBMITTING-PATCHES file

This file descripts the signed-off-by procedure first used by Linus
for the Linux kernel patch submissions, and which will now be used for
e2fsprogs as well.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
18 years agoSet the executible bit on the configure script.
Theodore Ts'o [Wed, 6 Jul 2005 03:14:20 +0000 (22:14 -0500)]
Set the executible bit on the configure script.

18 years agoMake e2fsck Pass 1C header consistent with the other headers
Theodore Ts'o [Mon, 4 Jul 2005 18:08:37 +0000 (13:08 -0500)]
Make e2fsck Pass 1C header consistent with the other headers

Removed the period from the Pass 1C header to make it consistent with
the other e2fsck pass headers.

18 years agoAdd missing changelog file for previous commit (hg changeset: 0502b63a5be9)
Theodore Ts'o [Mon, 4 Jul 2005 18:04:05 +0000 (13:04 -0500)]
Add missing changelog file for previous commit (hg changeset: 0502b63a5be9)

18 years ago[BUGFIX]: E2fsck will segfault on disconnected inode with extended attribute(s)
Theodore Ts'o [Mon, 4 Jul 2005 17:53:36 +0000 (12:53 -0500)]
[BUGFIX]: E2fsck will segfault on disconnected inode with extended attribute(s)

This was actually caused by two bugs.  The first bug is that if the
inode has been fully fixed up, the code will attempt to remove the
inode from the inode_bad_map without checking to see if this bitmap is
present.  Since it is cleared at the end of pass 2, if
e2fsck_process_bad_inode is called in pass 4 (as it is for
disconnected inodes), this would result in a core dump.

The first bug was mostly hidden by a second bug, which caused
e2fsck_process_bad_inode() to consider all inodes without an extended
attribute to be not fixed.

Note: This bug was introduced in e2fsprogs 1.36.

(Addresses Debian Bug: #316736)

18 years agoFix debugfs's set_inode_fields command from silently failing.
Theodore Ts'o [Mon, 4 Jul 2005 17:24:40 +0000 (12:24 -0500)]
Fix debugfs's set_inode_fields command from silently failing.

The set_inodes_field command was silently failing when setting one of
the following fields: frag, fsize, uid_high, gid_high, and author.
The type size for these fields were set to an incorrect value in the
inode_fields table.

18 years agoFix typo in RELEASE-NOTES (wrong date, extra comment)
Theodore Ts'o [Fri, 1 Jul 2005 22:31:55 +0000 (17:31 -0500)]
Fix typo in RELEASE-NOTES (wrong date, extra comment)

18 years agoCreate .hgignore file
Theodore Ts'o [Fri, 1 Jul 2005 22:30:58 +0000 (17:30 -0500)]
Create .hgignore file

18 years agoADD TAG: E2FSPROGS-1_38 E2FSPROGS-1_38
Theodore Ts'o [Fri, 1 Jul 2005 00:06:45 +0000 (20:06 -0400)]
ADD TAG: E2FSPROGS-1_38

18 years agoUpdate for e2fsprogs 1.38 release.
Theodore Ts'o [Fri, 1 Jul 2005 00:06:45 +0000 (20:06 -0400)]
Update for e2fsprogs 1.38 release.

18 years agoChange mke2fs to refuse to create filesystems greater than 2*31-1 blocks,
Theodore Ts'o [Fri, 1 Jul 2005 00:00:41 +0000 (20:00 -0400)]
Change mke2fs to refuse to create filesystems greater than 2*31-1 blocks,
at least unless forced.

18 years agoChange the function prototypes of ext2fs_set_bit, ext2fs_clear_bit, and
Theodore Ts'o [Thu, 30 Jun 2005 23:40:18 +0000 (19:40 -0400)]
Change the function prototypes of ext2fs_set_bit, ext2fs_clear_bit, and
ext2fs_test_bit to take an unsigned int for the bit number.  Negative
bit numbers were never allowed (and didn't make any sense), so this should
be a safe change.  This is needed to allow safe use of block numbers
greater than or equal to 2**31.

18 years agoFix blkid's debugging/TEST_PROGRAM code so that it is sufficiently
Theodore Ts'o [Mon, 27 Jun 2005 17:54:08 +0000 (13:54 -0400)]
Fix blkid's debugging/TEST_PROGRAM code so that it is sufficiently
standalone that "make check" will compile without errors even
when configure "--enable-blkid-debug" is not specified.

18 years agoext2fs_resize_mem() is suffering from C99 strict type aliasing problems.
Stephen Tweedie [Mon, 27 Jun 2005 15:47:21 +0000 (11:47 -0400)]
ext2fs_resize_mem() is suffering from C99 strict type aliasing problems.
The trouble is that it is modifying pointers in place, but doing so via
"void *" types which alias the pointers passed in (which are typically
pointers to a struct.)  The inline ext2fs_resize_mem() code may update
the pointer, but the caller is not required to reload the old value it
may have cached in a register, according to the type aliasing rules.

This is causing the caller to dereference the old pointer when compiled
with -O2, resulting in reproducible SEGV, on at least one ia64
configuration.

The compiler *is* required to reload if it sees an update to a dereferenced
char value, though, as chars are defined to alias anything; and memcpy()
is defined to operate on chars.  So using memcpy() to copy the pointer
values is guaranteed to force the caller to reload.  This has been
verified to fix the problem in practice.

Fixes Red Hat bug #161183.

18 years agoFix minor typos in tune2fs's man page pointed out by Benno Schulenberg.
Theodore Ts'o [Mon, 27 Jun 2005 02:16:21 +0000 (22:16 -0400)]
Fix minor typos in tune2fs's man page pointed out by Benno Schulenberg.

18 years agoUpdate typos in changelog
Theodore Ts'o [Mon, 27 Jun 2005 02:12:40 +0000 (22:12 -0400)]
Update typos in changelog

18 years agoUpdate French, Dutch, Polish, Swedish, and Turkish translations.
Theodore Ts'o [Mon, 27 Jun 2005 02:11:46 +0000 (22:11 -0400)]
Update French, Dutch, Polish, Swedish, and Turkish translations.

18 years agoADD TAG: E2FSPROGS-1_38-WIP-0620 E2FSPROGS-1_38-WIP-0620
Theodore Ts'o [Mon, 20 Jun 2005 22:00:55 +0000 (18:00 -0400)]
ADD TAG: E2FSPROGS-1_38-WIP-0620

18 years agoUpdate for e2fsprogs 1.38-WIP-0620 release.
Theodore Ts'o [Mon, 20 Jun 2005 22:00:55 +0000 (18:00 -0400)]
Update for e2fsprogs 1.38-WIP-0620 release.

18 years agoUpdate po files before WIP release.
Theodore Ts'o [Mon, 20 Jun 2005 22:00:23 +0000 (18:00 -0400)]
Update po files before WIP release.

18 years agoerror_message.c, init_et.c: Segregate error tables registered
Theodore Ts'o [Mon, 20 Jun 2005 21:59:06 +0000 (17:59 -0400)]
error_message.c, init_et.c: Segregate error tables registered
via add_error_table() and the other dynamic methods from
the ones allocated via initialize_xxx_error_table() so
that we won't fail even for error tables created using old
versions of compile_et.  Thanks to Nalin Dahyabhai for
this suggested patch.

18 years agoet_c.awk: Use a dynamically allocated structure in
Theodore Ts'o [Mon, 20 Jun 2005 20:24:04 +0000 (16:24 -0400)]
et_c.awk: Use a dynamically allocated structure in
initialize_xxx_error_table(), to prevent segfaults if an
old library calls initialize_xxx_error_table, and another
library/application calls add_error_table() on the same
error table, and then calls remove_error_table().
(Addresses Sourcefroge Bug #1150146)

18 years agoFix e2fsprogs messages for grammar and consistency, based on suggestions
Theodore Ts'o [Mon, 20 Jun 2005 12:35:27 +0000 (08:35 -0400)]
Fix e2fsprogs messages for grammar and consistency, based on suggestions
from Benno Schulenberg.

Add missing _() so all strings can be internationalized.

18 years agoClean up e2image man page, mostly based on suggestions from
Theodore Ts'o [Mon, 20 Jun 2005 12:26:50 +0000 (08:26 -0400)]
Clean up e2image man page, mostly based on suggestions from
Benno Schulenberg.

18 years agoMake it easier to compile the misc/partinfo program
Theodore Ts'o [Mon, 20 Jun 2005 12:25:31 +0000 (08:25 -0400)]
Make it easier to compile the misc/partinfo program
for testing purposes only)

18 years agoFix minor typo introduced in e2fsck man page.
Theodore Ts'o [Mon, 20 Jun 2005 12:24:28 +0000 (08:24 -0400)]
Fix minor typo introduced in e2fsck man page.

18 years agoRemove the findsuper and partinfo programs from the list of C files to be
Theodore Ts'o [Mon, 20 Jun 2005 12:23:55 +0000 (08:23 -0400)]
Remove the findsuper and partinfo programs from the list of C files to be
internationalized, as they are not installed by default (nor should they be).

18 years agogetsectsize.c (BLKSSZGET): Clean up test for when to manually
Theodore Ts'o [Mon, 20 Jun 2005 03:11:09 +0000 (23:11 -0400)]
getsectsize.c (BLKSSZGET): Clean up test for when to manually
define the BLKSSZGET ioctl.

18 years agoMake the e2fsck man page clear that the -c, -l, and -L options are
Theodore Ts'o [Mon, 20 Jun 2005 01:04:12 +0000 (21:04 -0400)]
Make the e2fsck man page clear that the -c, -l, and -L options are
never safe to use on a mounted filesystem, and in general, running
e2fsck on mounted filesystems is a bad idea.

18 years agoClean up e2fsck problem description messages for typo's and to make them
Theodore Ts'o [Sun, 19 Jun 2005 13:45:36 +0000 (09:45 -0400)]
Clean up e2fsck problem description messages for typo's and to make them
easier to understand (sorry, translators).

Add new @m (multiply-claimed) and @n (invalid) expansions for e2fsck
problem descriptions.

Add Dutch translation, and update French translation.

Add an explanation of how the @-expansion and %-exapansion works in
e2fsck/problem.c to make life easier for the translators.

Synchronize and update po files.

18 years agoMakefile.in: Add an include path specifier when building
Theodore Ts'o [Thu, 16 Jun 2005 22:41:06 +0000 (18:41 -0400)]
Makefile.in: Add an include path specifier when building
tst_ostype so that "make check" will build correctly on
systems without the include files from e2fsprogs installed
in the system include directory.

18 years agodefaults/e_script, run_e2fsck, d_loaddump, f_resize_inode,
Theodore Ts'o [Thu, 16 Jun 2005 19:08:00 +0000 (15:08 -0400)]
defaults/e_script, run_e2fsck, d_loaddump, f_resize_inode,
f_swapfs, f_move_itable, f_resize_inode, test_config:
Allow the diff options to be set in test_config so that
diff -u can be used on platforms that have it.  (To be
done: checking whether diff can support -u in the
configure script.)

18 years agomke2fs.c (PRS): Fix missing close parenthesis from bad inode
Theodore Ts'o [Thu, 16 Jun 2005 18:10:55 +0000 (14:10 -0400)]
mke2fs.c (PRS): Fix missing close parenthesis from bad inode
ratio error message.

19 years agoFix a minor spelling typo in blkid's man page, and update e2fsck's REPORTING
Theodore Ts'o [Sun, 5 Jun 2005 20:46:19 +0000 (16:46 -0400)]
Fix a minor spelling typo in blkid's man page, and update e2fsck's REPORTING
BUGS section to request that e2fsck's messages printed in English, and to
send a raw e2image filesystem dump if possible.

19 years agoUpdate release notes and changelogs for the correct spelling of "Swedish".
Theodore Ts'o [Sun, 5 Jun 2005 20:42:20 +0000 (16:42 -0400)]
Update release notes and changelogs for the correct spelling of "Swedish".

19 years agoOn Linux 2.6 systems, mke2fs and badblocks will check to see whether
Theodore Ts'o [Sun, 5 Jun 2005 20:05:22 +0000 (16:05 -0400)]
On Linux 2.6 systems, mke2fs and badblocks will check to see whether
the filesystem appears to be busy; if so, the programs will print an
error message and abort.   (Addresses Debian Bug #308594).

19 years agofilefrag.c (frag_report, get_bmap): The FIBMAP and FIGETBSZ ioctls return
Theodore Ts'o [Sat, 21 May 2005 03:10:35 +0000 (23:10 -0400)]
filefrag.c (frag_report, get_bmap): The FIBMAP and FIGETBSZ ioctls return
an integer, not an unsigned long.  Fix this to avoid problems on 64-bit
platforms where the size of an integer != the size of a long.
(Addresses Debian Bug #309655)