libquota: add error checking to quota_remove_inode

Addresses-Coverity-Id: #709475

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

diff --git a/lib/quota/mkquota.c b/lib/quota/mkquota.c
index b920f27..9883216 100644 (file)
--- a/lib/quota/mkquota.c
+++ b/lib/quota/mkquota.c
@@ -89,8 +89,13 @@ void quota_set_sb_inum(ext2_filsys fs, ext2_ino_t ino, int qtype)
 errcode_t quota_remove_inode(ext2_filsys fs, int qtype)
 {
        ext2_ino_t qf_ino;
+       errcode_t       retval;
 
-       ext2fs_read_bitmaps(fs);
+       retval = ext2fs_read_bitmaps(fs);
+       if (retval) {
+               log_err("Couldn't read bitmaps: %s", error_message(retval));
+               return retval;
+       }
        qf_ino = (qtype == USRQUOTA) ? fs->super->s_usr_quota_inum :
                fs->super->s_grp_quota_inum;
        quota_set_sb_inum(fs, 0, qtype);
@@ -100,7 +105,11 @@ errcode_t quota_remove_inode(ext2_filsys fs, int qtype)
 
        ext2fs_mark_super_dirty(fs);
        fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
-       ext2fs_write_bitmaps(fs);
+       retval = ext2fs_write_bitmaps(fs);
+       if (retval) {
+               log_err("Couldn't write bitmaps: %s", error_message(retval));
+               return retval;
+       }
        return 0;
 }