Whamcloud - gitweb
e2fsck: remove dead code when recreating the journal
authorTheodore Ts'o <tytso@mit.edu>
Thu, 21 Jan 2021 21:51:45 +0000 (16:51 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 21 Jan 2021 21:51:45 +0000 (16:51 -0500)
params.num_journal_blocks is an unsigned value so it can never be less
than zero.

Addresses-Coverity-Bug: 1472250
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
e2fsck/unix.c

index 2d2a304..84224c1 100644 (file)
@@ -1924,13 +1924,6 @@ print_unsupp_features:
                                jparams.num_journal_blocks = journal_size;
                                jparams.num_fc_blocks = 0;
                        }
-                       if (jparams.num_journal_blocks < 0) {
-                               ext2fs_clear_feature_journal(fs->super);
-                               fs->flags &= ~EXT2_FLAG_MASTER_SB_ONLY;
-                               log_out(ctx, "%s: Couldn't determine "
-                                       "journal size\n", ctx->program_name);
-                               goto no_journal;
-                       }
                        log_out(ctx, _("Creating journal (%d blocks): "),
                               jparams.num_journal_blocks);
                        fflush(stdout);