Whamcloud - gitweb
mke2fs: check extents feature when bigalloc feature is enabled
authorZheng Liu <wenqing.lz@taobao.com>
Sun, 6 Jan 2013 12:25:17 +0000 (20:25 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 8 Jan 2013 15:35:45 +0000 (10:35 -0500)
When bigalloc feature is enabled in mkfs, extents feature also needs
to be enabled.  But now when bigalloc feature is enabled without
extents feature, users will not get any warning messages until they
try to mount this file system.

Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
misc/mke2fs.c

index df9c1c1..32b4c34 100644 (file)
@@ -1921,6 +1921,15 @@ profile_error:
        if (extended_opts)
                parse_extended_opts(&fs_param, extended_opts);
 
+       /* Can't support bigalloc feature without extents feature */
+       if ((fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) &&
+           !(fs_param.s_feature_incompat & EXT3_FEATURE_INCOMPAT_EXTENTS)) {
+               com_err(program_name, 0,
+                       _("Can't support bigalloc feature without "
+                         "extents feature"));
+               exit(1);
+       }
+
        /* Since sparse_super is the default, we would only have a problem
         * here if it was explicitly disabled.
         */