Need to close old_f before returning since it had been successfully opened
before.
Coverity ID: 19: Resource Leak
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
+2007-03-21 Theodore Tso <tytso@mit.edu>
+
+ * subst.c (compare_file): Close old FILE handle if the new FILE
+ handle open failed.
+
2006-11-12 Theodore Tso <tytso@mit.edu>
* gen-tarball.in: Use E2FSPROGS_PKGVER to simplify script
if (!old_f)
return 0;
new_f = fopen(newfn, "r");
- if (!new_f)
+ if (!new_f) {
+ fclose(old_f);
return 0;
+ }
while (1) {
oldcp = fgets(oldbuf, sizeof(oldbuf), old_f);