Whamcloud - gitweb
libext2fs: fix potential memory leak in qcow2_write_raw_image()
authorTheodore Ts'o <tytso@google.com>
Sun, 5 Jan 2014 06:12:49 +0000 (01:12 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 6 Jan 2014 03:58:16 +0000 (22:58 -0500)
Addresses-Coverity-ID: #1049179
Addresses-Coverity-ID: #1049180

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
lib/ext2fs/qcow2.c

index 547edc0..c7cdbee 100644 (file)
@@ -235,8 +235,10 @@ int qcow2_write_raw_image(int qcow2_fd, int raw_fd,
        }
 
        /* Resize the output image to the filesystem size */
-       if (ext2fs_llseek(raw_fd, img.image_size - 1, SEEK_SET) < 0)
-               return errno;
+       if (ext2fs_llseek(raw_fd, img.image_size - 1, SEEK_SET) < 0) {
+               ret = errno;
+               goto out;
+       }
 
        ((char *)copy_buf)[0] = 0;
        size = write(raw_fd, copy_buf, 1);