mke2fs: warn that bigalloc is experimental only for large cluster sizes

Since we have done a lot of testing with a cluster size equal to 64k
(or 16 times the default 4k block size), mke2fs will only warn for
bigalloc file systems where the cluster size is greater than 16 times
the block size.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index a457397..effe963 100644 (file)
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -2526,11 +2526,12 @@ profile_error:
                exit(1);
        }
 
-       if (!quiet && ext2fs_has_feature_bigalloc(&fs_param))
-               fprintf(stderr, "%s", _("\nWarning: the bigalloc feature is "
-                                 "still under development\n"
-                                 "See https://ext4.wiki.kernel.org/"
-                                 "index.php/Bigalloc for more information\n\n"));
+       if (!quiet && ext2fs_has_feature_bigalloc(&fs_param) &&
+           EXT2_CLUSTER_SIZE(&fs_param) > 16 * EXT2_BLOCK_SIZE(&fs_param))
+               fprintf(stderr, "%s", _("\nWarning: bigalloc file systems "
+                               "with a cluster size greater than\n"
+                               "16 times the block size is considered "
+                               "experimental\n"));
 
        /*
         * Since sparse_super is the default, we would only have a problem

diff --git a/tests/d_fallocate_bigalloc/expect.gz b/tests/d_fallocate_bigalloc/expect.gz
index 8640bc2..167c069 100644 (file)
Binary files a/tests/d_fallocate_bigalloc/expect.gz and b/tests/d_fallocate_bigalloc/expect.gz differ

diff --git a/tests/d_punch_bigalloc/expect b/tests/d_punch_bigalloc/expect
index caeb3a6..be841e6 100644 (file)
--- a/tests/d_punch_bigalloc/expect
+++ b/tests/d_punch_bigalloc/expect
@@ -1,7 +1,3 @@
-
-Warning: the bigalloc feature is still under development
-See https://ext4.wiki.kernel.org/index.php/Bigalloc for more information
-
 Creating filesystem with 65536 1k blocks and 4096 inodes
 
 Allocating group tables:    \b\b\bdone