Whamcloud - gitweb
LU-9869 lnet: fix incorrect arguments order calling lstcon_session_new 63/28763/2
authorColin Ian King <colin.king@canonical.com>
Fri, 11 Aug 2017 17:17:57 +0000 (13:17 -0400)
committerJohn L. Hammond <john.hammond@intel.com>
Wed, 6 Sep 2017 16:35:42 +0000 (16:35 +0000)
The arguments args->lstio_ses_force and args->lstio_ses_timeout are
in the incorrect order. Fix this by swapping them around.

Detected by CoverityScan, CID#1226833 ("Arguments in wrong order")

Test-Parameters: trivial testlist=lnet-selftest

Lustre-change: https://review.whamcloud.com/28487
Lustre-commit: 0a80067c60043da428c473c331ed7b602c6e960b

Change-Id: If11c574655425db5bbf21ba2264be8d83a7e8bf8
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Sonia Sharma <sonia.sharma@intel.com>
Reviewed-by: Olaf Weber <olaf.weber@hpe.com>
Signed-off-by: Minh Diep <minh.diep@intel.com>
Reviewed-on: https://review.whamcloud.com/28763
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
lnet/selftest/conctl.c

index f9e4c0d..17a95ce 100644 (file)
@@ -69,8 +69,8 @@ lst_session_new_ioctl(struct lstio_session_new_args *args)
        rc = lstcon_session_new(name,
                                args->lstio_ses_key,
                                args->lstio_ses_feats,
-                               args->lstio_ses_force,
                                args->lstio_ses_timeout,
+                               args->lstio_ses_force,
                                args->lstio_ses_idp);
 
        LIBCFS_FREE(name, args->lstio_ses_nmlen + 1);