Whamcloud - gitweb
lib/ext2fs: fix unbalanced mutex unlock for BOUNCE_MTX in unix_io
authorRitesh Harjani (IBM) <ritesh.list@gmail.com>
Mon, 7 Nov 2022 12:20:49 +0000 (17:50 +0530)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 5 Feb 2023 19:51:00 +0000 (14:51 -0500)
f_crashdisk test failed with UNIX_IO_FORCE_BOUNCE=yes due to unbalanced
mutex unlock in below path.

This patch fixes it.

Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/ext2fs/unix_io.c

index 353d85a..3171c73 100644 (file)
@@ -306,7 +306,6 @@ bounce_read:
        while (size > 0) {
                actual = read(data->dev, data->bounce, align_size);
                if (actual != align_size) {
-                       mutex_unlock(data, BOUNCE_MTX);
                        actual = really_read;
                        buf -= really_read;
                        size += really_read;