Whamcloud - gitweb
LU-13845 utils: Quota id 0xFFFFFFFF is invalid 59/39559/5
authorEtienne AUJAMES <eaujames@ddn.com>
Fri, 31 Jul 2020 18:29:43 +0000 (20:29 +0200)
committerOleg Drokin <green@whamcloud.com>
Mon, 19 Oct 2020 03:13:09 +0000 (03:13 +0000)
"lfs setquota" and "lfs quota" should consider as invalid quota id
value 0xFFFFFFFF (aka. (uid_t)-1)

Fixes: 3d9900e78e ("LU-12549 utils: Check range of quota ID for lfs")
Signed-off-by: Etienne AUJAMES <eaujames@ddn.com>
Change-Id: Idbd5970a6f53a544c15bdf22bcf24a7aeba772a8
Reviewed-on: https://review.whamcloud.com/39559
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Wang Shilong <wshilong@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/utils/lfs.c

index 99539b2..d2046d7 100644 (file)
@@ -4212,8 +4212,7 @@ static int str2quotaid(__u32 *id, const char *arg)
        projid_tmp = strtoul(arg, &endptr, 10);
        if (*endptr != '\0')
                return -EINVAL;
-       if (projid_tmp > UINT32_MAX ||
-           (projid_tmp == ULONG_MAX && (errno == ERANGE)))
+       if (projid_tmp >= UINT32_MAX)
                return -ERANGE;
 
        *id = projid_tmp;