Whamcloud - gitweb
libext2fs: fix memory leaks in ext2fs_xattr_set()
authorTheodore Ts'o <tytso@mit.edu>
Tue, 31 Jan 2017 20:29:57 +0000 (15:29 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 31 Jan 2017 20:29:57 +0000 (15:29 -0500)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/ext2fs/ext_attr.c

index 0314f9f..ce2f48f 100644 (file)
@@ -1186,17 +1186,17 @@ errcode_t ext2fs_xattr_set(struct ext2_xattr_handle *handle,
        /* Expand array, append slot */
        err = ext2fs_xattrs_expand(handle, 4);
        if (err)
-               return err;
+               goto errout;
 
        x = handle->attrs + handle->length - 4;
        err = ext2fs_get_mem(strlen(key) + 1, &x->name);
        if (err)
-               return err;
+               goto errout;
        strcpy(x->name, key);
 
        err = ext2fs_get_mem(value_len, &x->value);
        if (err)
-               return err;
+               goto errout;
        memcpy(x->value, value, value_len);
        x->value_len = value_len;
        handle->dirty = 1;