Whamcloud - gitweb
resize2fs: mark that the error return is deliberately ignored
authorTheodore Ts'o <tytso@mit.edu>
Wed, 1 May 2024 04:20:10 +0000 (00:20 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 1 May 2024 04:20:10 +0000 (00:20 -0400)
When moving the inode table, if writing the (partially overlapping)
inode table fails, we need to write it back in its original location
before bailing out.  If that write unding the initial write fails,
there's nothing we can do, so we ignore it.  Mark this to avoid a
false positive from Coverity.

Fixes-Coverity-bug: 1432422
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
resize/resize2fs.c

index f4a4098..e590f93 100644 (file)
@@ -2595,8 +2595,8 @@ static errcode_t move_itables(ext2_resize_t rfs)
                retval = io_channel_write_blk64(fs->io, new_blk,
                                                num, rfs->itable_buf);
                if (retval) {
-                       io_channel_write_blk64(fs->io, old_blk,
-                                              num, rfs->itable_buf);
+                       (void) io_channel_write_blk64(fs->io, old_blk,
+                                                     num, rfs->itable_buf);
                        goto errout;
                }
                if (n > diff) {