Whamcloud - gitweb
LU-8465 e2fsck: make default smallest RA size to 1M 14/39914/9
authorWang Shilong <wshilong@ddn.com>
Tue, 15 Sep 2020 07:06:11 +0000 (15:06 +0800)
committerAndreas Dilger <adilger@whamcloud.com>
Sat, 26 Sep 2020 06:39:00 +0000 (06:39 +0000)
If we have a smaller inodes per group, default ra size could
be very small(etc 128KiB), this hurts performances.

Tune above 128K to 1M, i see pass1 time drop down from
677.12 seconds to 246 secons with 32 threads.

Signed-off-by: Wang Shilong <wshilong@ddn.com>
Change-Id: Id54e156d3a5c65beee23533aa2ae71d34d65ca20
Reviewed-on: https://review.whamcloud.com/39914
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
e2fsck/readahead.c

index 38d4ec4..40b7366 100644 (file)
@@ -234,6 +234,8 @@ int e2fsck_can_readahead(ext2_filsys fs)
        return err != EXT2_ET_OP_NOT_SUPPORTED;
 }
 
+#define MIN_DEFAULT_RA (1024 * 1024)
+
 unsigned long long e2fsck_guess_readahead(ext2_filsys fs)
 {
        unsigned long long guess;
@@ -245,6 +247,8 @@ unsigned long long e2fsck_guess_readahead(ext2_filsys fs)
         * in e2fsck runtime.
         */
        guess = 2ULL * fs->blocksize * fs->inode_blocks_per_group;
+       if (guess < MIN_DEFAULT_RA)
+               guess = MIN_DEFAULT_RA;
 
        /* Disable RA if it'd use more 1/50th of RAM. */
        if (get_memory_size() > (guess * 50))