Whamcloud - gitweb
ext2fs: add readahead method to improve scanning
authorAndreas Dilger <adilger@whamcloud.com>
Fri, 13 Apr 2012 18:58:53 +0000 (12:58 -0600)
committerAndreas Dilger <adilger@whamcloud.com>
Tue, 29 May 2012 08:09:27 +0000 (02:09 -0600)
Add a readahead method for prefetching ranges of disk blocks.
This is useful for inode table scanning, and other large
contiguous ranges of blocks, and may also prove useful for
random block prefetch, since it will allow reordering of the
IO without waiting synchronously for the reads to complete.

It is currently using the posix_fadvise(POSIX_FADV_WILLNEED)
interface, as this proved most efficient during our testing

Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
lib/ext2fs/ext2_io.h
lib/ext2fs/unix_io.c

index 1894fb8..93fd397 100644 (file)
@@ -90,6 +90,8 @@ struct struct_io_manager {
                                        int count, const void *data);
        errcode_t (*discard)(io_channel channel, unsigned long long block,
                             unsigned long long count);
+       errcode_t (*readahead)(io_channel channel, unsigned long block,
+                              int count);
        long    reserved[16];
 };
 
@@ -103,6 +105,7 @@ struct struct_io_manager {
 #define io_channel_close(c)            ((c)->manager->close((c)))
 #define io_channel_set_blksize(c,s)    ((c)->manager->set_blksize((c),s))
 #define io_channel_read_blk(c,b,n,d)   ((c)->manager->read_blk((c),b,n,d))
+#define io_channel_readahead(c,b,n)    ((c)->manager->readahead((c),b,n))
 #define io_channel_write_blk(c,b,n,d)  ((c)->manager->write_blk((c),b,n,d))
 #define io_channel_flush(c)            ((c)->manager->flush((c)))
 #define io_channel_bumpcount(c)                ((c)->refcount++)
index 02570f0..eb8e359 100644 (file)
@@ -15,6 +15,9 @@
  * %End-Header%
  */
 
+#define _XOPEN_SOURCE 600
+#define _DARWIN_C_SOURCE
+#define _FILE_OFFSET_BITS 64
 #define _LARGEFILE_SOURCE
 #define _LARGEFILE64_SOURCE
 #ifndef _GNU_SOURCE
@@ -35,6 +38,9 @@
 #ifdef __linux__
 #include <sys/utsname.h>
 #endif
+#if HAVE_SYS_TYPES_H
+#include <sys/types.h>
+#endif
 #ifdef HAVE_SYS_IOCTL_H
 #include <sys/ioctl.h>
 #endif
@@ -44,9 +50,6 @@
 #if HAVE_SYS_STAT_H
 #include <sys/stat.h>
 #endif
-#if HAVE_SYS_TYPES_H
-#include <sys/types.h>
-#endif
 #if HAVE_SYS_RESOURCE_H
 #include <sys/resource.h>
 #endif
@@ -119,6 +122,8 @@ static errcode_t unix_write_blk64(io_channel channel, unsigned long long block,
                                int count, const void *data);
 static errcode_t unix_discard(io_channel channel, unsigned long long block,
                              unsigned long long count);
+static errcode_t unix_readahead(io_channel channel, unsigned long block,
+                               int count);
 
 static struct struct_io_manager struct_unix_manager = {
        EXT2_ET_MAGIC_IO_MANAGER,
@@ -135,6 +140,7 @@ static struct struct_io_manager struct_unix_manager = {
        unix_read_blk64,
        unix_write_blk64,
        unix_discard,
+       unix_readahead,
 };
 
 io_manager unix_io_manager = &struct_unix_manager;
@@ -819,6 +825,20 @@ static errcode_t unix_write_blk64(io_channel channel, unsigned long long block,
 #endif /* NO_IO_CACHE */
 }
 
+static errcode_t unix_readahead(io_channel channel, unsigned long block,
+                               int count)
+{
+#ifdef POSIX_FADV_WILLNEED
+       struct unix_private_data *data;
+
+       data = (struct unix_private_data *)channel->private_data;
+       posix_fadvise(data->dev, (ext2_loff_t)block * channel->block_size,
+                     (ext2_loff_t)count * channel->block_size,
+                     POSIX_FADV_WILLNEED);
+#endif
+       return 0;
+}
+
 static errcode_t unix_write_blk(io_channel channel, unsigned long block,
                                int count, const void *buf)
 {