Whamcloud - gitweb
git://git.whamcloud.com
/
tools
/
e2fsprogs.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
32b8802
)
libext2fs: fix potential resource leak in ext2fs_file_write
author
Theodore Ts'o
<tytso@mit.edu>
Sat, 23 Jun 2018 01:57:40 +0000
(21:57 -0400)
committer
Theodore Ts'o
<tytso@mit.edu>
Sat, 23 Jun 2018 01:57:40 +0000
(21:57 -0400)
If EXT2_FLAG_SHARE_DUP is set, and ext2fs_bmap2() fails, it's possible
that we will leak the allocated memory in new_block.
Fixes-Coverity-Bug: 1437473
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
lib/ext2fs/fileio.c
patch
|
blob
|
history
diff --git
a/lib/ext2fs/fileio.c
b/lib/ext2fs/fileio.c
index
a5d90a7
..
a0b5d97
100644
(file)
--- a/
lib/ext2fs/fileio.c
+++ b/
lib/ext2fs/fileio.c
@@
-467,8
+467,11
@@
errcode_t ext2fs_file_write(ext2_file_t file, const void *buf,
bmap_flags,
file->blockno, 0,
&file->physblock);
- if (retval)
+ if (retval) {
+ free(new_block);
+ new_block = NULL;
goto fail;
+ }
if (new_block) {
new_block->physblock = file->physblock;