Whamcloud - gitweb
e4crypt: fix spurious "Success" error message
authorJakub Wilk <jwilk@jwilk.net>
Wed, 27 Dec 2023 08:08:05 +0000 (09:08 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 17 Apr 2024 04:35:33 +0000 (00:35 -0400)
Before:

    # e4crypt set_policy 0000000000000000 /dev/null
    /dev/null is not a directory
    /dev/null: Success

After:

    # e4crypt set_policy 0000000000000000 /dev/null
    /dev/null: Not a directory

Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
Link: https://lore.kernel.org/r/20231227080805.6801-1-jwilk@jwilk.net
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
misc/e4crypt.c

index 67d25d8..af90704 100644 (file)
@@ -144,7 +144,7 @@ static void validate_paths(int argc, char *argv[], int path_start_index)
                if (ret < 0)
                        goto invalid;
                if (!S_ISDIR(st.st_mode)) {
-                       fprintf(stderr, "%s is not a directory\n", argv[x]);
+                       errno = ENOTDIR;
                        goto invalid;
                }
        }