Fix potential portability issue in the blkid program. (On architectures

where char is unsigned).  (Addresses Sourceforge Bug: #1180585)

diff --git a/misc/ChangeLog b/misc/ChangeLog
index 3693135..f9bac5d 100644 (file)
--- a/misc/ChangeLog
+++ b/misc/ChangeLog
@@ -1,3 +1,10 @@
+2005-05-06  Theodore Ts'o  <tytso@mit.edu>
+
+       * blkid.c (main): Use an int instead of an char to store the
+               return value from getopt() for better portability on
+               systems where char types are unsigned.  (Addresses
+               Sourceforge Bug: #1180585)
+
 2005-05-05  Theodore Ts'o  <tytso@mit.edu>
 
        * badblocks.c (main), mke2fs.c (PRS): Fix error messages by

diff --git a/misc/blkid.c b/misc/blkid.c
index ecbf8cf..fcadac9 100644 (file)
--- a/misc/blkid.c
+++ b/misc/blkid.c
@@ -121,7 +121,7 @@ int main(int argc, char **argv)
        int err = 4;
        unsigned int i;
        int output_format = 0;
-       char c;
+       int c;
 
        while ((c = getopt (argc, argv, "c:f:ho:s:t:w:v")) != EOF)
                switch (c) {