Whamcloud - gitweb
[BUGFIX]: E2fsck will segfault on disconnected inode with extended attribute(s)
authorTheodore Ts'o <tytso@mit.edu>
Mon, 4 Jul 2005 17:53:36 +0000 (12:53 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 4 Jul 2005 17:53:36 +0000 (12:53 -0500)
commitf76344fb6f9439ecd5060943930e73cd3b3dd9fe
tree86cd62b4efd62524dc86878700155d2105642605
parentcaf037a4564991d6eec6b36de621348598bcb349
[BUGFIX]: E2fsck will segfault on disconnected inode with extended attribute(s)

This was actually caused by two bugs.  The first bug is that if the
inode has been fully fixed up, the code will attempt to remove the
inode from the inode_bad_map without checking to see if this bitmap is
present.  Since it is cleared at the end of pass 2, if
e2fsck_process_bad_inode is called in pass 4 (as it is for
disconnected inodes), this would result in a core dump.

The first bug was mostly hidden by a second bug, which caused
e2fsck_process_bad_inode() to consider all inodes without an extended
attribute to be not fixed.

Note: This bug was introduced in e2fsprogs 1.36.

(Addresses Debian Bug: #316736)
e2fsck/ChangeLog
e2fsck/pass2.c
tests/f_bad_disconnected_inode/expect.1 [new file with mode: 0644]
tests/f_bad_disconnected_inode/expect.2 [new file with mode: 0644]
tests/f_bad_disconnected_inode/image.gz [new file with mode: 0644]
tests/f_bad_disconnected_inode/name [new file with mode: 0644]