Whamcloud - gitweb
e2fsprogs: fix potential null ptr defef in check_for_modules()
authorEric Sandeen <sandeen@redhat.com>
Tue, 24 Feb 2009 21:13:39 +0000 (15:13 -0600)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 6 Mar 2009 07:37:33 +0000 (02:37 -0500)
commitf2fe5da31deebc689bb64e71c8e873efc925d312
treedb14139e8b3b4136d25f5c2d4a82ba45572521f3
parent8d8224550c1f5b5c77afbf5acd95f73979276a0a
e2fsprogs: fix potential null ptr defef in check_for_modules()

The coverity scanner found this one.

If a line in modules.dep has a ":" but no "/" then:

                if ((cp = strchr(buf, ':')) != NULL)
                        *cp = 0;
                else
                        continue;
                if ((cp = strrchr(buf, '/')) != NULL)
                        cp++;
                /* XXX else cp is still null */
                i = strlen(cp);

... we will deref a null pointer (cp).  This can be
demonstrated by putting a line like:

foo.ko:

into modules.dep.  The below change just says that if no "/" is
found, treat the whole string as the module name.

Addresses-Red-Hat-Bugzilla: #486997

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
e2fsck/util.c
lib/blkid/probe.c